From: "Russell King (Oracle)" <linux@armlinux.org.uk>
To: shijie001@208suo.com
Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ARM: mm: Fix warnings in context.c
Date: Wed, 12 Jul 2023 20:24:21 +0100 [thread overview]
Message-ID: <ZK795eVoadj/wARO@shell.armlinux.org.uk> (raw)
In-Reply-To: <60fb2068b0ee6ce2a67333c81ccd2f6b@208suo.com>
On Wed, Jul 12, 2023 at 05:06:32PM +0800, shijie001@208suo.com wrote:
> The following checkpatch warning is removed:
> WARNING: Use #include <linux/mmu_context.h> instead of <asm/mmu_context.h>
>
> Signed-off-by: Jie Shi <shijie001@208suo.com>
> ---
> arch/arm/mm/context.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/mm/context.c b/arch/arm/mm/context.c
> index 4204ffa2d104..c84ad6c786e7 100644
> --- a/arch/arm/mm/context.c
> +++ b/arch/arm/mm/context.c
> @@ -13,7 +13,7 @@
> #include <linux/smp.h>
> #include <linux/percpu.h>
>
> -#include <asm/mmu_context.h>
> +#include <linux/mmu_context.h>
> #include <asm/smp_plat.h>
> #include <asm/thread_notify.h>
> #include <asm/tlbflush.h>
>
Probably haven't noticed, but linux/ includes are all grouped together,
and asm/ includes are all grouped together. Please keep that.
Also, is it really a necessary change, when arch/arm/mm/context.c is
only implementing the interfaces provided by asm/mmu_context.h? I think
the warning is wrong in this case and should never be fixed as things
currently stand.
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2023-07-12 19:26 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <tencent_B7B25B0AACAECB0523A2B09F270CF97BFF07@qq.com>
2023-07-12 9:06 ` [PATCH] ARM: mm: Fix warnings in context.c shijie001
2023-07-12 19:24 ` Russell King (Oracle) [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZK795eVoadj/wARO@shell.armlinux.org.uk \
--to=linux@armlinux.org.uk \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=shijie001@208suo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).