From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1F639EB64DD for ; Wed, 12 Jul 2023 19:38:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Zdeytxd5tTISOVkouDrVYtvCjLsSZjWSyJTwY0Mx9A8=; b=T7gkPJrqdFhJl8 W7mdOIvzryZqWGrsjPgHLUE5C3RVuh5cu8OHsKwDKEoYpmjByDPbUzwfoJHmsOIWNkEMJbQSlzXLa twG4xeB1bVfne5bbWbJwY6ZAxPxgSuiABXr98cKzvQiK8Ex+1nfqlBHMk3W5NqC6Oq+IWuW9u8yC7 yaoeUfIzwoUcAseqKaF4Mi0+fX0bxcZzkYvOXcaQ93lmL3Y2QrYk3xLjUFPHksVKjY3YDbgcDmD6i EXo1XRi3Y9itbsi31730Xd/kl63qg0/GJBV8wNRdq5rDkAd6Sgx07SgxHsYSFKxoG/Qx6a69vNxI6 ZUShqhtTDLmYw8bL6gbQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qJffN-0010f8-1t; Wed, 12 Jul 2023 19:38:25 +0000 Received: from mail-pf1-x42d.google.com ([2607:f8b0:4864:20::42d]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qJffK-0010d3-0Y for linux-arm-kernel@lists.infradead.org; Wed, 12 Jul 2023 19:38:23 +0000 Received: by mail-pf1-x42d.google.com with SMTP id d2e1a72fcca58-66767d628e2so5142698b3a.2 for ; Wed, 12 Jul 2023 12:38:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1689190695; x=1691782695; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=RAqGktah/O0GFdZ50GvGMkJOQPo1Bdaik/QUjfLnP24=; b=WJeDPc4KW7qUMZDwMdPPhOaka2bROkoS7mx53G29NSbD7Ho7yYmc5DWWptBlgYfTxt zfnMq/SKO0HNNKGCdxkL8LGfDh8GBN4fT+3wlM5EicocAxeHR2tEZAF2/cm0pfSJy9FT wV8sXOdOas0qgOoZS4s634XJxtQ+bfVqhwB9hqn2W5sYFiOWciiKaBqgS0W1rs634cwy 08zTJVZyeXy5/rzp7F3HUNoTICYiFnQQettEA/0tjHc11Tjn9tHJlE9VF7TvACuuc108 qj57ut4ZCiACpGnOJ6DiE2jA2keRXkY9lDe2lxK8yeSwDdhAUENDv6WxlBOOIrcUKfrJ PAzA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1689190695; x=1691782695; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=RAqGktah/O0GFdZ50GvGMkJOQPo1Bdaik/QUjfLnP24=; b=FPcy8JhTFoVHbA11QTdPvvjA257RgSH3IkYcZaQHJZGBFHfkIvmzSRQudC4dtoWlCP glZ5v+YbE0oauMD8k2zrZdFhbH4837NJcz3SV+5cN57T6RxXd9PuPHjjy5zSRUvKAlTx JYNy2ag8a8Y/6lEjNE/IqAsaDz+rzoZ9c1Nc59xeeMiKNrQs5NQSB2PMP9HC9HR/BkPC LG7SxFGq05GZQWVO/cp7DL2iqv1P2ibnjHtfdZ1b/NlWlufxrT+Y8qU5tSl8GhssE/b1 arteD+YERqg73Sao03TQSGbJJuAiXN6uD0JvQOb6KZwUYxSYSiAq+yv41ty5Yhsy4J2Z bC5w== X-Gm-Message-State: ABy/qLYbQkBIRfFLN9Y3zsGDiRizy0fbwxFRDK6vQ1u3es+69IwPcUnB tOdfZnFmVXnr6tkb0xgn7mjJqQ== X-Google-Smtp-Source: APBJJlGMOcbAwwVpsCYEnmiXNjwnmO20wsWdfSSDUrRNsz5IVZWYyjz+0agcO2l6LoBeRiJr0STtHg== X-Received: by 2002:a05:6a00:148b:b0:681:6169:e403 with SMTP id v11-20020a056a00148b00b006816169e403mr19538672pfu.8.1689190695254; Wed, 12 Jul 2023 12:38:15 -0700 (PDT) Received: from p14s ([2604:3d09:148c:c800:70ea:7145:ddf8:7208]) by smtp.gmail.com with ESMTPSA id v11-20020aa7808b000000b00669c99d05fasm3907344pff.150.2023.07.12.12.38.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 12 Jul 2023 12:38:14 -0700 (PDT) Date: Wed, 12 Jul 2023 13:38:12 -0600 From: Mathieu Poirier To: Tinghan Shen Cc: Bjorn Andersson , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Matthias Brugger , AngeloGioacchino Del Regno , linux-remoteproc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, Project_Global_Chrome_Upstream_Group@mediatek.com Subject: Re: [PATCH v14 10/12] remoteproc: mediatek: Report watchdog crash to all cores Message-ID: References: <20230707052612.27521-1-tinghan.shen@mediatek.com> <20230707052612.27521-11-tinghan.shen@mediatek.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230707052612.27521-11-tinghan.shen@mediatek.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230712_123822_205237_8EC7F1F8 X-CRM114-Status: GOOD ( 18.87 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Jul 07, 2023 at 01:26:10PM +0800, Tinghan Shen wrote: > Once the SCP watchdog timeout happened, trigger the rproc recovery flow on > all cores. > You are missing the most important part... "Why" is this needed? Without it I don't know what is going on and can't review your work. > Signed-off-by: Tinghan Shen > --- > drivers/remoteproc/mtk_scp.c | 8 +++++++- > 1 file changed, 7 insertions(+), 1 deletion(-) > > diff --git a/drivers/remoteproc/mtk_scp.c b/drivers/remoteproc/mtk_scp.c > index 9fed5161f094..7e786aaf04e1 100644 > --- a/drivers/remoteproc/mtk_scp.c > +++ b/drivers/remoteproc/mtk_scp.c > @@ -80,8 +80,14 @@ EXPORT_SYMBOL_GPL(scp_put); > > static void scp_wdt_handler(struct mtk_scp *scp, u32 scp_to_host) > { > + struct mtk_scp_of_cluster *scp_cluster = platform_get_drvdata(scp->cluster_pdev); > + struct mtk_scp *scp_node; > + > dev_err(scp->dev, "SCP watchdog timeout! 0x%x", scp_to_host); > - rproc_report_crash(scp->rproc, RPROC_WATCHDOG); > + > + /* report watchdog timeout to all cores */ > + list_for_each_entry(scp_node, &scp_cluster->mtk_scp_list, elem) > + rproc_report_crash(scp_node->rproc, RPROC_WATCHDOG); > } > > static void scp_init_ipi_handler(void *data, unsigned int len, void *priv) > -- > 2.18.0 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel