From: Frank Li <Frank.li@nxp.com>
To: Suzuki K Poulose <suzuki.poulose@arm.com>
Cc: imx@lists.linux.dev, Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Shawn Guo <shawnguo@kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Fabio Estevam <festevam@gmail.com>,
NXP Linux Team <linux-imx@nxp.com>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>,
"moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE"
<linux-arm-kernel@lists.infradead.org>,
open list <linux-kernel@vger.kernel.org>,
coresight@lists.linaro.org
Subject: Re: [PATCH 1/1] arm64: dts: imx8mp: Add coresight trace components
Date: Wed, 5 Jul 2023 16:40:07 -0400 [thread overview]
Message-ID: <ZKXVJ1U8UbFSrsqM@lizhi-Precision-Tower-5810> (raw)
In-Reply-To: <33362029-3d5b-b16a-27e7-578df34f0ede@arm.com>
On Tue, Jul 04, 2023 at 04:20:18PM +0100, Suzuki K Poulose wrote:
> On 05/05/2023 20:51, Frank Li wrote:
> > Add coresight trace components (ETM, ETF, ETB and Funnel).
> >
> > ┌───────┐ ┌───────┐ ┌───────┐
> > │ CPU0 ├─►│ ETM0 ├─►│ │
> > └───────┘ └───────┘ │ │
> > │ │
> > ┌───────┐ ┌───────┐ │ ATP │
> > │ CPU1 ├─►│ ETM1 ├─►│ │
> > └───────┘ └───────┘ │ │
> > │ FUNNEL│
> > ┌───────┐ ┌───────┐ │ │
> > │ CPU2 ├─►│ ETM2 ├─►│ │
> > └───────┘ └───────┘ │ │ ┌─────┐ ┌─────┐
> > │ │ │ │ │ │
> > ┌───────┐ ┌───────┐ │ │ │ M7 │ │ DSP │
> > │ CPU3 ├─►│ ETM3 ├─►│ │ │ │ │ │
> > └───────┘ └───────┘ └───┬───┘ └──┬──┘ └──┬──┘ AXI
> > │ │ │ ▲
> > ▼ ▼ ▼ │
> > ┌───────────────────────────┐ ┌─────┐ ┌─┴──┐
> > │ ATP FUNNEL ├──►│ETF ├─► │ETR │
> > └───────────────────────────┘ └─────┘ └────┘
> >
> > Signed-off-by: Frank Li <Frank.Li@nxp.com>
> > ---
> > arch/arm64/boot/dts/freescale/imx8mp.dtsi | 179 ++++++++++++++++++++++
> > 1 file changed, 179 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/freescale/imx8mp.dtsi b/arch/arm64/boot/dts/freescale/imx8mp.dtsi
> > index a19224fe1a6a..0fa74477b9e1 100644
> > --- a/arch/arm64/boot/dts/freescale/imx8mp.dtsi
> > +++ b/arch/arm64/boot/dts/freescale/imx8mp.dtsi
> > @@ -304,6 +304,185 @@ soc: soc@0 {
> > nvmem-cells = <&imx8mp_uid>;
> > nvmem-cell-names = "soc_unique_id";
> > + etm0: etm@28440000 {
> > + compatible = "arm,coresight-etm4x", "arm,primecell";
> > + reg = <0x28440000 0x10000>;
> > + arm,primecell-periphid = <0xbb95d>;
>
> Why is this needed (and for all the ETMs) ?
Reg size is wrong set to 64k(should be 4k), so crash when call amba_read_periphid().
let me send out a fixed patch.
Thank you for found it.
Frank
>
> Suzuki
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2023-07-05 20:56 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-05 19:51 [PATCH 1/1] arm64: dts: imx8mp: Add coresight trace components Frank Li
2023-06-09 8:20 ` Alexander Stein
2023-06-12 18:53 ` Frank Li
2023-07-04 15:20 ` Suzuki K Poulose
2023-07-05 20:40 ` Frank Li [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZKXVJ1U8UbFSrsqM@lizhi-Precision-Tower-5810 \
--to=frank.li@nxp.com \
--cc=coresight@lists.linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=imx@lists.linux.dev \
--cc=kernel@pengutronix.de \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=suzuki.poulose@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox