From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 903B9EB64D9 for ; Thu, 6 Jul 2023 19:36:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Reply-To:Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date :Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=DNdwRsqqm087D4EIU67oFlWG43nfQRteu4hsQ5681b4=; b=JU4ok+fS1IkgbmDBb6tpuVs73F APapK5go1vbjs701X7JGnt40DnU0DD8qrS2MUueWV6kqwTTPM1cVdSxhPRPORsasmju9mGxyBKo9D rbEpc+TA6olyX2msF24EnSZmZ65GbBWUlm9qRRAmuU8+rGaY+VhBSrTWc3hijRAuD5HwQDh7YeUBN d7CAYeZcfmaEb/Lvq1n2WjGjXLovQMUBX1UWjlsvmGc3q/YcmQFEzREns4/8Rc9Fdyvtnpy3Jtcwt D2xS2e2qm1RMuqi20RHsqAEAmxWxutUrvbRbdnIabVxqmJ0FCyBkODdISQfM3u0gOEqf2dafgZ4Y6 upMkMLMQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qHUm5-002WIK-1X; Thu, 06 Jul 2023 19:36:21 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qHUm3-002WHw-1y for linux-arm-kernel@lists.infradead.org; Thu, 06 Jul 2023 19:36:20 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id F086161190; Thu, 6 Jul 2023 19:36:18 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B5B9BC433C8; Thu, 6 Jul 2023 19:36:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1688672178; bh=/lzJT5FgwDvChrayhIE8uP+Q5Qrf9eUTpgkA05PLe9g=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=nP1N0x4Ii4JSYrh89o8puWKJNSXfMWKkHigRxz3VPBH9RnDrm5H04ME59OIBmEvWH cHf26fkZrsM1kbLB6yNrZE7asm/bnzQ2/Smboxotlpslb9zDBZVdCicn7x9Ih2fb5g V/y4DPeUyQMLYkW8/5xrY/pS5zgIK0cwdcLcs4Nts7dbsnUtnPFGh5QX1RFwImi84h Pr9zu+j/RNKkYAKcsQQ2/f6R9ZyMNICv76xSwZFl+OvQ6rtc/o434hQQyf0GBbg682 Q6BLgSXTAIiw0GPSfgIAeJXq84tv+KLDIYy+KW5OEbZiisSKiGz9RSFGm6uG9tMwxm 6GezZlMD9uVLQ== Date: Thu, 6 Jul 2023 21:36:14 +0200 From: Wolfram Sang To: YE Chengfeng Cc: "andi.shyti@kernel.org" , "rjui@broadcom.com" , "sbranden@broadcom.com" , "linux-i2c@vger.kernel.org" , Linux ARM , "linux-kernel@vger.kernel.org" , "bcm-kernel-feedback-list@broadcom.com" Subject: Re: [PATCH] i2c: bcm-iproc: Fix bcm_iproc_i2c_isr deadlock issue Message-ID: Mail-Followup-To: Wolfram Sang , YE Chengfeng , "andi.shyti@kernel.org" , "rjui@broadcom.com" , "sbranden@broadcom.com" , "linux-i2c@vger.kernel.org" , Linux ARM , "linux-kernel@vger.kernel.org" , "bcm-kernel-feedback-list@broadcom.com" References: MIME-Version: 1.0 In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230706_123619_735293_BED34902 X-CRM114-Status: GOOD ( 11.98 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: multipart/mixed; boundary="===============2100106518096355139==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============2100106518096355139== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="Aw1VKsa6Y9g8S+lk" Content-Disposition: inline --Aw1VKsa6Y9g8S+lk Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, Jun 24, 2023 at 07:36:02PM +0000, YE Chengfeng wrote: > iproc_i2c_rd_reg and iproc_i2c_wr_reg are called from both > interrupt context (e.g. bcm_iproc_i2c_isr) and process context > (e.g. bcm_iproc_i2c_suspend). Therefore, interrupts should be > disabled to avoid potential deadlock. To prevent this deadlock, > use spin_lock_irqsave. >=20 > Signed-off-by: Chengfeng Ye I can't apply it, what version is this against? Also, if someone could supply a proper Fixes-tag, this would be much appreciated. --Aw1VKsa6Y9g8S+lk Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEOZGx6rniZ1Gk92RdFA3kzBSgKbYFAmSnF64ACgkQFA3kzBSg KbYXog//bWuH5tT+g+rfzCtBvU9hPR74K3YyGxSwnQm5JxFA4wyclH0H35sZ6Jnf 87X8j5AcJzmVVf8Px/MKkppsXuxGq1oa8lkwaksbTltZSLzCewlSSOPjWqSKW3sf CcUHROKMvjGaCnRvEZvfRWx/7Qu2b7b+y0Ly8M5TDEYAqtcYeaXzmeyF5OU9C023 YiLoZTKyQSDvgOz6/+FEJ4d+5mj9+zU6tT3Kc06DuSTrc9mcqF2O5qD7to8CgZbL CrvLnN2HS4ajHnVBObrYgL98hQsIwjfi5d2QwB6Sa1Y32VFQwZQ1oNrGz5QqXn/B gmjJg1nOBBfccU1Ik+XqR4tqjiW5HcUGnMkJs6fZabG5oOc/s9x2/5Ob0UdJXxoK TtEZKFH467ZagVEOgiGgzyFZOSbxFBKuuDvmJ+Nv1wn+PEv0Rov7yC9VjLVN3d8R Kxme8nhvKYjaYu3geIYgAcrlD8zdjvZXTjqVvMhadz7cITOfOBF8VAGGT/aBu1t1 GlXTgwlB7tG9QEX13kY0gASE5Oll8TDUc3nRkUu1fLPA24sY5AaVEUvqWDN5S5IC THMfKexeL5PUZeWSBUXQ1jXRjvpgzLz7JWqMpHVGKBN5sKYUyVo4zjbnGanTwBYa z6jQ541Di84pis+5W9v3IjPSH3P2903DquPgeSbV0dzas52so2A= =x1Cp -----END PGP SIGNATURE----- --Aw1VKsa6Y9g8S+lk-- --===============2100106518096355139== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============2100106518096355139==--