From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 717F8EB64D9 for ; Mon, 10 Jul 2023 08:44:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=9untlKsb8MiuWMkKVbOPnXJ1ZQYAY1i+N33t5ER0vgU=; b=lnNV/PaYDUOU0V dSDFqgKAEETIUKyQLc6iLCCzsuz7hGIPPqr8zNUNEW17Oy94Foyz2PoWIHHtr2w3HO++mwhMg8gV2 4RBPRlsLf2aFVDQ7Z/TjaaJhKhb2u9YUpX23g9lT99lPc8mQNFent+HT1m2e4QJM1faJPGosRzvZt qVwr2pi6ZiQrfoGTeLEzwM/Xe/MpRp4cbiBmOf4kk6o+Al8fj+v4Pw9RGx+wZ2Ddfztrb0auJPc4E VDP21/73bg89L+xLOr9mJTGLmaEGKnU1Zq+U4U6WtRQxJT7RRaal445QVKXh3oylccuomVMJ+baVp VCMon2nmO5nd6iawIgZQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qImUv-00AtWl-0p; Mon, 10 Jul 2023 08:43:57 +0000 Received: from mga07.intel.com ([134.134.136.100]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qImUt-00AtVj-0b for linux-arm-kernel@lists.infradead.org; Mon, 10 Jul 2023 08:43:56 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1688978635; x=1720514635; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=1zM/gpodLaV7OJJExvISyfwG0UqSf+pC2kfSVD3HiTk=; b=Z9O3iKbpHI5Lq/GYPHZWtKCrxUgdHqFbCbjm/a3kjr9j3R3RtTvAyDeV g8yNXe+sV4cA63aX/6QSaIM46FU60jiWj3ZQ7tdlP07Pgqi4eBvoczYeD 3ulvflfVbe12tLhUcQD3wwkqfxrZ1CKJ7We7pTV/9a26mbJI8epjkLICQ uamfR5zvC8aFtB9Zp8oAR0Y/LPexkCtG3M9kJg6C2diLfMGeA7zpuqHWM seoXH1KY7VG4kVIi8T+821oOo44tyYclUSXavm8bQbS49ZIX33EWwDN4O PRNEtzPN4bnan29GH3m1z0iT9TEr5zDE/Eek4pTTIfwjzGpXNlQp2qOU+ g==; X-IronPort-AV: E=McAfee;i="6600,9927,10766"; a="430362970" X-IronPort-AV: E=Sophos;i="6.01,194,1684825200"; d="scan'208";a="430362970" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Jul 2023 01:43:52 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10766"; a="750276443" X-IronPort-AV: E=Sophos;i="6.01,194,1684825200"; d="scan'208";a="750276443" Received: from yilunxu-optiplex-7050.sh.intel.com (HELO localhost) ([10.239.159.165]) by orsmga008.jf.intel.com with ESMTP; 10 Jul 2023 01:43:49 -0700 Date: Mon, 10 Jul 2023 16:42:22 +0800 From: Xu Yilun To: Michal Simek Cc: Yangtao Li , Moritz Fischer , Wu Hao , Tom Rix , linux-fpga@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 5/8] fpga: xilinx-pr-decoupler: Convert to devm_platform_ioremap_resource() Message-ID: References: <20230705094655.44753-1-frank.li@vivo.com> <20230705094655.44753-5-frank.li@vivo.com> <8aa1704a-f34e-1bf2-76cc-1324b0a0404a@amd.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <8aa1704a-f34e-1bf2-76cc-1324b0a0404a@amd.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230710_014355_267097_B496FEF9 X-CRM114-Status: GOOD ( 15.15 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 2023-07-07 at 06:55:33 +0200, Michal Simek wrote: > > > On 7/5/23 11:46, Yangtao Li wrote: > > Use devm_platform_ioremap_resource() to simplify code. > > > > Signed-off-by: Yangtao Li > > --- > > drivers/fpga/xilinx-pr-decoupler.c | 4 +--- > > 1 file changed, 1 insertion(+), 3 deletions(-) > > > > diff --git a/drivers/fpga/xilinx-pr-decoupler.c b/drivers/fpga/xilinx-pr-decoupler.c > > index b76d85449b8f..208d9560f56d 100644 > > --- a/drivers/fpga/xilinx-pr-decoupler.c > > +++ b/drivers/fpga/xilinx-pr-decoupler.c > > @@ -108,7 +108,6 @@ static int xlnx_pr_decoupler_probe(struct platform_device *pdev) > > struct xlnx_pr_decoupler_data *priv; > > struct fpga_bridge *br; > > int err; > > - struct resource *res; > > priv = devm_kzalloc(&pdev->dev, sizeof(*priv), GFP_KERNEL); > > if (!priv) > > @@ -122,8 +121,7 @@ static int xlnx_pr_decoupler_probe(struct platform_device *pdev) > > priv->ipconfig = match->data; > > } > > - res = platform_get_resource(pdev, IORESOURCE_MEM, 0); > > - priv->io_base = devm_ioremap_resource(&pdev->dev, res); > > + priv->io_base = devm_platform_ioremap_resource(pdev, 0); > > if (IS_ERR(priv->io_base)) > > return PTR_ERR(priv->io_base); > > Acked-by: Michal Simek Acked-by: Xu Yilun Applied. > > M _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel