From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9EE22EB64DA for ; Mon, 10 Jul 2023 08:56:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=y5iSLQrQPFSn3IRHtLyXL1lZFb2HU+t50W6WMlyzOEA=; b=QQrYCi1PEh1SzI t+1Zc6WYeEA1SZ6WTfUd6WvPC5VYeWTDwDVwoE0VIZz0BJ0HOpzCY3bFdRLrOwimPkV46lQd81qGV dviT69MIx+t4OXXjagcYIOUTQ59mNgwPZUTeD400OrUe3fgo3zyYReO1jgWiHt8APFEpUsEOsPrns 08NkUVWbJ9lNnz7+XL21bdzEGkNLu0QRABI6GxiVg3AS4muky94uaiXn29datzVaUcd87N8G2r0Lw 7jPS2Q6kzSBTrO/9M648uQVN5drINWmJqHTuIQDmZ0Ls8kHpMJcCmoCcnO31gY3G9yR1HYdQIKRv+ wOzba5Auxt9KXL+7K+nw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qImgc-00Av3h-2f; Mon, 10 Jul 2023 08:56:02 +0000 Received: from mga06b.intel.com ([134.134.136.31] helo=mga06.intel.com) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qImgZ-00Av36-28 for linux-arm-kernel@lists.infradead.org; Mon, 10 Jul 2023 08:56:00 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1688979359; x=1720515359; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=664qAjZzrPJKlFFIMH/+AQs2HvURbTM/1kF3QMuprbU=; b=kECOpSJ2d60sWxTK/AyAzC/ISNb0C9jvjf3bKJLNiM2hkMRjWz2x21wU XeNsIvF38dJUS11PBzWSowAIlJ6dPSCa7R2XSdybLanNRUidt6FOoElO+ gGbRQtQeiQBACA9h9gkyDJ04p1UjRw75jSjDDjc2KGQfbDaL4gX/JgE1e SfoFBnG0+3aL5oAwTyvN+pHOD28kmb4fT5vWUByQhE6SgrcI1+4UWuSFO te+pd2w6aTKX1h7KSoHDvAc8udLnHiYzbfCJiUNfiirsLQLLGHc6Uh5n4 nKUYL0Jpe1x6pMPBIOqHobfQaqaZBKUS/GplgH+xUpN8eBtnV3t7O8DhD A==; X-IronPort-AV: E=McAfee;i="6600,9927,10766"; a="427983571" X-IronPort-AV: E=Sophos;i="6.01,194,1684825200"; d="scan'208";a="427983571" Received: from orsmga006.jf.intel.com ([10.7.209.51]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Jul 2023 01:55:58 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10766"; a="697932259" X-IronPort-AV: E=Sophos;i="6.01,194,1684825200"; d="scan'208";a="697932259" Received: from yilunxu-optiplex-7050.sh.intel.com (HELO localhost) ([10.239.159.165]) by orsmga006.jf.intel.com with ESMTP; 10 Jul 2023 01:55:56 -0700 Date: Mon, 10 Jul 2023 16:54:28 +0800 From: Xu Yilun To: Michal Simek Cc: Yangtao Li , Moritz Fischer , Wu Hao , Tom Rix , linux-fpga@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 8/8] fpga: zynq-fpga: Convert to devm_platform_ioremap_resource() Message-ID: References: <20230705094655.44753-1-frank.li@vivo.com> <20230705094655.44753-8-frank.li@vivo.com> <73eaa72b-9ee2-3aca-b5b9-bc53e6a40467@amd.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <73eaa72b-9ee2-3aca-b5b9-bc53e6a40467@amd.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230710_015559_741892_E48E2DDC X-CRM114-Status: GOOD ( 15.42 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 2023-07-07 at 06:55:49 +0200, Michal Simek wrote: > > > On 7/5/23 11:46, Yangtao Li wrote: > > Use devm_platform_ioremap_resource() to simplify code. > > > > Signed-off-by: Yangtao Li > > --- > > drivers/fpga/zynq-fpga.c | 4 +--- > > 1 file changed, 1 insertion(+), 3 deletions(-) > > > > diff --git a/drivers/fpga/zynq-fpga.c b/drivers/fpga/zynq-fpga.c > > index f8214cae9b6e..96611d424a10 100644 > > --- a/drivers/fpga/zynq-fpga.c > > +++ b/drivers/fpga/zynq-fpga.c > > @@ -555,7 +555,6 @@ static int zynq_fpga_probe(struct platform_device *pdev) > > struct device *dev = &pdev->dev; > > struct zynq_fpga_priv *priv; > > struct fpga_manager *mgr; > > - struct resource *res; > > int err; > > priv = devm_kzalloc(dev, sizeof(*priv), GFP_KERNEL); > > @@ -563,8 +562,7 @@ static int zynq_fpga_probe(struct platform_device *pdev) > > return -ENOMEM; > > spin_lock_init(&priv->dma_lock); > > - res = platform_get_resource(pdev, IORESOURCE_MEM, 0); > > - priv->io_base = devm_ioremap_resource(dev, res); > > + priv->io_base = devm_platform_ioremap_resource(pdev, 0); > > if (IS_ERR(priv->io_base)) > > return PTR_ERR(priv->io_base); > > Acked-by: Michal Simek Acked-by: Xu Yilun Applied. > > M _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel