From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DEC29EB64D9 for ; Mon, 10 Jul 2023 11:25:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=lSY0KLih8JBgIff8JfGVVMwB77VEtEs0Q4+5zyP40Sg=; b=0RopSuDr/yAA+G OKVhGmalfanHzkVtnRVP30+dazrB0dgIEO06RmL1wsYl/ULIeMxQU8MM5SwiMgHfqbnWoD9o/7MNF egX5VTspn7oKoaRBF7chNzpnv1LRTMW/fKKRE34yaWYtXcNy9jSmon1dqstMrxpbG/lzMPKVH7Bvo +p/V3oY/wElElCqxECiQlZPgMkKjinPNHPnbhPXVjopSa1HCKSz5p1zEajFrsF51g/gNqcD2FOdP8 9acdEO/lKdTE8ZvB/otdosqckGFW3utZdwPTn4E+p59ml3CqAiMlFccBdGIRXbfBlSSKNmmkG27Tm 8aNPEUSwwSC/xpYePoRQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qIp12-00BTSG-1B; Mon, 10 Jul 2023 11:25:16 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qIp0z-00BTRF-0G for linux-arm-kernel@lists.infradead.org; Mon, 10 Jul 2023 11:25:14 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 6DE3D2B; Mon, 10 Jul 2023 04:25:49 -0700 (PDT) Received: from FVFF77S0Q05N (unknown [10.57.29.14]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 8D4783F67D; Mon, 10 Jul 2023 04:25:05 -0700 (PDT) Date: Mon, 10 Jul 2023 12:25:02 +0100 From: Mark Rutland To: Anshuman Khandual Cc: linux-arm-kernel@lists.infradead.org, Catalin Marinas , Will Deacon , Ryan Roberts , Andrew Morton , David Hildenbrand , Jonathan Corbet , linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org Subject: Re: [RFC 0/4] arm64/mm: Clean up pte_dirty() state management Message-ID: References: <20230707053331.510041-1-anshuman.khandual@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230707053331.510041-1-anshuman.khandual@arm.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230710_042513_189663_76CC71BB X-CRM114-Status: GOOD ( 19.60 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Jul 07, 2023 at 11:03:27AM +0530, Anshuman Khandual wrote: > These pte_dirty() changes make things explicitly clear, while improving the > code readability. This optimizes HW dirty state transfer into SW dirty bit. > This also adds a new arm64 documentation explaining overall pte dirty state > management in detail. This series applies on the latest mainline kernel. TBH, I think this is all swings and roundabouts, and I'm not sure this is worthwhile. I appreciate that as-is some people find this confusing, but I don't think the end result of this series is actually better, and it adds more code/documentation to maintain. In particular, I don't think that we should add Documentation/ files for this, as it's very likely that won't be updated together with the code, and I think it's more of a maintenance burden than a help. If we want some introductory text to explain how the HW/SW dirty bits work, I think that should be a comment block in , clearly associated with the code. Overall, I'd prefer to leave the code as-is. Thanks, Mark. > > Cc: Catalin Marinas > Cc: Will Deacon > Cc: Ryan Roberts > Cc: Mark Rutland > Cc: Andrew Morton > Cc: David Hildenbrand > Cc: Jonathan Corbet > Cc: linux-arm-kernel@lists.infradead.org > Cc: linux-kernel@vger.kernel.org > Cc: linux-doc@vger.kernel.org > > Anshuman Khandual (4): > arm64/mm: Add SW and HW dirty state helpers > arm64/mm: Call pte_sw_mkdirty() while preserving the HW dirty state > arm64/mm: Add pte_preserve_hw_dirty() > docs: arm64: Add help document for pte dirty state management > > Documentation/arch/arm64/index.rst | 1 + > Documentation/arch/arm64/pte-dirty.rst | 95 ++++++++++++++++++++++++++ > arch/arm64/include/asm/pgtable.h | 66 ++++++++++++++---- > 3 files changed, 147 insertions(+), 15 deletions(-) > create mode 100644 Documentation/arch/arm64/pte-dirty.rst > > -- > 2.30.2 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel