From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2E474EB64D9 for ; Tue, 11 Jul 2023 00:41:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=i3IXv5kpqltk8OQ4Uce3uG+sXMVzRWmZ9uvTc53L6WI=; b=F8oX5/CCM2S9Ag C0uv+RqgbFHM5p4Z9KEVj9sEQFyl+zIqRevBN1XfeSAwk6IajJaYbDFL9MILtCdsJUKruPARCVLHn qWteY650My9/dTSZWl6LhynSG7xUetEaJYFZ6yYDMPRH4IgP8MRDQV2HxyIPr9aPN7JLuA+y9uhCI 0Na03FP3EN3xaa2u4u1C/D42ZlNt7ErnRra1txC8jmvzLsDA0ET6vVQz8JvoQDHK/Nj8n5Qghn2Lf UvzauWa0eIo1vovnwNuYLzEWfiW48JjLYRJ7NZgmcxa1DqHBchmYhhiIqGBeidI+v/UeIx5AmJvz6 k5jNbztXunRUs0s7s6BQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qJ1R0-00D5Du-2x; Tue, 11 Jul 2023 00:40:54 +0000 Received: from mail-pf1-x433.google.com ([2607:f8b0:4864:20::433]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qJ1Qy-00D5D6-1q for linux-arm-kernel@lists.infradead.org; Tue, 11 Jul 2023 00:40:53 +0000 Received: by mail-pf1-x433.google.com with SMTP id d2e1a72fcca58-6726d5d92afso3970454b3a.1 for ; Mon, 10 Jul 2023 17:40:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1689036049; x=1691628049; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=Gv3YcFx+E67TlMawHPFpx9khsk0UQoRAm7W/1UIFjxw=; b=leUms+CBlpLmSsE/qf03mSipNOUG3B43fCdqlgeHH+fNh8OZsq/BXX/yvfGVL8CTLG L7mVyJdoDLgO/XtDeGx6yLQtoVGegg9WzuD5V08HPmHYm8Ll1kOL8gcGGrReae/EVe6D +WAol/sd7AheBfOcpR2GuVRQvoehfDPXq/FjQpzEKKqXMFubkmmjhfJt35kcOVZU32yH Y+X4zG7qB6Uad84r0tv+PDr7C33IoQ0wKF9eSXSPoEpWkxKnKI3w1EtxbOUqLo+Cwy67 FxY3BhGLWnBtoijx+f4sNqWX5JXX3qnbpJQ5SV/u5IBpAiQuKLfYz4rxIzJJV28L5zWt bzaA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1689036049; x=1691628049; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Gv3YcFx+E67TlMawHPFpx9khsk0UQoRAm7W/1UIFjxw=; b=eUzF2E4C588UZQwvvP5anL81rSJ5aJ3/zPcxU9AsUphQzHymJ/6ux6pBeABICiY8f8 Ap4WvV91kVk49guJtJZOiFZaKktpziRRDFNEhZADtrIfamwu0vGn2eKmiBIlIwDZXdpm EI4d7zw6AhoFfVDXFyEOFUboLWJHxMj4vJmKt7fwKBuH1vejjnVYaSWObSWw5SnGj/JF LOvYOIxPVncogm04jYYqBKYkqrNDQ7jqQJ8OSJS/hlt81onGjd18h8rQ0LNYUor7C+NT Fwjuw+RHw7rOj7CawK7O96K2VE8C0hPqydLuts99JZAerVuM+b76wKZmvLqsROtRs7uk a46Q== X-Gm-Message-State: ABy/qLbiXL+v17q2ujnyobzHJgxU9iNZ8k7GyCW4kx/jg30InN5mOoHA dDTJvac0faF6DpbzpCFHzJI= X-Google-Smtp-Source: APBJJlHVHuFWb1DBTwEgEs4Na5PXZ8piu5rpwuRUnYbKv90ZemBiZgvC7ON2H5iDAh5Loo26oohNZQ== X-Received: by 2002:a05:6a20:9383:b0:12e:c5fb:757 with SMTP id x3-20020a056a20938300b0012ec5fb0757mr23302594pzh.5.1689036049405; Mon, 10 Jul 2023 17:40:49 -0700 (PDT) Received: from google.com ([2620:15c:9d:2:96bf:7e77:39eb:7a23]) by smtp.gmail.com with ESMTPSA id bu16-20020a632950000000b0055bac197d70sm287489pgb.53.2023.07.10.17.40.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 10 Jul 2023 17:40:49 -0700 (PDT) Date: Mon, 10 Jul 2023 17:40:46 -0700 From: Dmitry Torokhov To: Yangtao Li Cc: Vladimir Zapolskiy , Kevin Wells , Durgesh Pattamatta , linux-input@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 09/10] Input: lpc32xx_ts - stop_tsc when driver remove Message-ID: References: <20230705052346.39337-1-frank.li@vivo.com> <20230705052346.39337-9-frank.li@vivo.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230705052346.39337-9-frank.li@vivo.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230710_174052_607054_BE5BE7B9 X-CRM114-Status: GOOD ( 18.45 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi, On Wed, Jul 05, 2023 at 01:23:45PM +0800, Yangtao Li wrote: > When the driver is removed, we need to close the device. > > Fixes: 3045a5f5202a ("Input: add LPC32xx touchscreen controller driver") > Signed-off-by: Yangtao Li > --- > drivers/input/touchscreen/lpc32xx_ts.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/input/touchscreen/lpc32xx_ts.c b/drivers/input/touchscreen/lpc32xx_ts.c > index 15b5cb763526..ffdd748a9992 100644 > --- a/drivers/input/touchscreen/lpc32xx_ts.c > +++ b/drivers/input/touchscreen/lpc32xx_ts.c > @@ -305,6 +305,8 @@ static int lpc32xx_ts_remove(struct platform_device *pdev) > struct lpc32xx_tsc *tsc = platform_get_drvdata(pdev); > struct resource *res; > > + lpc32xx_stop_tsc(tsc); > + This change is not needed because lpc32xx_stop_tsc() is already being called from lpc32xx_ts_close() which is called when we unregister input device (provided that open() was called earlier). Thanks. -- Dmitry _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel