From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A757FEB64DA for ; Fri, 14 Jul 2023 11:19:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Reply-To:Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date :Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=WWnIvxh6jkgFlhD250fDOZV55091BUERCYXmxfX+Zk0=; b=Th/3SHlP93oxDODkkNgmpa32k8 cYRo9oHtil0P8MRS5S7RwSh+H6T3scAmDRIBE8aQM7T1BlWOY7DV5/lHzbZd8G2chfxovMo02ze0i ssXk/zlXYelNdsfLVyhP/Nlrh3o+uliKvLLFR+tJlXHhY0E3HG3qJxjODLDa0rmdEHRtuJhhxRpEB e28S8GpjiUY82xmFMVKp1Lw+3IES+Y+RCgrR14LWgwbkubKcfEyRI20mLxh0Z749K1nLj3NU3rNRR A9798aANIkotaYO+mdtKh1QG4xn7l1trA3VPMeQHhwVSv5VcvvR3iq6YY5y1D6nJUYX6KdngPfNYa abLJTj5g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qKGpb-00639C-1R; Fri, 14 Jul 2023 11:19:27 +0000 Received: from mail-pl1-x632.google.com ([2607:f8b0:4864:20::632]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qKGpY-00637z-0L for linux-arm-kernel@lists.infradead.org; Fri, 14 Jul 2023 11:19:25 +0000 Received: by mail-pl1-x632.google.com with SMTP id d9443c01a7336-1b89600a37fso10726115ad.2 for ; Fri, 14 Jul 2023 04:19:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1689333561; x=1691925561; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=nUTuhMaDrSiRcPnXk8P8ZOacIizK0ZULRB/535ud0vE=; b=ZUYCSWEkO2ru97nyEgNoTSPwlSHcSGPPfjDhuLemmy+Ztw0FbKmKRMJ29H0taW3eNq vg7im92XoJ3u7vi47g3v1WlJ5aP/Dm1U/62KCUPFpW7N8H89dPOd0K3dYqxyfAgqJQvH vql6i2TnHteJe8Pap2a7Ok+3yiulZcPf1FZ5DCIB76mEeiUw6lr9GxjPrKWmE1ZDLOAg qVDTgf+HyQM2SQyZ3aEh95JukYs/THN8gcr+w3eh3NZbXgS6s62820Y1jdoLTOmH7pqf FghBwwcWAl/TNApAhkre2Z2n+pZmKNYSVlJem4oHdUeV4Ezb247S+1nxwdLuR48RHUMR 8pLw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1689333561; x=1691925561; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=nUTuhMaDrSiRcPnXk8P8ZOacIizK0ZULRB/535ud0vE=; b=KKB4WOvcaGhm+Nn9+4RtJzrSYZPvj2BP1tOiJCzDwrVFmcDktcICKo9YSrZ1V2oivo fDLRAz738JecR79/JKXbLTKvT/YuKjmrae1YhThra9OvLRGT+8v1E26XP/QZB/vAUQub FJxMJgKYdWVlMEIPB8deIsKi1j7BZOOprThpC4E7VTesZTQ02uexZSANJpjlBo53ct34 l6aquul+73xMbKW3+iBuCL/3X+9XRNI0ECN+A3D4yAiq6HjcC7X5JGfHl0HBo/bPq9k9 AQqH0YpG/AAmG0TKqDn3qkjPMhAXW2syaXEkZZ/ct12E2H9+TxiHpeFjF/1K+NVdhM1f Jtjw== X-Gm-Message-State: ABy/qLYmm8cwVWqocOJFYzVHSpxxXO8PJp22Ej2XDbg0LRqJztgCVQoF orCpxYBEGwtcl2cGRBiiO+A8jw== X-Google-Smtp-Source: APBJJlGxhNZibj2NW5DcS0sSNj5usvsOzyhoPClMGObRmr68VhlxTZlN02DT2GT6lj9dYBuJv5T0ew== X-Received: by 2002:a17:902:6b44:b0:1b8:b2a2:e47d with SMTP id g4-20020a1709026b4400b001b8b2a2e47dmr3208355plt.46.1689333561313; Fri, 14 Jul 2023 04:19:21 -0700 (PDT) Received: from fedora (61-114-134-192.ppp.bbiq.jp. [61.114.134.192]) by smtp.gmail.com with ESMTPSA id y24-20020a1709029b9800b001ac5896e96esm7499012plp.207.2023.07.14.04.19.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 14 Jul 2023 04:19:20 -0700 (PDT) Date: Fri, 14 Jul 2023 07:19:15 -0400 From: William Breathitt Gray To: Andy Shevchenko Cc: Alexander Potapenko , catalin.marinas@arm.com, will@kernel.org, pcc@google.com, andreyknvl@gmail.com, linux@rasmusvillemoes.dk, yury.norov@gmail.com, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, eugenis@google.com Subject: Re: [v2 1/5] lib/bitmap: add bitmap_{set,get}_value_unaligned() Message-ID: References: <20230713125706.2884502-1-glider@google.com> <20230713125706.2884502-2-glider@google.com> MIME-Version: 1.0 In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230714_041924_190198_E1E0E63E X-CRM114-Status: GOOD ( 25.25 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: multipart/mixed; boundary="===============5400530411703404572==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============5400530411703404572== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="QqltRdriNPO1hJJp" Content-Disposition: inline --QqltRdriNPO1hJJp Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Jul 14, 2023 at 11:04:16AM +0300, Andy Shevchenko wrote: > On Thu, Jul 13, 2023 at 08:05:34PM +0200, Alexander Potapenko wrote: > > On Thu, Jul 13, 2023 at 7:29=E2=80=AFPM Andy Shevchenko > > wrote: > > > > > > +Cc: William > > > > > > On Thu, Jul 13, 2023 at 02:57:01PM +0200, Alexander Potapenko wrote: > > > > The two new functions allow setting/getting values of length up to > > > > BITS_PER_LONG bits at arbitrary position in the bitmap. > > > > > > A couple of years (?) ago it was a series to achieve something like t= his with > > > better (?) code. Why not resurrect that one? > > > > > > https://www.mail-archive.com/linux-kernel@vger.kernel.org/msg2195426.= html > >=20 > > It looks more compact thanks to GENMASK, I can cook something based on > > the proposed bitmap_{set,get}_value (and change the names if you > > prefer the shorter ones). > > But I'd better avoid pulling in the rest of that series without a stron= g need. >=20 > William, what do you think on this? >=20 > I'm personally prefer William's version as not only it was published first > it was carefully designed and got a lot of review already. We just hadn't= had > the user for it that time. >=20 > --=20 > With Best Regards, > Andy Shevchenko Yes, that version went through several revisions so it's been well tested and known to work -- as you pointed out it just lacked the users to warrant merging it into the tree. If it statisfies the use-case required here now, then I think we should it pick it up rather than reinvent the solution again. Also, we probably don't need the "clump" code in there, so perhaps splitting it out to just the bitmap_{set,get}_value relevant code is fine. William Breathitt Gray --QqltRdriNPO1hJJp Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEARYKAB0WIQSNN83d4NIlKPjon7a1SFbKvhIjKwUCZLEvMwAKCRC1SFbKvhIj K1C/AP9Y2Gn10YIykdJfEqxpdfzFksGZcfpQYKpZC6UNgLrQQQEAzncJcIE6MfAu PxdEwp3fRjicZb83Ofwn5u4FXRebeQ8= =6ng2 -----END PGP SIGNATURE----- --QqltRdriNPO1hJJp-- --===============5400530411703404572== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============5400530411703404572==--