From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mga12.intel.com ([192.55.52.136]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qLLoe-003mqS-0z for linux-arm-kernel@lists.infradead.org; Mon, 17 Jul 2023 10:51:04 +0000 Date: Mon, 17 Jul 2023 13:50:46 +0300 From: Andy Shevchenko Subject: Re: [PATCH v2 1/1] kernel.h: Split out COUNT_ARGS() and CONCATENATE() to args.h Message-ID: References: <20230714142237.21836-1-andriy.shevchenko@linux.intel.com> <20230714115542.b5373a8dc80ba996338ee753@linux-foundation.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230714115542.b5373a8dc80ba996338ee753@linux-foundation.org> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+lwn-linux-arm-kernel=archive.lwn.net@lists.infradead.org List-Archive: To: Andrew Morton Cc: Shuah Khan , David Gow , Daniel Latypov , Bjorn Helgaas , "Steven Rostedt (Google)" , linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, kunit-dev@googlegroups.com, linux-arm-kernel@lists.infradead.org, linux-pci@vger.kernel.org, linux-trace-kernel@vger.kernel.org, Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Brendan Higgins , Mark Rutland , Lorenzo Pieralisi , Sudeep Holla , Masami Hiramatsu , Rasmus Villemoes On Fri, Jul 14, 2023 at 11:55:42AM -0700, Andrew Morton wrote: > On Fri, 14 Jul 2023 17:22:37 +0300 Andy Shevchenko wrote: > > > kernel.h is being used as a dump for all kinds of stuff for a long time. > > The COUNT_ARGS() and CONCATENATE() macros may be used in some places > > without need of the full kernel.h dependency train with it. > > > > Here is the attempt on cleaning it up by splitting out these macros(). > > > > While at it, include new header where it's being used and drop custom > > implementation of these macros and document how it works. > > This blows up my x86_64 allmodconfig build, starting with Oh, don't know how I missed to grep for that. Thank you, now I'm reproducing this on my side. I think I will split this to a few patches in v3, so we can see better if anything happens. -- With Best Regards, Andy Shevchenko _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel