From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id F2C64EB64DA for ; Wed, 19 Jul 2023 06:23:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=+3tq9PGD7uN/FJQujR0JcivARzJQqBdlIQ2qwQXBEQM=; b=ZjpMbfxw2zGBo2 9PILRKRK7pie3mPuj5thpYTtRpQTPnizig+Q1yhv+FAkCUyrJcpLmfQa4LKzcSofYuyrBicLXBuhU G8PTZUSnuoRaAAq5/yLljbfjvrLKwQ5P9Gz3WJAkoFIe+CF+SCjdAxMH5/5PnHm8vjVYAgS99+tN6 H021ObOM35ll8CMQYLmEen1rt4tiCvB12wkrDcGfWJflrUUsSzPBgLMOL1J1aUlIJP+DEKc3SyBEo yJ3Qdx7/7nji5l7tfufiRH07RKzcfbKIqKZ2jM6lW5omPJY5CuY2boM/YtMZM8wnGAjpkGq7o7qvH HOGR+h8W2lHdCi3ywc7g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qM0aM-005h6q-2r; Wed, 19 Jul 2023 06:22:54 +0000 Received: from desiato.infradead.org ([2001:8b0:10b:1:d65d:64ff:fe57:4e05]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qM0aL-005h4z-06 for linux-arm-kernel@bombadil.infradead.org; Wed, 19 Jul 2023 06:22:53 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=dB8wDR/vJst4qTLPBAP+iTEdZt+3rozuWs98fd6TxHs=; b=RfMY5+Qu8agsLD5STeQSoRrjLe sMJAE6NtqtqomI7JS9NMEo6VFCyS4vErTPiqib3SMRpqznTxhGt/ZVBeMmoBEezEIPRpJvtsCdi3g ZAIgNZUr+JJQj9OIzaPVuTM/364KwD+9iDPJaksGddtU543TqlRo+S+Kc9eLCZQCaVfanb6p3L7jH aANQf5IKaPAQnq2S+obIYXn/TwyA5P40L9hHJXCfK7pDezSo7egRFQxZPgjEtdI1fu7Ft0YKO8wkZ km/Uniz6UIUqyGqVt31DqxuG8TV5lAJixgABVqO0JoHFf5nRIHxQ4n+yvTwlOzJCtucKPMwhWfckr J/rmSV+A==; Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by desiato.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qLfWS-00BGle-1Z for linux-arm-kernel@lists.infradead.org; Tue, 18 Jul 2023 07:53:30 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 766946147A; Tue, 18 Jul 2023 07:52:18 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C1B45C433C8; Tue, 18 Jul 2023 07:52:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1689666737; bh=OBIHH19P1Xzv4nT4f72NuFolXMnRwud9KX0ascqhx6o=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=n4ucQaTnl9zSPNxYU4ZSfeUQZA3KFQTrhy3oPIlUui3lm5knFedsm0obdxqSfTKMV rxx6V9SJdIZQ0u4eRlkIpZQsev1VLhd3Flvh2LQg+alYJCHvR0ZCSEk0TGYEoEUn1L Ak6MAmhd7f2UJvgfecxdLU+0ByY54zS2xd9DVKrK2wi4Zo6QNGvUXFcp85ILLncsiA P1QhRWBuUUlcMKN/DsQepSQbOJWeE1Ocou32/3E1dxia/hu+v/dS2/+5blD2l49fAf oKXdu5IQ8F3ZZ9HhHMCWAiFq/umoH6e6NzfQoSPamAcYqwMW2JLsA+KXkS0LUy+njb tjgF40avqvLXw== Date: Tue, 18 Jul 2023 09:52:11 +0200 From: Lorenzo Pieralisi To: Guanghui Feng Cc: guohanjun@huawei.com, sudeep.holla@arm.com, rafael@kernel.org, linux-acpi@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, baolin.wang@linux.alibaba.com, alikernel-developer@linux.alibaba.com, will@kernel.org, catalin.marinas@arm.com, shameerali.kolothum.thodi@huawei.com Subject: Re: [PATCH v3] ACPI/IORT: Remove erroneous id_count check in iort_node_get_rmr_info() Message-ID: References: <1689593625-45213-1-git-send-email-guanghuifeng@linux.alibaba.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1689593625-45213-1-git-send-email-guanghuifeng@linux.alibaba.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230718_085329_236141_39DE1184 X-CRM114-Status: GOOD ( 20.94 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org [+Catalin, Will, Shameer] On Mon, Jul 17, 2023 at 07:33:45PM +0800, Guanghui Feng wrote: > According to the ARM IORT specifications DEN 0049 issue E, > the "Number of IDs" field in the ID mapping format reports > the number of IDs in the mapping range minus one. > > In iort_node_get_rmr_info(), we erroneously skip ID mappings > whose "Number of IDs" equal to 0, resulting in valid mapping > nodes with a single ID to map being skipped, which is wrong. > > Fix iort_node_get_rmr_info() by removing the bogus id_count > check. > > Fixes: 491cf4a6735a ("ACPI/IORT: Add support to retrieve IORT RMR reserved regions") > Signed-off-by: Guanghui Feng > --- > drivers/acpi/arm64/iort.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/drivers/acpi/arm64/iort.c b/drivers/acpi/arm64/iort.c > index 3631230..56d8873 100644 > --- a/drivers/acpi/arm64/iort.c > +++ b/drivers/acpi/arm64/iort.c > @@ -1007,9 +1007,6 @@ static void iort_node_get_rmr_info(struct acpi_iort_node *node, > for (i = 0; i < node->mapping_count; i++, map++) { > struct acpi_iort_node *parent; > > - if (!map->id_count) > - continue; > - > parent = ACPI_ADD_PTR(struct acpi_iort_node, iort_table, > map->output_reference); > if (parent != iommu) Shameer, I know this may look like overkill since the hunk we are removing is buggy but can you please test this patch on platforms with RMR to make sure we are not triggering regressions by removing it (by the specs that's what should be done but current firmware is always something to reckon with) ? Thanks, Lorenzo _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel