From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E2631EB64DC for ; Thu, 20 Jul 2023 06:48:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type:Cc: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=ng9jFZqxl8rlyf4CNCluZI2gxY0kjXPST54dwN/7f4Q=; b=j6SzY6okEVHhdg+iqfQIIBEG6Y lRTZl/RwrmRue9RfeV4PiwPevAzsz5elx6KSKcyL6l07tXLQam3gPQDtc9hM0Sq0fhoa8PkBFV3qM Pmjh9+AvqrCr6WUwRvucG8+0lvB/dS5RA0AqKQqbMHFpfbvcvyjpnLptrmLmvDS6Ti54MWlTsIVen WglClG5NKhgoUPowUvFIddZ1B0NrkXpCXy/lF+auyHTUWxJYcY5OwpcRoebd9kLqg6W6fsR59ACxl /8VmS7eAgi96F/M5pOcteCn8BRFGYQe87QUCARwE3jkgtJ2Vj85sCx6HOH2iZynSAmNqOpTqf0BmU LUOjvdaA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qMNSY-009zc0-0Q; Thu, 20 Jul 2023 06:48:22 +0000 Received: from mail-lj1-x22e.google.com ([2a00:1450:4864:20::22e]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qMNSV-009zZO-2D; Thu, 20 Jul 2023 06:48:21 +0000 Received: by mail-lj1-x22e.google.com with SMTP id 38308e7fff4ca-2b962535808so5865101fa.0; Wed, 19 Jul 2023 23:48:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1689835695; x=1692427695; h=user-agent:in-reply-to:content-disposition:mime-version:references :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=1FkW5AFugHIm4cfLHhBTJhPmVsKSDHP6cvkrfUVdciI=; b=AzOk4HbUt9ZK+jgh2do1VmTnHs4dXgElnWxrvk/ChEHWWQTAZ9Vx8z7XNmRbDqPxZ3 pze3ozYAKUdVg1bDR93gP5GhKEdWWBQ0Z3hpvKSTR3aWKlVmMyKb7oVA0LynQyTcgKv2 D6nSHWT0sTsM7wGrLweBRaxKnv4ScXH6R7hljPkQgdoR9wDPheqU4d3pdCm1+3XDKlWu aJeDJRsVcVA+LxTuN/Lh17Y4eVWY7TL9dsBZ5PDZgdTD3S9dyqQ48/KqD62XG+MERd3j v9OutwMGBMZU+qjEDSgxHB5ePtRice9fyfrHWxUYpDn/Ip6PxSF/NyTWH7Duq9PsJPVr i08A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1689835695; x=1692427695; h=user-agent:in-reply-to:content-disposition:mime-version:references :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=1FkW5AFugHIm4cfLHhBTJhPmVsKSDHP6cvkrfUVdciI=; b=RWDdPgUZ4P2qlLWpbWUrWB/YlVmcCRORFASXMRhExct7+mMVJDOmZGE/1Euyh+7/41 /TsrXzSjs4BQvAGtYNpz76L2MdIksp/Igs0UE0bC0FgcksqLd1kF9rJ9sYlY36VN2Sem 0nFor7jwYhjwP7/+Viue6Cqr4G0KJZcbzT5qcsoyJ62kT5T9jU4nWKbknadfL4Tl5my3 8/i72W0C++ySaTMriWI9+CTGeRfBHNRge8P/JkLclcBsLdAZhEbF+Hd5CTJJMOnlhWvS DFtMtE9r5X6OKhOIJZOAGbJr1iFFfVZbJL5L5+p1a4SgHKxblJ03MwjfX1VE37+eYTmQ rzUw== X-Gm-Message-State: ABy/qLZpnKNgXTBe9aVlkKm8BuRdgH9F73hlijqWDEvtQKq8Ckeukc/5 Wcr/3IIF/NjckKIaA9+oFmU= X-Google-Smtp-Source: APBJJlGrST9hDWvezaAooUi3+dItEEwvvxovRyenIedKgx3brcqw6G9KmcKqHf4GtKi+d6VaNG3D9g== X-Received: by 2002:a2e:9901:0:b0:2b6:df6b:84c0 with SMTP id v1-20020a2e9901000000b002b6df6b84c0mr1063490lji.25.1689835694948; Wed, 19 Jul 2023 23:48:14 -0700 (PDT) Received: from orome (p200300e41f1bd600f22f74fffe1f3a53.dip0.t-ipconnect.de. [2003:e4:1f1b:d600:f22f:74ff:fe1f:3a53]) by smtp.gmail.com with ESMTPSA id u9-20020a05600c210900b003fbcdba1a52sm3162159wml.3.2023.07.19.23.48.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 19 Jul 2023 23:48:14 -0700 (PDT) Date: Thu, 20 Jul 2023 08:48:11 +0200 From: Thierry Reding To: Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= Subject: Re: [PATCH 00/10] pwm: Constistenly name pwm_chip variables "chip" Message-ID: References: <20230714205623.2496590-1-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 In-Reply-To: <20230714205623.2496590-1-u.kleine-koenig@pengutronix.de> User-Agent: Mutt/2.2.10 (2023-03-25) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230719_234819_730012_A1496021 X-CRM114-Status: GOOD ( 27.26 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Alexandre Belloni , Heiko Stuebner , Guenter Roeck , linux-riscv@lists.infradead.org, chrome-platform@lists.linux.dev, Florian Fainelli , linux-staging@lists.linux.dev, linux-rockchip@lists.infradead.org, Broadcom internal kernel review list , linux-pwm@vger.kernel.org, Ray Jui , Johan Hovold , greybus-dev@lists.linaro.org, Paul Walmsley , Benson Leung , linux-arm-kernel@lists.infradead.org, Alex Elder , Scott Branden , Greg Kroah-Hartman , Michael Walle , Palmer Dabbelt , kernel@pengutronix.de, Claudiu Beznea Content-Type: multipart/mixed; boundary="===============4002261487285791637==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============4002261487285791637== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="qz371AQYCl6mZiXj" Content-Disposition: inline --qz371AQYCl6mZiXj Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Jul 14, 2023 at 10:56:13PM +0200, Uwe Kleine-K=C3=B6nig wrote: > while working on an extension for the pwm framework, I noticed that some > drivers and even the core only nearly consistently named all variables > and struct members holding a pointer to a struct pwm_chip "chip": >=20 > $ git grep -Pho 'struct pwm_chip \**[a-z0-9_]+(*nla:[\(a-z0-9_])' v6.5-rc= 1 | sort | uniq -c | sort -n > 1 struct pwm_chip *pwm > 1 struct pwm_chip pwm > 1 struct pwm_chip pwm_chip > 2 struct pwm_chip *_chip > 4 struct pwm_chip *c > 8 struct pwm_chip *pc > 57 struct pwm_chip chip > 358 struct pwm_chip *chip >=20 > With this series applied these are all called "chip" with one exception: > The led driver drivers/leds/rgb/leds-qcom-lpg.c uses "pwm". Maybe > "pwmchip" would be a better name, but I'm not sure that using "chip" was > an improvement there as this isn't a pure pwm driver. I'm not touching > that one. >=20 > The first offenders I found were the core and the atmel-hlcdc driver. > After I found these I optimistically assumed these were the only ones > with the unusual names and send patches for these out individually > before checking systematically. >=20 > The atmel-hlcdc patch is included here unchanged, the core patch now > also adapted the declaration of the changed functions in . > I marked these two as "superseded" in patchwork already. >=20 > All patches in this series are pairwise independent of each other. I > don't know if the staging patch should better go in via the greybus tree > or via pwm. Both is possible without needing coordination. >=20 > Best regards > Uwe >=20 >=20 > Uwe Kleine-K=C3=B6nig (10): > pwm: Use a consistent name for pwm_chip pointers in the core > pwm: atmel-hlcdc: Use consistent variable naming > pwm: bcm-kona: Consistenly name pwm_chip variables "chip" > pwm: crc: Consistenly name pwm_chip variables "chip" > pwm: cros-ec: Consistenly name pwm_chip variables "chip" > pwm: lp3943: Consistenly name pwm_chip variables "chip" > pwm: rockchip: Consistenly name pwm_chip variables "chip" > pwm: sifive: Consistenly name pwm_chip variables "chip" > pwm: sl28cpld: Consistenly name pwm_chip variables "chip" > staging: greybus: pwm: Consistenly name pwm_chip variables "chip" This would've been much easier if it had been a single patch. Now I have to either make you redo the whole series because you've misspelled PWM or I have to go and update it myself in most of the above patches. Hint: I'll do the latter. There is really no reason to split this up into this many patches for such a trivial change. Thierry --qz371AQYCl6mZiXj Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEiOrDCAFJzPfAjcif3SOs138+s6EFAmS42KkACgkQ3SOs138+ s6Hrcw//bT6JKDpq1cRgHldmJl93Sju6hsTYMrblCoA1pa6rfV9XZX1D8K1gZUOl K+6a1mUlkjv1KR7pIvUU7PG47vE66IXBNwAZYLfXYKmrCBiWjF+mT6Azm2rwPguM 02gt5Fmv0Xp0CZ3yc2N4CHhiC+MsyhkliuK/dMfejMaPSQjs3F+yMPo4FUON+CJx oy+okmnI6VYMtpAX3qDvJ7lrqgmw6CMwkxrYPaCtnzRGYLxOyixhoYy3KzgWS8BO Aukgm24XROAuq58cCp9EjxYtMWR7jmJdaqY3DVaE4XaAuklI5/s0QfTSachQbTOu Fv/+/1K4cZjTEhg+qSfSq5xIkmDqDDcHFw5Kobcv9xjXegeFLnrTl541jiMLkgcs U4zY0OGXm2OZrhqQRj4WmJd8YAkqZbLTquSQb2AtjNyITFKlgQg28Ct6gr5Go9eb Te+RAcoQkDuIs0qEJe+07qkCEngilTGdXf59kymAsdDzWqM+7qEDOMYnmWzl06KJ qQFbms1FtSzldFO+upYAYMynS4K2Ni+EY6KbocmUwvs9vYw6FC8pmyfAXvFdGD8D MXljW6kvcoycIOPlwME1H+b3EourwQhI/wnjLyYmB8Z921+NJZ9D3Bj5ey16YzEp ZGqr2I+AgbDzS0yQAM/utgHE9jOZy6KOnQGeWvXYOeUSVDlrobA= =iJ4i -----END PGP SIGNATURE----- --qz371AQYCl6mZiXj-- --===============4002261487285791637== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============4002261487285791637==--