* [PATCH 02/10] pwm: atmel-hlcdc: Use consistent variable naming
2023-07-14 20:56 [PATCH 00/10] pwm: Constistenly name pwm_chip variables "chip" Uwe Kleine-König
@ 2023-07-14 20:56 ` Uwe Kleine-König
2023-07-16 13:04 ` claudiu beznea
2023-07-20 6:53 ` Thierry Reding
2023-07-14 20:56 ` [PATCH 07/10] pwm: rockchip: Consistenly name pwm_chip variables "chip" Uwe Kleine-König
` (4 subsequent siblings)
5 siblings, 2 replies; 14+ messages in thread
From: Uwe Kleine-König @ 2023-07-14 20:56 UTC (permalink / raw)
To: Thierry Reding, Nicolas Ferre, Alexandre Belloni, Claudiu Beznea
Cc: linux-pwm, linux-arm-kernel, kernel
In pwm drivers the variable name "chip" is usually only used for struct
pwm_chip pointers. This driver however used "chip" for its driver data
and pwm_chip pointers are named "chip", too, when there is no driver
data around and "c" otherwise. Instead use "ddata" for driver data and
always "chip" for pwm_chips.
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
---
drivers/pwm/pwm-atmel-hlcdc.c | 64 +++++++++++++++++------------------
1 file changed, 32 insertions(+), 32 deletions(-)
diff --git a/drivers/pwm/pwm-atmel-hlcdc.c b/drivers/pwm/pwm-atmel-hlcdc.c
index 96a709a9d49a..9b0165d61c49 100644
--- a/drivers/pwm/pwm-atmel-hlcdc.c
+++ b/drivers/pwm/pwm-atmel-hlcdc.c
@@ -38,11 +38,11 @@ static inline struct atmel_hlcdc_pwm *to_atmel_hlcdc_pwm(struct pwm_chip *chip)
return container_of(chip, struct atmel_hlcdc_pwm, chip);
}
-static int atmel_hlcdc_pwm_apply(struct pwm_chip *c, struct pwm_device *pwm,
+static int atmel_hlcdc_pwm_apply(struct pwm_chip *chip, struct pwm_device *pwm,
const struct pwm_state *state)
{
- struct atmel_hlcdc_pwm *chip = to_atmel_hlcdc_pwm(c);
- struct atmel_hlcdc *hlcdc = chip->hlcdc;
+ struct atmel_hlcdc_pwm *ddata = to_atmel_hlcdc_pwm(chip);
+ struct atmel_hlcdc *hlcdc = ddata->hlcdc;
unsigned int status;
int ret;
@@ -54,7 +54,7 @@ static int atmel_hlcdc_pwm_apply(struct pwm_chip *c, struct pwm_device *pwm,
u32 pwmcfg;
int pres;
- if (!chip->errata || !chip->errata->slow_clk_erratum) {
+ if (!ddata->errata || !ddata->errata->slow_clk_erratum) {
clk_freq = clk_get_rate(new_clk);
if (!clk_freq)
return -EINVAL;
@@ -64,7 +64,7 @@ static int atmel_hlcdc_pwm_apply(struct pwm_chip *c, struct pwm_device *pwm,
}
/* Errata: cannot use slow clk on some IP revisions */
- if ((chip->errata && chip->errata->slow_clk_erratum) ||
+ if ((ddata->errata && ddata->errata->slow_clk_erratum) ||
clk_period_ns > state->period) {
new_clk = hlcdc->sys_clk;
clk_freq = clk_get_rate(new_clk);
@@ -77,8 +77,8 @@ static int atmel_hlcdc_pwm_apply(struct pwm_chip *c, struct pwm_device *pwm,
for (pres = 0; pres <= ATMEL_HLCDC_PWMPS_MAX; pres++) {
/* Errata: cannot divide by 1 on some IP revisions */
- if (!pres && chip->errata &&
- chip->errata->div1_clk_erratum)
+ if (!pres && ddata->errata &&
+ ddata->errata->div1_clk_erratum)
continue;
if ((clk_period_ns << pres) >= state->period)
@@ -90,7 +90,7 @@ static int atmel_hlcdc_pwm_apply(struct pwm_chip *c, struct pwm_device *pwm,
pwmcfg = ATMEL_HLCDC_PWMPS(pres);
- if (new_clk != chip->cur_clk) {
+ if (new_clk != ddata->cur_clk) {
u32 gencfg = 0;
int ret;
@@ -98,8 +98,8 @@ static int atmel_hlcdc_pwm_apply(struct pwm_chip *c, struct pwm_device *pwm,
if (ret)
return ret;
- clk_disable_unprepare(chip->cur_clk);
- chip->cur_clk = new_clk;
+ clk_disable_unprepare(ddata->cur_clk);
+ ddata->cur_clk = new_clk;
if (new_clk == hlcdc->sys_clk)
gencfg = ATMEL_HLCDC_CLKPWMSEL;
@@ -160,8 +160,8 @@ static int atmel_hlcdc_pwm_apply(struct pwm_chip *c, struct pwm_device *pwm,
if (ret)
return ret;
- clk_disable_unprepare(chip->cur_clk);
- chip->cur_clk = NULL;
+ clk_disable_unprepare(ddata->cur_clk);
+ ddata->cur_clk = NULL;
}
return 0;
@@ -183,31 +183,31 @@ static const struct atmel_hlcdc_pwm_errata atmel_hlcdc_pwm_sama5d3_errata = {
#ifdef CONFIG_PM_SLEEP
static int atmel_hlcdc_pwm_suspend(struct device *dev)
{
- struct atmel_hlcdc_pwm *chip = dev_get_drvdata(dev);
+ struct atmel_hlcdc_pwm *ddata = dev_get_drvdata(dev);
/* Keep the periph clock enabled if the PWM is still running. */
- if (pwm_is_enabled(&chip->chip.pwms[0]))
- clk_disable_unprepare(chip->hlcdc->periph_clk);
+ if (pwm_is_enabled(&ddata->chip.pwms[0]))
+ clk_disable_unprepare(ddata->hlcdc->periph_clk);
return 0;
}
static int atmel_hlcdc_pwm_resume(struct device *dev)
{
- struct atmel_hlcdc_pwm *chip = dev_get_drvdata(dev);
+ struct atmel_hlcdc_pwm *ddata = dev_get_drvdata(dev);
struct pwm_state state;
int ret;
- pwm_get_state(&chip->chip.pwms[0], &state);
+ pwm_get_state(&ddata->chip.pwms[0], &state);
/* Re-enable the periph clock it was stopped during suspend. */
if (!state.enabled) {
- ret = clk_prepare_enable(chip->hlcdc->periph_clk);
+ ret = clk_prepare_enable(ddata->hlcdc->periph_clk);
if (ret)
return ret;
}
- return atmel_hlcdc_pwm_apply(&chip->chip, &chip->chip.pwms[0], &state);
+ return atmel_hlcdc_pwm_apply(&ddata->chip, &ddata->chip.pwms[0], &state);
}
#endif
@@ -244,14 +244,14 @@ static int atmel_hlcdc_pwm_probe(struct platform_device *pdev)
{
const struct of_device_id *match;
struct device *dev = &pdev->dev;
- struct atmel_hlcdc_pwm *chip;
+ struct atmel_hlcdc_pwm *ddata;
struct atmel_hlcdc *hlcdc;
int ret;
hlcdc = dev_get_drvdata(dev->parent);
- chip = devm_kzalloc(dev, sizeof(*chip), GFP_KERNEL);
- if (!chip)
+ ddata = devm_kzalloc(dev, sizeof(*ddata), GFP_KERNEL);
+ if (!ddata)
return -ENOMEM;
ret = clk_prepare_enable(hlcdc->periph_clk);
@@ -260,31 +260,31 @@ static int atmel_hlcdc_pwm_probe(struct platform_device *pdev)
match = of_match_node(atmel_hlcdc_dt_ids, dev->parent->of_node);
if (match)
- chip->errata = match->data;
+ ddata->errata = match->data;
- chip->hlcdc = hlcdc;
- chip->chip.ops = &atmel_hlcdc_pwm_ops;
- chip->chip.dev = dev;
- chip->chip.npwm = 1;
+ ddata->hlcdc = hlcdc;
+ ddata->chip.ops = &atmel_hlcdc_pwm_ops;
+ ddata->chip.dev = dev;
+ ddata->chip.npwm = 1;
- ret = pwmchip_add(&chip->chip);
+ ret = pwmchip_add(&ddata->chip);
if (ret) {
clk_disable_unprepare(hlcdc->periph_clk);
return ret;
}
- platform_set_drvdata(pdev, chip);
+ platform_set_drvdata(pdev, ddata);
return 0;
}
static void atmel_hlcdc_pwm_remove(struct platform_device *pdev)
{
- struct atmel_hlcdc_pwm *chip = platform_get_drvdata(pdev);
+ struct atmel_hlcdc_pwm *ddata = platform_get_drvdata(pdev);
- pwmchip_remove(&chip->chip);
+ pwmchip_remove(&ddata->chip);
- clk_disable_unprepare(chip->hlcdc->periph_clk);
+ clk_disable_unprepare(ddata->hlcdc->periph_clk);
}
static const struct of_device_id atmel_hlcdc_pwm_dt_ids[] = {
--
2.39.2
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 14+ messages in thread* Re: [PATCH 02/10] pwm: atmel-hlcdc: Use consistent variable naming
2023-07-14 20:56 ` [PATCH 02/10] pwm: atmel-hlcdc: Use consistent variable naming Uwe Kleine-König
@ 2023-07-16 13:04 ` claudiu beznea
2023-07-20 6:53 ` Thierry Reding
1 sibling, 0 replies; 14+ messages in thread
From: claudiu beznea @ 2023-07-16 13:04 UTC (permalink / raw)
To: Uwe Kleine-König, Thierry Reding, Nicolas Ferre,
Alexandre Belloni, Claudiu Beznea
Cc: linux-pwm, linux-arm-kernel, kernel
On 14.07.2023 23:56, Uwe Kleine-König wrote:
> In pwm drivers the variable name "chip" is usually only used for struct
> pwm_chip pointers. This driver however used "chip" for its driver data
> and pwm_chip pointers are named "chip", too, when there is no driver
> data around and "c" otherwise. Instead use "ddata" for driver data and
> always "chip" for pwm_chips.
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Reviewed-by: Claudiu Beznea <claudiu.beznea@tuxon.dev>
> ---
> drivers/pwm/pwm-atmel-hlcdc.c | 64 +++++++++++++++++------------------
> 1 file changed, 32 insertions(+), 32 deletions(-)
>
> diff --git a/drivers/pwm/pwm-atmel-hlcdc.c b/drivers/pwm/pwm-atmel-hlcdc.c
> index 96a709a9d49a..9b0165d61c49 100644
> --- a/drivers/pwm/pwm-atmel-hlcdc.c
> +++ b/drivers/pwm/pwm-atmel-hlcdc.c
> @@ -38,11 +38,11 @@ static inline struct atmel_hlcdc_pwm *to_atmel_hlcdc_pwm(struct pwm_chip *chip)
> return container_of(chip, struct atmel_hlcdc_pwm, chip);
> }
>
> -static int atmel_hlcdc_pwm_apply(struct pwm_chip *c, struct pwm_device *pwm,
> +static int atmel_hlcdc_pwm_apply(struct pwm_chip *chip, struct pwm_device *pwm,
> const struct pwm_state *state)
> {
> - struct atmel_hlcdc_pwm *chip = to_atmel_hlcdc_pwm(c);
> - struct atmel_hlcdc *hlcdc = chip->hlcdc;
> + struct atmel_hlcdc_pwm *ddata = to_atmel_hlcdc_pwm(chip);
> + struct atmel_hlcdc *hlcdc = ddata->hlcdc;
> unsigned int status;
> int ret;
>
> @@ -54,7 +54,7 @@ static int atmel_hlcdc_pwm_apply(struct pwm_chip *c, struct pwm_device *pwm,
> u32 pwmcfg;
> int pres;
>
> - if (!chip->errata || !chip->errata->slow_clk_erratum) {
> + if (!ddata->errata || !ddata->errata->slow_clk_erratum) {
> clk_freq = clk_get_rate(new_clk);
> if (!clk_freq)
> return -EINVAL;
> @@ -64,7 +64,7 @@ static int atmel_hlcdc_pwm_apply(struct pwm_chip *c, struct pwm_device *pwm,
> }
>
> /* Errata: cannot use slow clk on some IP revisions */
> - if ((chip->errata && chip->errata->slow_clk_erratum) ||
> + if ((ddata->errata && ddata->errata->slow_clk_erratum) ||
> clk_period_ns > state->period) {
> new_clk = hlcdc->sys_clk;
> clk_freq = clk_get_rate(new_clk);
> @@ -77,8 +77,8 @@ static int atmel_hlcdc_pwm_apply(struct pwm_chip *c, struct pwm_device *pwm,
>
> for (pres = 0; pres <= ATMEL_HLCDC_PWMPS_MAX; pres++) {
> /* Errata: cannot divide by 1 on some IP revisions */
> - if (!pres && chip->errata &&
> - chip->errata->div1_clk_erratum)
> + if (!pres && ddata->errata &&
> + ddata->errata->div1_clk_erratum)
> continue;
>
> if ((clk_period_ns << pres) >= state->period)
> @@ -90,7 +90,7 @@ static int atmel_hlcdc_pwm_apply(struct pwm_chip *c, struct pwm_device *pwm,
>
> pwmcfg = ATMEL_HLCDC_PWMPS(pres);
>
> - if (new_clk != chip->cur_clk) {
> + if (new_clk != ddata->cur_clk) {
> u32 gencfg = 0;
> int ret;
>
> @@ -98,8 +98,8 @@ static int atmel_hlcdc_pwm_apply(struct pwm_chip *c, struct pwm_device *pwm,
> if (ret)
> return ret;
>
> - clk_disable_unprepare(chip->cur_clk);
> - chip->cur_clk = new_clk;
> + clk_disable_unprepare(ddata->cur_clk);
> + ddata->cur_clk = new_clk;
>
> if (new_clk == hlcdc->sys_clk)
> gencfg = ATMEL_HLCDC_CLKPWMSEL;
> @@ -160,8 +160,8 @@ static int atmel_hlcdc_pwm_apply(struct pwm_chip *c, struct pwm_device *pwm,
> if (ret)
> return ret;
>
> - clk_disable_unprepare(chip->cur_clk);
> - chip->cur_clk = NULL;
> + clk_disable_unprepare(ddata->cur_clk);
> + ddata->cur_clk = NULL;
> }
>
> return 0;
> @@ -183,31 +183,31 @@ static const struct atmel_hlcdc_pwm_errata atmel_hlcdc_pwm_sama5d3_errata = {
> #ifdef CONFIG_PM_SLEEP
> static int atmel_hlcdc_pwm_suspend(struct device *dev)
> {
> - struct atmel_hlcdc_pwm *chip = dev_get_drvdata(dev);
> + struct atmel_hlcdc_pwm *ddata = dev_get_drvdata(dev);
>
> /* Keep the periph clock enabled if the PWM is still running. */
> - if (pwm_is_enabled(&chip->chip.pwms[0]))
> - clk_disable_unprepare(chip->hlcdc->periph_clk);
> + if (pwm_is_enabled(&ddata->chip.pwms[0]))
> + clk_disable_unprepare(ddata->hlcdc->periph_clk);
>
> return 0;
> }
>
> static int atmel_hlcdc_pwm_resume(struct device *dev)
> {
> - struct atmel_hlcdc_pwm *chip = dev_get_drvdata(dev);
> + struct atmel_hlcdc_pwm *ddata = dev_get_drvdata(dev);
> struct pwm_state state;
> int ret;
>
> - pwm_get_state(&chip->chip.pwms[0], &state);
> + pwm_get_state(&ddata->chip.pwms[0], &state);
>
> /* Re-enable the periph clock it was stopped during suspend. */
> if (!state.enabled) {
> - ret = clk_prepare_enable(chip->hlcdc->periph_clk);
> + ret = clk_prepare_enable(ddata->hlcdc->periph_clk);
> if (ret)
> return ret;
> }
>
> - return atmel_hlcdc_pwm_apply(&chip->chip, &chip->chip.pwms[0], &state);
> + return atmel_hlcdc_pwm_apply(&ddata->chip, &ddata->chip.pwms[0], &state);
> }
> #endif
>
> @@ -244,14 +244,14 @@ static int atmel_hlcdc_pwm_probe(struct platform_device *pdev)
> {
> const struct of_device_id *match;
> struct device *dev = &pdev->dev;
> - struct atmel_hlcdc_pwm *chip;
> + struct atmel_hlcdc_pwm *ddata;
> struct atmel_hlcdc *hlcdc;
> int ret;
>
> hlcdc = dev_get_drvdata(dev->parent);
>
> - chip = devm_kzalloc(dev, sizeof(*chip), GFP_KERNEL);
> - if (!chip)
> + ddata = devm_kzalloc(dev, sizeof(*ddata), GFP_KERNEL);
> + if (!ddata)
> return -ENOMEM;
>
> ret = clk_prepare_enable(hlcdc->periph_clk);
> @@ -260,31 +260,31 @@ static int atmel_hlcdc_pwm_probe(struct platform_device *pdev)
>
> match = of_match_node(atmel_hlcdc_dt_ids, dev->parent->of_node);
> if (match)
> - chip->errata = match->data;
> + ddata->errata = match->data;
>
> - chip->hlcdc = hlcdc;
> - chip->chip.ops = &atmel_hlcdc_pwm_ops;
> - chip->chip.dev = dev;
> - chip->chip.npwm = 1;
> + ddata->hlcdc = hlcdc;
> + ddata->chip.ops = &atmel_hlcdc_pwm_ops;
> + ddata->chip.dev = dev;
> + ddata->chip.npwm = 1;
>
> - ret = pwmchip_add(&chip->chip);
> + ret = pwmchip_add(&ddata->chip);
> if (ret) {
> clk_disable_unprepare(hlcdc->periph_clk);
> return ret;
> }
>
> - platform_set_drvdata(pdev, chip);
> + platform_set_drvdata(pdev, ddata);
>
> return 0;
> }
>
> static void atmel_hlcdc_pwm_remove(struct platform_device *pdev)
> {
> - struct atmel_hlcdc_pwm *chip = platform_get_drvdata(pdev);
> + struct atmel_hlcdc_pwm *ddata = platform_get_drvdata(pdev);
>
> - pwmchip_remove(&chip->chip);
> + pwmchip_remove(&ddata->chip);
>
> - clk_disable_unprepare(chip->hlcdc->periph_clk);
> + clk_disable_unprepare(ddata->hlcdc->periph_clk);
> }
>
> static const struct of_device_id atmel_hlcdc_pwm_dt_ids[] = {
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 14+ messages in thread* Re: [PATCH 02/10] pwm: atmel-hlcdc: Use consistent variable naming
2023-07-14 20:56 ` [PATCH 02/10] pwm: atmel-hlcdc: Use consistent variable naming Uwe Kleine-König
2023-07-16 13:04 ` claudiu beznea
@ 2023-07-20 6:53 ` Thierry Reding
2023-07-20 7:29 ` Uwe Kleine-König
1 sibling, 1 reply; 14+ messages in thread
From: Thierry Reding @ 2023-07-20 6:53 UTC (permalink / raw)
To: Uwe Kleine-König
Cc: linux-pwm, Alexandre Belloni, kernel, Claudiu Beznea,
linux-arm-kernel
[-- Attachment #1.1: Type: text/plain, Size: 1482 bytes --]
On Fri, Jul 14, 2023 at 10:56:15PM +0200, Uwe Kleine-König wrote:
> In pwm drivers the variable name "chip" is usually only used for struct
> pwm_chip pointers. This driver however used "chip" for its driver data
> and pwm_chip pointers are named "chip", too, when there is no driver
> data around and "c" otherwise. Instead use "ddata" for driver data and
> always "chip" for pwm_chips.
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> ---
> drivers/pwm/pwm-atmel-hlcdc.c | 64 +++++++++++++++++------------------
> 1 file changed, 32 insertions(+), 32 deletions(-)
>
> diff --git a/drivers/pwm/pwm-atmel-hlcdc.c b/drivers/pwm/pwm-atmel-hlcdc.c
> index 96a709a9d49a..9b0165d61c49 100644
> --- a/drivers/pwm/pwm-atmel-hlcdc.c
> +++ b/drivers/pwm/pwm-atmel-hlcdc.c
> @@ -38,11 +38,11 @@ static inline struct atmel_hlcdc_pwm *to_atmel_hlcdc_pwm(struct pwm_chip *chip)
> return container_of(chip, struct atmel_hlcdc_pwm, chip);
> }
>
> -static int atmel_hlcdc_pwm_apply(struct pwm_chip *c, struct pwm_device *pwm,
> +static int atmel_hlcdc_pwm_apply(struct pwm_chip *chip, struct pwm_device *pwm,
> const struct pwm_state *state)
> {
> - struct atmel_hlcdc_pwm *chip = to_atmel_hlcdc_pwm(c);
> - struct atmel_hlcdc *hlcdc = chip->hlcdc;
> + struct atmel_hlcdc_pwm *ddata = to_atmel_hlcdc_pwm(chip);
Can we not just use something like "data", "priv" or "atmel"? "ddata" is
horrific and looks like a typo.
Thierry
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
[-- Attachment #2: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 14+ messages in thread* Re: [PATCH 02/10] pwm: atmel-hlcdc: Use consistent variable naming
2023-07-20 6:53 ` Thierry Reding
@ 2023-07-20 7:29 ` Uwe Kleine-König
2023-07-21 17:58 ` Uwe Kleine-König
0 siblings, 1 reply; 14+ messages in thread
From: Uwe Kleine-König @ 2023-07-20 7:29 UTC (permalink / raw)
To: Thierry Reding
Cc: linux-pwm, Alexandre Belloni, kernel, Claudiu Beznea,
linux-arm-kernel
[-- Attachment #1.1: Type: text/plain, Size: 2083 bytes --]
On Thu, Jul 20, 2023 at 08:53:50AM +0200, Thierry Reding wrote:
> On Fri, Jul 14, 2023 at 10:56:15PM +0200, Uwe Kleine-König wrote:
> > In pwm drivers the variable name "chip" is usually only used for struct
> > pwm_chip pointers. This driver however used "chip" for its driver data
> > and pwm_chip pointers are named "chip", too, when there is no driver
> > data around and "c" otherwise. Instead use "ddata" for driver data and
> > always "chip" for pwm_chips.
> >
> > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> > ---
> > drivers/pwm/pwm-atmel-hlcdc.c | 64 +++++++++++++++++------------------
> > 1 file changed, 32 insertions(+), 32 deletions(-)
> >
> > diff --git a/drivers/pwm/pwm-atmel-hlcdc.c b/drivers/pwm/pwm-atmel-hlcdc.c
> > index 96a709a9d49a..9b0165d61c49 100644
> > --- a/drivers/pwm/pwm-atmel-hlcdc.c
> > +++ b/drivers/pwm/pwm-atmel-hlcdc.c
> > @@ -38,11 +38,11 @@ static inline struct atmel_hlcdc_pwm *to_atmel_hlcdc_pwm(struct pwm_chip *chip)
> > return container_of(chip, struct atmel_hlcdc_pwm, chip);
> > }
> >
> > -static int atmel_hlcdc_pwm_apply(struct pwm_chip *c, struct pwm_device *pwm,
> > +static int atmel_hlcdc_pwm_apply(struct pwm_chip *chip, struct pwm_device *pwm,
> > const struct pwm_state *state)
> > {
> > - struct atmel_hlcdc_pwm *chip = to_atmel_hlcdc_pwm(c);
> > - struct atmel_hlcdc *hlcdc = chip->hlcdc;
> > + struct atmel_hlcdc_pwm *ddata = to_atmel_hlcdc_pwm(chip);
>
> Can we not just use something like "data", "priv" or "atmel"? "ddata" is
> horrific and looks like a typo.
I like "ddata" which isn't so uncommon (pwm-atmel-hlcdc and pwm-sifive
use it and git grep '\<ddata\>' suggests it's common in other parts of
the kernel, too.)
It's the same naming scheme as "pdata". If you feel strong here, do you
like "drvdata" better? Among your suggestions my favourite is "priv".
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | https://www.pengutronix.de/ |
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
[-- Attachment #2: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 14+ messages in thread* Re: [PATCH 02/10] pwm: atmel-hlcdc: Use consistent variable naming
2023-07-20 7:29 ` Uwe Kleine-König
@ 2023-07-21 17:58 ` Uwe Kleine-König
2023-07-21 18:26 ` Thierry Reding
0 siblings, 1 reply; 14+ messages in thread
From: Uwe Kleine-König @ 2023-07-21 17:58 UTC (permalink / raw)
To: Thierry Reding
Cc: linux-pwm, Alexandre Belloni, kernel, Claudiu Beznea,
linux-arm-kernel
[-- Attachment #1.1: Type: text/plain, Size: 1412 bytes --]
Hello Thierry,
On Thu, Jul 20, 2023 at 09:29:58AM +0200, Uwe Kleine-König wrote:
> On Thu, Jul 20, 2023 at 08:53:50AM +0200, Thierry Reding wrote:
> > On Fri, Jul 14, 2023 at 10:56:15PM +0200, Uwe Kleine-König wrote:
> > > [...]
> > > - struct atmel_hlcdc_pwm *chip = to_atmel_hlcdc_pwm(c);
> > > - struct atmel_hlcdc *hlcdc = chip->hlcdc;
> > > + struct atmel_hlcdc_pwm *ddata = to_atmel_hlcdc_pwm(chip);
> >
> > Can we not just use something like "data", "priv" or "atmel"? "ddata" is
> > horrific and looks like a typo.
>
> I like "ddata" which isn't so uncommon (pwm-atmel-hlcdc and pwm-sifive
> use it
I have to correct this. pwm-atmel-hlcdc only used it after this patch of
course. But there is pwm-sti which uses it and the two stm32 drivers use
if for driver data of the pwm's parent device.
> and git grep '\<ddata\>' suggests it's common in other parts of
> the kernel, too.)
> It's the same naming scheme as "pdata". If you feel strong here, do you
> like "drvdata" better? Among your suggestions my favourite is "priv".
I noticed you applied my patch and replaced "ddata" by "atmel" without
mentioning that in the commit log or this thread.
After my reply above, that's pretty steep.
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | https://www.pengutronix.de/ |
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
[-- Attachment #2: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH 02/10] pwm: atmel-hlcdc: Use consistent variable naming
2023-07-21 17:58 ` Uwe Kleine-König
@ 2023-07-21 18:26 ` Thierry Reding
0 siblings, 0 replies; 14+ messages in thread
From: Thierry Reding @ 2023-07-21 18:26 UTC (permalink / raw)
To: Uwe Kleine-König
Cc: linux-pwm, Alexandre Belloni, kernel, Claudiu Beznea,
linux-arm-kernel
[-- Attachment #1.1: Type: text/plain, Size: 1446 bytes --]
On Fri, Jul 21, 2023 at 07:58:04PM +0200, Uwe Kleine-König wrote:
> Hello Thierry,
>
> On Thu, Jul 20, 2023 at 09:29:58AM +0200, Uwe Kleine-König wrote:
> > On Thu, Jul 20, 2023 at 08:53:50AM +0200, Thierry Reding wrote:
> > > On Fri, Jul 14, 2023 at 10:56:15PM +0200, Uwe Kleine-König wrote:
> > > > [...]
> > > > - struct atmel_hlcdc_pwm *chip = to_atmel_hlcdc_pwm(c);
> > > > - struct atmel_hlcdc *hlcdc = chip->hlcdc;
> > > > + struct atmel_hlcdc_pwm *ddata = to_atmel_hlcdc_pwm(chip);
> > >
> > > Can we not just use something like "data", "priv" or "atmel"? "ddata" is
> > > horrific and looks like a typo.
> >
> > I like "ddata" which isn't so uncommon (pwm-atmel-hlcdc and pwm-sifive
> > use it
>
> I have to correct this. pwm-atmel-hlcdc only used it after this patch of
> course. But there is pwm-sti which uses it and the two stm32 drivers use
> if for driver data of the pwm's parent device.
>
> > and git grep '\<ddata\>' suggests it's common in other parts of
> > the kernel, too.)
> > It's the same naming scheme as "pdata". If you feel strong here, do you
> > like "drvdata" better? Among your suggestions my favourite is "priv".
>
> I noticed you applied my patch and replaced "ddata" by "atmel" without
> mentioning that in the commit log or this thread.
>
> After my reply above, that's pretty steep.
I didn't think you'd care. I've added a note to the commit message now.
Thierry
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
[-- Attachment #2: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 14+ messages in thread
* [PATCH 07/10] pwm: rockchip: Consistenly name pwm_chip variables "chip"
2023-07-14 20:56 [PATCH 00/10] pwm: Constistenly name pwm_chip variables "chip" Uwe Kleine-König
2023-07-14 20:56 ` [PATCH 02/10] pwm: atmel-hlcdc: Use consistent variable naming Uwe Kleine-König
@ 2023-07-14 20:56 ` Uwe Kleine-König
2023-07-20 6:48 ` [PATCH 00/10] pwm: Constistenly " Thierry Reding
` (3 subsequent siblings)
5 siblings, 0 replies; 14+ messages in thread
From: Uwe Kleine-König @ 2023-07-14 20:56 UTC (permalink / raw)
To: Thierry Reding, Heiko Stuebner
Cc: linux-pwm, linux-arm-kernel, linux-rockchip, kernel
Most variables holding a pointer to a pwm_chip are called "chip" which
is also the usual name in most other pwm drivers. Rename the single
variable that have a different name to be called "chip", too, for
consistency.
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
---
drivers/pwm/pwm-rockchip.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/pwm/pwm-rockchip.c b/drivers/pwm/pwm-rockchip.c
index c1a1f2d864b5..03ee18fb82d5 100644
--- a/drivers/pwm/pwm-rockchip.c
+++ b/drivers/pwm/pwm-rockchip.c
@@ -52,9 +52,9 @@ struct rockchip_pwm_data {
u32 enable_conf;
};
-static inline struct rockchip_pwm_chip *to_rockchip_pwm_chip(struct pwm_chip *c)
+static inline struct rockchip_pwm_chip *to_rockchip_pwm_chip(struct pwm_chip *chip)
{
- return container_of(c, struct rockchip_pwm_chip, chip);
+ return container_of(chip, struct rockchip_pwm_chip, chip);
}
static int rockchip_pwm_get_state(struct pwm_chip *chip,
--
2.39.2
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 14+ messages in thread* Re: [PATCH 00/10] pwm: Constistenly name pwm_chip variables "chip"
2023-07-14 20:56 [PATCH 00/10] pwm: Constistenly name pwm_chip variables "chip" Uwe Kleine-König
2023-07-14 20:56 ` [PATCH 02/10] pwm: atmel-hlcdc: Use consistent variable naming Uwe Kleine-König
2023-07-14 20:56 ` [PATCH 07/10] pwm: rockchip: Consistenly name pwm_chip variables "chip" Uwe Kleine-König
@ 2023-07-20 6:48 ` Thierry Reding
2023-07-20 7:10 ` Uwe Kleine-König
2023-07-20 14:41 ` Thierry Reding
` (2 subsequent siblings)
5 siblings, 1 reply; 14+ messages in thread
From: Thierry Reding @ 2023-07-20 6:48 UTC (permalink / raw)
To: Uwe Kleine-König
Cc: Alexandre Belloni, Heiko Stuebner, Guenter Roeck, linux-riscv,
chrome-platform, Florian Fainelli, linux-staging, linux-rockchip,
Broadcom internal kernel review list, linux-pwm, Ray Jui,
Johan Hovold, greybus-dev, Paul Walmsley, Benson Leung,
linux-arm-kernel, Alex Elder, Scott Branden, Greg Kroah-Hartman,
Michael Walle, Palmer Dabbelt, kernel, Claudiu Beznea
[-- Attachment #1.1: Type: text/plain, Size: 2682 bytes --]
On Fri, Jul 14, 2023 at 10:56:13PM +0200, Uwe Kleine-König wrote:
> while working on an extension for the pwm framework, I noticed that some
> drivers and even the core only nearly consistently named all variables
> and struct members holding a pointer to a struct pwm_chip "chip":
>
> $ git grep -Pho 'struct pwm_chip \**[a-z0-9_]+(*nla:[\(a-z0-9_])' v6.5-rc1 | sort | uniq -c | sort -n
> 1 struct pwm_chip *pwm
> 1 struct pwm_chip pwm
> 1 struct pwm_chip pwm_chip
> 2 struct pwm_chip *_chip
> 4 struct pwm_chip *c
> 8 struct pwm_chip *pc
> 57 struct pwm_chip chip
> 358 struct pwm_chip *chip
>
> With this series applied these are all called "chip" with one exception:
> The led driver drivers/leds/rgb/leds-qcom-lpg.c uses "pwm". Maybe
> "pwmchip" would be a better name, but I'm not sure that using "chip" was
> an improvement there as this isn't a pure pwm driver. I'm not touching
> that one.
>
> The first offenders I found were the core and the atmel-hlcdc driver.
> After I found these I optimistically assumed these were the only ones
> with the unusual names and send patches for these out individually
> before checking systematically.
>
> The atmel-hlcdc patch is included here unchanged, the core patch now
> also adapted the declaration of the changed functions in <linux/pwm.h>.
> I marked these two as "superseded" in patchwork already.
>
> All patches in this series are pairwise independent of each other. I
> don't know if the staging patch should better go in via the greybus tree
> or via pwm. Both is possible without needing coordination.
>
> Best regards
> Uwe
>
>
> Uwe Kleine-König (10):
> pwm: Use a consistent name for pwm_chip pointers in the core
> pwm: atmel-hlcdc: Use consistent variable naming
> pwm: bcm-kona: Consistenly name pwm_chip variables "chip"
> pwm: crc: Consistenly name pwm_chip variables "chip"
> pwm: cros-ec: Consistenly name pwm_chip variables "chip"
> pwm: lp3943: Consistenly name pwm_chip variables "chip"
> pwm: rockchip: Consistenly name pwm_chip variables "chip"
> pwm: sifive: Consistenly name pwm_chip variables "chip"
> pwm: sl28cpld: Consistenly name pwm_chip variables "chip"
> staging: greybus: pwm: Consistenly name pwm_chip variables "chip"
This would've been much easier if it had been a single patch. Now I have
to either make you redo the whole series because you've misspelled PWM
or I have to go and update it myself in most of the above patches. Hint:
I'll do the latter.
There is really no reason to split this up into this many patches for
such a trivial change.
Thierry
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
[-- Attachment #2: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 14+ messages in thread* Re: [PATCH 00/10] pwm: Constistenly name pwm_chip variables "chip"
2023-07-20 6:48 ` [PATCH 00/10] pwm: Constistenly " Thierry Reding
@ 2023-07-20 7:10 ` Uwe Kleine-König
2023-07-20 15:03 ` Thierry Reding
0 siblings, 1 reply; 14+ messages in thread
From: Uwe Kleine-König @ 2023-07-20 7:10 UTC (permalink / raw)
To: Thierry Reding
Cc: Alexandre Belloni, Heiko Stuebner, Guenter Roeck, linux-riscv,
chrome-platform, Florian Fainelli, linux-staging, linux-rockchip,
Broadcom internal kernel review list, linux-pwm, Ray Jui,
Johan Hovold, greybus-dev, Paul Walmsley, Benson Leung,
linux-arm-kernel, Alex Elder, Scott Branden, Greg Kroah-Hartman,
Michael Walle, Palmer Dabbelt, kernel, Claudiu Beznea
[-- Attachment #1.1: Type: text/plain, Size: 1933 bytes --]
Hello Thierry,
On Thu, Jul 20, 2023 at 08:48:11AM +0200, Thierry Reding wrote:
> On Fri, Jul 14, 2023 at 10:56:13PM +0200, Uwe Kleine-König wrote:
> > Uwe Kleine-König (10):
> > pwm: Use a consistent name for pwm_chip pointers in the core
> > pwm: atmel-hlcdc: Use consistent variable naming
> > pwm: bcm-kona: Consistenly name pwm_chip variables "chip"
> > pwm: crc: Consistenly name pwm_chip variables "chip"
> > pwm: cros-ec: Consistenly name pwm_chip variables "chip"
> > pwm: lp3943: Consistenly name pwm_chip variables "chip"
> > pwm: rockchip: Consistenly name pwm_chip variables "chip"
> > pwm: sifive: Consistenly name pwm_chip variables "chip"
> > pwm: sl28cpld: Consistenly name pwm_chip variables "chip"
> > staging: greybus: pwm: Consistenly name pwm_chip variables "chip"
>
> This would've been much easier if it had been a single patch. Now I have
> to either make you redo the whole series because you've misspelled PWM
> or I have to go and update it myself in most of the above patches. Hint:
> I'll do the latter.
I guess you want to do s/pwm driver/PWM driver/? Fine for me, thanks.
> There is really no reason to split this up into this many patches for
> such a trivial change.
Well, that's a subjective view. There are reasons to prefer several
small patches over one big one, too. A small patch can be indiviually
reviewed, so the "Reviewed-by: Alex Elder ..." tag only goes to the one
change that he actually looked at and if later a fix to the sifive
driver is to be backported to stable, the stable maintainers just pick
the sifive one instead of one big patch.
Did you skip the sl28cpld patch, or squash the fixup I sent in the reply
to Michael Walle?
Best regards and thanks,
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | https://www.pengutronix.de/ |
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
[-- Attachment #2: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH 00/10] pwm: Constistenly name pwm_chip variables "chip"
2023-07-20 7:10 ` Uwe Kleine-König
@ 2023-07-20 15:03 ` Thierry Reding
0 siblings, 0 replies; 14+ messages in thread
From: Thierry Reding @ 2023-07-20 15:03 UTC (permalink / raw)
To: Uwe Kleine-König
Cc: Alexandre Belloni, Heiko Stuebner, Guenter Roeck, linux-riscv,
chrome-platform, Florian Fainelli, linux-staging, linux-rockchip,
Broadcom internal kernel review list, linux-pwm, Ray Jui,
Johan Hovold, greybus-dev, Paul Walmsley, Benson Leung,
linux-arm-kernel, Alex Elder, Scott Branden, Greg Kroah-Hartman,
Michael Walle, Palmer Dabbelt, kernel, Claudiu Beznea
[-- Attachment #1.1: Type: text/plain, Size: 2074 bytes --]
On Thu, Jul 20, 2023 at 09:10:33AM +0200, Uwe Kleine-König wrote:
> Hello Thierry,
>
> On Thu, Jul 20, 2023 at 08:48:11AM +0200, Thierry Reding wrote:
> > On Fri, Jul 14, 2023 at 10:56:13PM +0200, Uwe Kleine-König wrote:
> > > Uwe Kleine-König (10):
> > > pwm: Use a consistent name for pwm_chip pointers in the core
> > > pwm: atmel-hlcdc: Use consistent variable naming
> > > pwm: bcm-kona: Consistenly name pwm_chip variables "chip"
> > > pwm: crc: Consistenly name pwm_chip variables "chip"
> > > pwm: cros-ec: Consistenly name pwm_chip variables "chip"
> > > pwm: lp3943: Consistenly name pwm_chip variables "chip"
> > > pwm: rockchip: Consistenly name pwm_chip variables "chip"
> > > pwm: sifive: Consistenly name pwm_chip variables "chip"
> > > pwm: sl28cpld: Consistenly name pwm_chip variables "chip"
> > > staging: greybus: pwm: Consistenly name pwm_chip variables "chip"
> >
> > This would've been much easier if it had been a single patch. Now I have
> > to either make you redo the whole series because you've misspelled PWM
> > or I have to go and update it myself in most of the above patches. Hint:
> > I'll do the latter.
>
> I guess you want to do s/pwm driver/PWM driver/? Fine for me, thanks.
>
> > There is really no reason to split this up into this many patches for
> > such a trivial change.
>
> Well, that's a subjective view. There are reasons to prefer several
> small patches over one big one, too. A small patch can be indiviually
> reviewed, so the "Reviewed-by: Alex Elder ..." tag only goes to the one
> change that he actually looked at and if later a fix to the sifive
> driver is to be backported to stable, the stable maintainers just pick
> the sifive one instead of one big patch.
Backports becoming more complicated would actually be a good reason not
to do this in the first place, but we've already discussed that enough
elsewhere.
> Did you skip the sl28cpld patch, or squash the fixup I sent in the reply
> to Michael Walle?
I squashed the fixup.
Thierry
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
[-- Attachment #2: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH 00/10] pwm: Constistenly name pwm_chip variables "chip"
2023-07-14 20:56 [PATCH 00/10] pwm: Constistenly name pwm_chip variables "chip" Uwe Kleine-König
` (2 preceding siblings ...)
2023-07-20 6:48 ` [PATCH 00/10] pwm: Constistenly " Thierry Reding
@ 2023-07-20 14:41 ` Thierry Reding
2023-09-11 4:31 ` patchwork-bot+chrome-platform
2023-09-11 4:49 ` patchwork-bot+chrome-platform
5 siblings, 0 replies; 14+ messages in thread
From: Thierry Reding @ 2023-07-20 14:41 UTC (permalink / raw)
To: Nicolas Ferre, Alexandre Belloni, Claudiu Beznea,
Florian Fainelli, Ray Jui, Scott Branden, Benson Leung,
Heiko Stuebner, Palmer Dabbelt, Paul Walmsley, Michael Walle,
Johan Hovold, Alex Elder, Greg Kroah-Hartman,
Uwe Kleine-König
Cc: linux-pwm, kernel, linux-arm-kernel,
Broadcom internal kernel review list, Guenter Roeck,
chrome-platform, linux-rockchip, linux-riscv, greybus-dev,
linux-staging
On Fri, 14 Jul 2023 22:56:13 +0200, Uwe Kleine-König wrote:
> while working on an extension for the pwm framework, I noticed that some
> drivers and even the core only nearly consistently named all variables
> and struct members holding a pointer to a struct pwm_chip "chip":
>
> $ git grep -Pho 'struct pwm_chip \**[a-z0-9_]+(*nla:[\(a-z0-9_])' v6.5-rc1 | sort | uniq -c | sort -n
> 1 struct pwm_chip *pwm
> 1 struct pwm_chip pwm
> 1 struct pwm_chip pwm_chip
> 2 struct pwm_chip *_chip
> 4 struct pwm_chip *c
> 8 struct pwm_chip *pc
> 57 struct pwm_chip chip
> 358 struct pwm_chip *chip
>
> [...]
Applied, thanks!
[01/10] pwm: Use a consistent name for pwm_chip pointers in the core
commit: b4f78ff746ec5274fffa92fa2a4dc531360b5016
[02/10] pwm: atmel-hlcdc: Use consistent variable naming
commit: 509143926e184762cdaffb6b67d3809fddd7f4d9
[03/10] pwm: bcm-kona: Consistenly name pwm_chip variables "chip"
commit: af87385c7ad278207d34ff3681fa325a240ae87c
[04/10] pwm: crc: Consistenly name pwm_chip variables "chip"
commit: fc30826d50d10d67628addfabb9367b5067efa42
[05/10] pwm: cros-ec: Consistenly name pwm_chip variables "chip"
commit: 6b5fdb2b655ac9abe6fbd2cbcb25c8837e3e8553
[06/10] pwm: lp3943: Consistenly name pwm_chip variables "chip"
commit: dd499b63618e523b47f30d99bf20f417de1187ff
[07/10] pwm: rockchip: Consistenly name pwm_chip variables "chip"
commit: 8c297d1fdb5d2b81d39ada6b435fb92a41be9f17
[08/10] pwm: sifive: Consistenly name pwm_chip variables "chip"
commit: cb69f40ea7cb139223901fcfc81e4e0a0a03673c
[09/10] pwm: sl28cpld: Consistenly name pwm_chip variables "chip"
commit: e79974c5c3ddc3e8181f582117c4368557524f20
[10/10] staging: greybus: pwm: Consistenly name pwm_chip variables "chip"
commit: efd1d1ad7f525809fcdf7538638a08274b75c99f
Best regards,
--
Thierry Reding <thierry.reding@gmail.com>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 14+ messages in thread* Re: [PATCH 00/10] pwm: Constistenly name pwm_chip variables "chip"
2023-07-14 20:56 [PATCH 00/10] pwm: Constistenly name pwm_chip variables "chip" Uwe Kleine-König
` (3 preceding siblings ...)
2023-07-20 14:41 ` Thierry Reding
@ 2023-09-11 4:31 ` patchwork-bot+chrome-platform
2023-09-11 4:49 ` patchwork-bot+chrome-platform
5 siblings, 0 replies; 14+ messages in thread
From: patchwork-bot+chrome-platform @ 2023-09-11 4:31 UTC (permalink / raw)
To: =?utf-8?q?Uwe_Kleine-K=C3=B6nig_=3Cu=2Ekleine-koenig=40pengutronix=2Ede=3E?=
Cc: alexandre.belloni, heiko, thierry.reding, groeck, linux-riscv,
chrome-platform, florian.fainelli, linux-staging, linux-rockchip,
bcm-kernel-feedback-list, linux-pwm, rjui, johan, greybus-dev,
paul.walmsley, bleung, linux-arm-kernel, elder, sbranden, gregkh,
michael, palmer, kernel, claudiu.beznea
Hello:
This patch was applied to chrome-platform/linux.git (for-kernelci)
by Thierry Reding <thierry.reding@gmail.com>:
On Fri, 14 Jul 2023 22:56:13 +0200 you wrote:
> while working on an extension for the pwm framework, I noticed that some
> drivers and even the core only nearly consistently named all variables
> and struct members holding a pointer to a struct pwm_chip "chip":
>
> $ git grep -Pho 'struct pwm_chip \**[a-z0-9_]+(*nla:[\(a-z0-9_])' v6.5-rc1 | sort | uniq -c | sort -n
> 1 struct pwm_chip *pwm
> 1 struct pwm_chip pwm
> 1 struct pwm_chip pwm_chip
> 2 struct pwm_chip *_chip
> 4 struct pwm_chip *c
> 8 struct pwm_chip *pc
> 57 struct pwm_chip chip
> 358 struct pwm_chip *chip
>
> [...]
Here is the summary with links:
- [05/10] pwm: cros-ec: Consistenly name pwm_chip variables "chip"
https://git.kernel.org/chrome-platform/c/5996cdf132da
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 14+ messages in thread* Re: [PATCH 00/10] pwm: Constistenly name pwm_chip variables "chip"
2023-07-14 20:56 [PATCH 00/10] pwm: Constistenly name pwm_chip variables "chip" Uwe Kleine-König
` (4 preceding siblings ...)
2023-09-11 4:31 ` patchwork-bot+chrome-platform
@ 2023-09-11 4:49 ` patchwork-bot+chrome-platform
5 siblings, 0 replies; 14+ messages in thread
From: patchwork-bot+chrome-platform @ 2023-09-11 4:49 UTC (permalink / raw)
To: =?utf-8?q?Uwe_Kleine-K=C3=B6nig_=3Cu=2Ekleine-koenig=40pengutronix=2Ede=3E?=
Cc: alexandre.belloni, heiko, thierry.reding, groeck, linux-riscv,
chrome-platform, florian.fainelli, linux-staging, linux-rockchip,
bcm-kernel-feedback-list, linux-pwm, rjui, johan, greybus-dev,
paul.walmsley, bleung, linux-arm-kernel, elder, sbranden, gregkh,
michael, palmer, kernel, claudiu.beznea
Hello:
This patch was applied to chrome-platform/linux.git (for-next)
by Thierry Reding <thierry.reding@gmail.com>:
On Fri, 14 Jul 2023 22:56:13 +0200 you wrote:
> while working on an extension for the pwm framework, I noticed that some
> drivers and even the core only nearly consistently named all variables
> and struct members holding a pointer to a struct pwm_chip "chip":
>
> $ git grep -Pho 'struct pwm_chip \**[a-z0-9_]+(*nla:[\(a-z0-9_])' v6.5-rc1 | sort | uniq -c | sort -n
> 1 struct pwm_chip *pwm
> 1 struct pwm_chip pwm
> 1 struct pwm_chip pwm_chip
> 2 struct pwm_chip *_chip
> 4 struct pwm_chip *c
> 8 struct pwm_chip *pc
> 57 struct pwm_chip chip
> 358 struct pwm_chip *chip
>
> [...]
Here is the summary with links:
- [05/10] pwm: cros-ec: Consistenly name pwm_chip variables "chip"
https://git.kernel.org/chrome-platform/c/5996cdf132da
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 14+ messages in thread