From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CF662C0015E for ; Fri, 21 Jul 2023 18:27:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type:Cc: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=ZbtGhyOlP4eM4AqpfulNqNXybujfqAiIexuS5jS5DGY=; b=PFK2nuyvN5h+hvMFphX7PQGV1j 7CGy++g3xCJz2ZH5g1Yhf9PtGfI16+IF3g4bdDjb+omDHKXo4kSPz6NdSxRmeHSZM7HXPM0jiz0pl GR6GjsjAOwh9PVB/ha7RLW+uQxeFXWZVdTpSaqEZvLU3oEHB8JqX2A/4N3Z9oPwfyultC8Bs8+DaJ p/XsYdHlTI0yLfa+3KAUuBZtad2UO8x7q1x+/Nu2Tb8nTDLXGgtQGuHF4daDVFD9JRJbcJS9GgMvh TVnBUYyBkgYRJdvq7SUG45OmZF8lSlsGz+lxAxLiarEx8BHdsTyGkg7JwI4O5MJh0YVUGmk4W+IUP o3UQDvtQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qMuq0-00ErC3-1A; Fri, 21 Jul 2023 18:26:48 +0000 Received: from mail-ej1-x632.google.com ([2a00:1450:4864:20::632]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qMupx-00ErB7-21 for linux-arm-kernel@lists.infradead.org; Fri, 21 Jul 2023 18:26:46 +0000 Received: by mail-ej1-x632.google.com with SMTP id a640c23a62f3a-9926623e367so361520166b.0 for ; Fri, 21 Jul 2023 11:26:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1689964004; x=1690568804; h=user-agent:in-reply-to:content-disposition:mime-version:references :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=ReDX7FtUoz89fYnF79wF/8ApI2kgr62YHjg2yUEk548=; b=qzRmV89iIswg9LdfWFov3Um5aKQSmVHo4pA3oaLupStSODm1eATJF3UHNhVEzXdiTN ugc31pymGmBbbLyOXzbASiV/9l5nEA2NPLsLL/xyhbfczLG+FQcKKjTRTF6WP2Cx9g+7 GfHzXojrujHndEXmE4+VgSv/cs028BGtmV+LyqowW7PsJnmzgtWPLwTTM3Ur8NJe+n30 W4pmHyOHmwk2tB5DYlusZL2N2oqHOp8lmWshPLHIjIfxj3p1G70qgHsUFF9jz9ZqrXf4 jfBRuXXnfEzKioU563UcpE7xGILhuWLDG3co9onplvu6Zcf3HVuK4XswkACGPwnC7AxJ AzWA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1689964004; x=1690568804; h=user-agent:in-reply-to:content-disposition:mime-version:references :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ReDX7FtUoz89fYnF79wF/8ApI2kgr62YHjg2yUEk548=; b=Ad9SdcNoPpBd5gT4quCjw97G+g/AXSg1UuI9LPl7m/U8GiWPGsJLvF54sjbhThB9P3 LCoFavELKxxhI2Kgtaf5FxSi5kaEIEbrM8c3m9fQxtxarJmAtepNrXIgZ7uUCJYkosPR LE7uMrf57Q5I636puAS1dyzKbN/Atc09OTvs/UuyKBKThtXYFCRrKS6cCltgbeBFMphw 0OK1eabu1MopyXl39FMyomtMHowC+fVZTN3AiV8olf8FPwhK0ieaOzU1+fXfQfdOpg4X LEiy/59MSZA2iGzb2I3yQZmyaSmfffW9cZBxJCdH7ix7NQplQsqjoQw4pEaPkQpwYELD AaHg== X-Gm-Message-State: ABy/qLZjBfVUzZxl7w8KovRkKnuZ1nwUqm8h/YOhTipKP0g05juIuCCQ 53tsW8b+PhSwLx2DLCWn6ps= X-Google-Smtp-Source: APBJJlE8+GozgbackK5gxeYh2aAqAl4u8zSGIxHnDyxaygrKWSWKkOcHrUg1ojHdtWDTnPvKzOIoLQ== X-Received: by 2002:a17:907:a07a:b0:99b:4fff:6bb with SMTP id ia26-20020a170907a07a00b0099b4fff06bbmr2285676ejc.4.1689964003424; Fri, 21 Jul 2023 11:26:43 -0700 (PDT) Received: from orome (p200300e41f1bd600f22f74fffe1f3a53.dip0.t-ipconnect.de. [2003:e4:1f1b:d600:f22f:74ff:fe1f:3a53]) by smtp.gmail.com with ESMTPSA id s23-20020a170906455700b00997c1d125fasm2501350ejq.170.2023.07.21.11.26.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 21 Jul 2023 11:26:42 -0700 (PDT) Date: Fri, 21 Jul 2023 20:26:41 +0200 From: Thierry Reding To: Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= Subject: Re: [PATCH 02/10] pwm: atmel-hlcdc: Use consistent variable naming Message-ID: References: <20230714205623.2496590-1-u.kleine-koenig@pengutronix.de> <20230714205623.2496590-3-u.kleine-koenig@pengutronix.de> <20230720072958.r54d23cefbrytw7r@pengutronix.de> <20230721175804.ent7umly5jjdyy4t@pengutronix.de> MIME-Version: 1.0 In-Reply-To: <20230721175804.ent7umly5jjdyy4t@pengutronix.de> User-Agent: Mutt/2.2.10 (2023-03-25) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230721_112645_663294_830A2F3B X-CRM114-Status: GOOD ( 23.55 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-pwm@vger.kernel.org, Alexandre Belloni , kernel@pengutronix.de, Claudiu Beznea , linux-arm-kernel@lists.infradead.org Content-Type: multipart/mixed; boundary="===============8625791649666436973==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============8625791649666436973== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="B512r75CW4UUl7w1" Content-Disposition: inline --B512r75CW4UUl7w1 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Jul 21, 2023 at 07:58:04PM +0200, Uwe Kleine-K=C3=B6nig wrote: > Hello Thierry, >=20 > On Thu, Jul 20, 2023 at 09:29:58AM +0200, Uwe Kleine-K=C3=B6nig wrote: > > On Thu, Jul 20, 2023 at 08:53:50AM +0200, Thierry Reding wrote: > > > On Fri, Jul 14, 2023 at 10:56:15PM +0200, Uwe Kleine-K=C3=B6nig wrote: > > > > [...] > > > > - struct atmel_hlcdc_pwm *chip =3D to_atmel_hlcdc_pwm(c); > > > > - struct atmel_hlcdc *hlcdc =3D chip->hlcdc; > > > > + struct atmel_hlcdc_pwm *ddata =3D to_atmel_hlcdc_pwm(chip); > > >=20 > > > Can we not just use something like "data", "priv" or "atmel"? "ddata"= is > > > horrific and looks like a typo. > >=20 > > I like "ddata" which isn't so uncommon (pwm-atmel-hlcdc and pwm-sifive > > use it >=20 > I have to correct this. pwm-atmel-hlcdc only used it after this patch of > course. But there is pwm-sti which uses it and the two stm32 drivers use > if for driver data of the pwm's parent device. >=20 > > and git grep '\' suggests it's common in other parts of > > the kernel, too.) > > It's the same naming scheme as "pdata". If you feel strong here, do you > > like "drvdata" better? Among your suggestions my favourite is "priv". >=20 > I noticed you applied my patch and replaced "ddata" by "atmel" without > mentioning that in the commit log or this thread. >=20 > After my reply above, that's pretty steep. I didn't think you'd care. I've added a note to the commit message now. Thierry --B512r75CW4UUl7w1 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEiOrDCAFJzPfAjcif3SOs138+s6EFAmS6zeEACgkQ3SOs138+ s6GV1RAAnvts+a5kp9ZetD4IPptTmeltVQ9gz6QZq33ZL+KsZiAe3fGuLYB0oUoU 1fy1k8z3+WuMZnbT884KReEkM3J37p4bnZFTCNSEsUVgQ+KpYun7FLemefiUpUVM eh0PFZLXHGeHMJTeB/5Oi4ZkoD5BXpb6K+XWViaw8B4hiYmEY4D4gu4Ugm5q/8SZ NLnFLqXf3f7D0CF/08O/DhucZEJmQ2Qs62BX1ydDajtm8E8V503F0EXIUEvCwXkW PVgUECzCu2BsivMWIVPe7aznha3ypQQ/ia+JS5VHmrhWf4/FtcK0PaimhZ1YKmf3 BuTkYVPrmgJhssn2uSqOhN7tEDcCadg7p4ktDHgayJFVKGDVj77l92WUuGFuvFtO YeApNQZxNjEoBQu3oDgQ1whUYbf+HDDeCwRc82o+QqmzU/ivcoLpm6CcGIbs5U9S 2sUp7dF1wONvwFDND3f7MUe/VcHFtwUTSBeSA2xv4hBwAZ4axkxaYEvlpPQcT1BS YLdZPdmZyfeQjpMvRz0a9uRzPTjI0okdUENpzLTBfeTc8u/c3xOUHgN7QYVeXdhq EUKm+bHr2IfL6w8kisKKHUn0tcE/YokmKQ1ApqG/cFejCbxjbcmr+ABdUHfwhYki TmFGudT3uZLcyE00pAt/o2ENBGxaSY4eQU6IkGHedzbZLbj7amc= =IRDb -----END PGP SIGNATURE----- --B512r75CW4UUl7w1-- --===============8625791649666436973== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============8625791649666436973==--