From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 62356EB64DC for ; Sat, 22 Jul 2023 12:44:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=nEQvi8l2EQuyiUQ9X435mF6HjNAEJ/FEWgn0OSLip/4=; b=vfegnBRjpy5BJw x71fAx6oMmcFyLaePQKdh9q50008BPYIUztlSM8dnn4/u11x5tXKb9ySWL7EB9GD1qKsUEQOv4dX7 h0ZzvJy0v8eHYDcgBCwsGMGx/lLBsKbPGglqNxG860bMkjxn9ekKAGII7TfKjgEFuTYjAUeeAvTJz o3t0AbGLqOKCIcFctJLz6AxBM/1kv3Jk6uo7mTq1spcwGCl30+TEqv2nhCnI8GiwbU8ykBnOlSLoU kYDdevCcCsgSO2zHDoqIJyJi7snNkkD1qt4IlGz0WlgX1bPmMhOQOe8/RX63Q8RWCoskkyjrmA4+H 93XDRGOKBWEAhTB0l8Ew==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qNBxY-00GiVf-24; Sat, 22 Jul 2023 12:43:44 +0000 Received: from pidgin.makrotopia.org ([185.142.180.65]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qNBxW-00GiUC-0V; Sat, 22 Jul 2023 12:43:43 +0000 Received: from local by pidgin.makrotopia.org with esmtpsa (TLS1.3:TLS_AES_256_GCM_SHA384:256) (Exim 4.96) (envelope-from ) id 1qNBx5-0007uX-3D; Sat, 22 Jul 2023 12:43:16 +0000 Date: Sat, 22 Jul 2023 13:43:07 +0100 From: Daniel Golle To: Frank Wunderlich Cc: "Russell King (Oracle)" , Andrew Lunn , Heiner Kallweit , =?utf-8?B?QXLEsW7DpyDDnE5BTA==?= , David Woodhouse , AngeloGioacchino Del Regno , "David S. Miller" , Eric Dumazet , Felix Fietkau , Jakub Kicinski , John Crispin , linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, Lorenzo Bianconi , Mark Lee , Matthias Brugger , netdev@vger.kernel.org, Paolo Abeni , Sean Wang Subject: Re: Aw: Re: [PATCH net-next 0/4] Remove legacy phylink behaviour Message-ID: References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230722_054342_191782_A7C3CE2E X-CRM114-Status: GOOD ( 33.15 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sat, Jul 22, 2023 at 02:31:45PM +0200, Frank Wunderlich wrote: > Hi > > > Gesendet: Samstag, 22. Juli 2023 um 00:40 Uhr > > Von: "Daniel Golle" > > > > Hi Russell, > > > > On Fri, Jul 21, 2023 at 12:33:52PM +0100, Russell King (Oracle) wrote: > > > Hi, > > > > > > This series removes the - as far as I can tell - unreachable code in > > > mtk_eth_soc that relies upon legacy phylink behaviour, and then removes > > > the support in phylink for this legacy behaviour. > > > > > > Patch 1 removes the clocking configuration from mtk_eth_soc for non- > > > TRGMII, non-serdes based interface modes, and disables those interface > > > modes prior to phylink configuration. > > > > > > Patch 2 removes the mac_pcs_get_state() method from mtk_eth_soc which > > > I believe is also not used - mtk_eth_soc appears not to be used with > > > SFPs (which would use a kind of in-band mode) nor does any DT appear > > > to specify in-band mode for any non-serdes based interface mode. > > > > > > With both of those dealt with, the kernel is now free of any driver > > > relying on the phylink legacy mode. Therefore, patch 3 removes support > > > for this. > > > > > > Finally, with the advent of a new driver being submitted today that > > > makes use of state->speed in the mac_config() path, patch 4 ensures that > > > any phylink_link_state member that should not be used in mac_config is > > > either cleared or set to an invalid value. > > > > Thank you for taking care of this! > > > For the whole series: > > > > Reviewed-by: Daniel Golle > > Tested-by: Daniel Golle > > > > Tested on BPi-R2 (MT7623N), BPi-R3 (MT7986A) and BPi-R64 (MT7622A). > > All works fine as expected. > > have you changed anything? > > in my test with bpi-r2 i see boot hangs after link-up on my wan-port (still trgmii-mode configured), no access to userspace. > > [ 10.881844] mtk_soc_eth 1b100000.ethernet eth0: configuring for fixed/trgmii link mode > [ 10.891611] mtk_soc_eth 1b100000.ethernet eth0: Link is Up - 1Gbps/Full - flow control rx/tx > [ 11.005814] mt7530-mdio mdio-bus:1f wan: configuring for phy/gmii link mode > [ 11.016654] mt7530-mdio mdio-bus:1f lan3: configuring for phy/gmii link mode > [ 11.025685] mt7530-mdio mdio-bus:1f lan2: configuring for phy/gmii link mode > [ 11.035122] mt7530-mdio mdio-bus:1f lan1: configuring for phy/gmii link mode > [ 11.045370] mt7530-mdio mdio-bus:1f lan0: configuring for phy/gmii link mode > > [ 15.144255] mt7530-mdio mdio-bus:1f wan: Link is Up - 1Gbps/Full - flow control rx/tx > > removing the cable does not show link down so it looks like completely stalled...but also no panic/crash or similar. > When booting without cable it hangs too (without the up-message of course). > > > To apply the series I needed to resolve a minor conflict due to > > net: ethernet: mtk_ppe: add MTK_FOE_ENTRY_V{1,2}_SIZE macros > > being applied in the meantime. > > i used yesterdays net-next (6.5-rc2) and put series on top (also needed to do one hunk of first patch manually) and > then my defconfig,buildscript etc. maybe i miss anything? I tested in a fairly similar way. > > afair trgmii is basicly rgmii only with higher clock-setting...and if this is dropped from mac-driver but switch is still using it it cannot work, but i'm sure you know this ;) For TRGMII mode mtk_gmac0_rgmii_adjust behavior should not have changed, only speed-dependent adjustments for RGMII have been dropped. I also didn't not see such a problem when I was testing. However, I guess in my case the MAC interface mode has already been setup in hardware because I booted the board via TFTP, hence U-Boot already took care of initializing everything, so that can also be a reason why it worked fine for me. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel