From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7A754C001B0 for ; Sat, 22 Jul 2023 19:40:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=YUYC8RWiTbdPtLoV0kXJ5OFABGXL6O7Qel1L5gcAY+8=; b=PICNJfQw58zczi GTIJreUWKzriyfgud+YX9APrsr9UiNIY0X/kKpd6r6m3I3wLcdHJ1H5hX3D8pg1Nwchx2xu6SssYd XuBxBBeKSAmsvjGANC+Jfa9ph7euF7shssae09Ntt8XukEmD+BK7rByg8wdsN16C4vFsSeAqD0X5l /QcINDROhT1NYs+/lwkhz/cvXxHeNMpt+KRnJd++bGYkVE0eiDOrd5cFJ6JNPu53aEgIB70RB4weJ 4zT0U09JL6ZTetP7simFjCAiPxIVPfLsyRNf/Jx5cf1X9KKkl1VIm3x3WBdBFndLCpjMGUrFh03JZ bRh/FfqkeC+j3H1CdirA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qNISu-00HCQN-2i; Sat, 22 Jul 2023 19:40:32 +0000 Received: from pandora.armlinux.org.uk ([2001:4d48:ad52:32c8:5054:ff:fe00:142]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qNISp-00HCPq-2P; Sat, 22 Jul 2023 19:40:31 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=5WfgO1A4QY7XJyjtiaUkXDaTXaH9qvDrKYLcXr3529k=; b=M+hCrisFV5NOVTf9Gzov5Ku4Uf ZfXRcYZ//TCNkPhIYCJjcMQzl8knhB0XlURQiE4mjeVTxy/K0mRhUTJwmvB5P/l4QF+yEZUvG14wC DsLbSfrM+FbxkSa83hd3tufssSWyrOEE3GFwqBPZXRy5Dr7LkvN5SvwH2dkGcfRM8GxhUGBuJICMX KMwqgcsuVmO4S16ZSdrPWVfrcqyKEx6A9mqZzzy8Bwn4WmzJ7UhioEhWWXx66RIq9GH8C2EIEl9Dq tGTVAygjQkzANFdpBSuFMRLrokrl3sEqL9xOLogajm1sp9fdywthmcmqtvHuCGkVRuA8N7EBzBKO/ KZ14EXLg==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:60968) by pandora.armlinux.org.uk with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1qNISe-00061i-3B; Sat, 22 Jul 2023 20:40:17 +0100 Received: from linux by shell.armlinux.org.uk with local (Exim 4.94.2) (envelope-from ) id 1qNISV-0007Pt-3r; Sat, 22 Jul 2023 20:40:07 +0100 Date: Sat, 22 Jul 2023 20:40:07 +0100 From: "Russell King (Oracle)" To: Frank Wunderlich Cc: Daniel Golle , Andrew Lunn , Heiner Kallweit , =?utf-8?B?QXLEsW7DpyDDnE5BTA==?= , David Woodhouse , AngeloGioacchino Del Regno , "David S. Miller" , Eric Dumazet , Felix Fietkau , Jakub Kicinski , John Crispin , linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, Lorenzo Bianconi , Mark Lee , Matthias Brugger , netdev@vger.kernel.org, Paolo Abeni , Sean Wang Subject: Re: Re: Re: [PATCH net-next 0/4] Remove legacy phylink behaviour Message-ID: References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230722_124027_809597_8E74C8D1 X-CRM114-Status: GOOD ( 38.99 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sat, Jul 22, 2023 at 08:00:46PM +0200, Frank Wunderlich wrote: > > > Gesendet: Samstag, 22. Juli 2023 um 18:14 Uhr > > Von: "Russell King (Oracle)" > > > > On Sat, Jul 22, 2023 at 02:31:45PM +0200, Frank Wunderlich wrote: > > > Hi > > > > > > > Gesendet: Samstag, 22. Juli 2023 um 00:40 Uhr > > > > Von: "Daniel Golle" > > > > > > > > Hi Russell, > > > > > > > > On Fri, Jul 21, 2023 at 12:33:52PM +0100, Russell King (Oracle) wrote: > > > > > Hi, > > > > > > > > > > This series removes the - as far as I can tell - unreachable code in > > > > > mtk_eth_soc that relies upon legacy phylink behaviour, and then removes > > > > > the support in phylink for this legacy behaviour. > > > > > > > > > > Patch 1 removes the clocking configuration from mtk_eth_soc for non- > > > > > TRGMII, non-serdes based interface modes, and disables those interface > > > > > modes prior to phylink configuration. > > > > > > > > > > Patch 2 removes the mac_pcs_get_state() method from mtk_eth_soc which > > > > > I believe is also not used - mtk_eth_soc appears not to be used with > > > > > SFPs (which would use a kind of in-band mode) nor does any DT appear > > > > > to specify in-band mode for any non-serdes based interface mode. > > > > > > > > > > With both of those dealt with, the kernel is now free of any driver > > > > > relying on the phylink legacy mode. Therefore, patch 3 removes support > > > > > for this. > > > > > > > > > > Finally, with the advent of a new driver being submitted today that > > > > > makes use of state->speed in the mac_config() path, patch 4 ensures that > > > > > any phylink_link_state member that should not be used in mac_config is > > > > > either cleared or set to an invalid value. > > > > > > > > Thank you for taking care of this! > > > > > > > For the whole series: > > > > > > > > Reviewed-by: Daniel Golle > > > > Tested-by: Daniel Golle > > > > > > > > Tested on BPi-R2 (MT7623N), BPi-R3 (MT7986A) and BPi-R64 (MT7622A). > > > > All works fine as expected. > > > > > > have you changed anything? > > > > > > in my test with bpi-r2 i see boot hangs after link-up on my wan-port (still trgmii-mode configured), no access to userspace. > > > > > > [ 10.881844] mtk_soc_eth 1b100000.ethernet eth0: configuring for fixed/trgmii link mode > > > [ 10.891611] mtk_soc_eth 1b100000.ethernet eth0: Link is Up - 1Gbps/Full - flow control rx/tx > > > [ 11.005814] mt7530-mdio mdio-bus:1f wan: configuring for phy/gmii link mode > > > [ 11.016654] mt7530-mdio mdio-bus:1f lan3: configuring for phy/gmii link mode > > > [ 11.025685] mt7530-mdio mdio-bus:1f lan2: configuring for phy/gmii link mode > > > [ 11.035122] mt7530-mdio mdio-bus:1f lan1: configuring for phy/gmii link mode > > > [ 11.045370] mt7530-mdio mdio-bus:1f lan0: configuring for phy/gmii link mode > > > > > > [ 15.144255] mt7530-mdio mdio-bus:1f wan: Link is Up - 1Gbps/Full - flow control rx/tx > > > > > > removing the cable does not show link down so it looks like completely stalled...but also no panic/crash or similar. > > > When booting without cable it hangs too (without the up-message of course). > > > > > > > To apply the series I needed to resolve a minor conflict due to > > > > net: ethernet: mtk_ppe: add MTK_FOE_ENTRY_V{1,2}_SIZE macros > > > > being applied in the meantime. > > > > > > i used yesterdays net-next (6.5-rc2) and put series on top (also needed to do one hunk of first patch manually) and > > > then my defconfig,buildscript etc. maybe i miss anything? > > > > > > afair trgmii is basicly rgmii only with higher clock-setting...and if this is dropped from mac-driver but switch is still using it it cannot work, but i'm sure you know this ;) > > > > Have you tried bisecting the four patches? Does that give any hints? > > Does the net-next base you used boot successfully? > > sorry, hang was caused by me (missing rootfs and wait in bootargs). > > only see throughput of only ~850Mbit (tx) and 900Mbit (rx)..wan is on eth0 which is the trgmii one, but without the patches it is similar (quicktested 6.3-rc1 i had already on this card which has similar results) > > so for me it looks good so far...i'm not sure we had more than 900 anytime on this device... So I take it that nothing broke as a result of the patches, and as you've tested them, I can add your tested-by to the patches? Thanks. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last! _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel