From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 619E7C001DF for ; Fri, 4 Aug 2023 16:53:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=y75lTQwvDActO34EKMIeEUg2QkdkT5roCOjhbL9Ji74=; b=Tp2FHZ1sLCVGo1 fvrWJ5bMGc4RIjJHYHtlKloi1+hSoL/R77eaC8pOdLpUrjMRexBSxDGhPytPAMcTNSZmWR/et32WC WhG9xEQJuv/SXjf33ImtA+AEWL/iWfJwkknKCQF7R+bpRKQa7lGyZcmpORtubNWRn9IX4tKwRh1qu Gc+ZeThE4XFZw+BVG69G5fwUFVJIJT6AzEvhvdzY0gtHSQh79U4hB8Zc0D0g82bUkJmn+7WSJj9Yb OiV0W70QLymKF5kiVDV0848PJcHGAO+4NOhtqzfGF28oBWAiboFiwkScjy+lDI7v/ZXrOVwl8agQX DH/pNQj2b+64sKE5/8Kw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qRy3F-00Cpkw-1C; Fri, 04 Aug 2023 16:53:21 +0000 Received: from mgamail.intel.com ([192.55.52.151]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qRy3C-00Cpjx-2w; Fri, 04 Aug 2023 16:53:20 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1691167998; x=1722703998; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=vCjr5AC8CWlmvMGX3Rq5ZB+kAEuf7h0FzPi+ZFzcRHo=; b=jf8AfX0MVDwF73o02BvWkRyqtRNkgcqK8vhX1X/RL/3docGurJN24RbD VEVnhZ7BryzpStQzfDbrR3Ww52SaZa1k81dC26U91jD0IOr4579G5uU8l bpoZ/QrWZx8ZWBeFTXqGjcnP8yGtWQwscDk/T16kYA97oUjS4ufLJzn5J 0qxu4eExZYBrdy7p7OJ/9IxYfRyiDXm0inRgaKyvQNV400jphZS89DVAu SpCuVlA5HXKxXtsn1um3wx8Wr6Q42+nNM1A5l0g4Dv/1YYXrC8cL9Jae1 zXRamJDN8Qb66dCJxRPRIbOGZeY2+bhe6Kl5veLf6TCARReGkdxeer9vt g==; X-IronPort-AV: E=McAfee;i="6600,9927,10792"; a="350506970" X-IronPort-AV: E=Sophos;i="6.01,255,1684825200"; d="scan'208";a="350506970" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Aug 2023 09:53:06 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10792"; a="903945496" X-IronPort-AV: E=Sophos;i="6.01,255,1684825200"; d="scan'208";a="903945496" Received: from smile.fi.intel.com ([10.237.72.54]) by orsmga005.jf.intel.com with ESMTP; 04 Aug 2023 09:52:59 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.96) (envelope-from ) id 1qRy2q-00H7d3-0x; Fri, 04 Aug 2023 19:52:56 +0300 Date: Fri, 4 Aug 2023 19:52:56 +0300 From: Andy Shevchenko To: Conor Dooley Cc: Sunil V L , linux-doc@vger.kernel.org, linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-acpi@vger.kernel.org, linux-pci@vger.kernel.org, Jonathan Corbet , Paul Walmsley , Palmer Dabbelt , Albert Ou , Catalin Marinas , Will Deacon , "Rafael J . Wysocki" , Len Brown , Daniel Scally , Heikki Krogerus , Sakari Ailus , Greg Kroah-Hartman , Daniel Lezcano , Thomas Gleixner , Anup Patel , Marc Zyngier , Bjorn Helgaas , Robert Moore , Haibo Xu , Andrew Jones , Conor Dooley , Atish Kumar Patra Subject: Re: [RFC PATCH v1 09/21] RISC-V: cacheflush: Initialize CBO variables on ACPI systems Message-ID: References: <20230803175916.3174453-1-sunilvl@ventanamicro.com> <20230803175916.3174453-10-sunilvl@ventanamicro.com> <20230804-dreamy-unharmed-a502d02af35a@spud> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230804-dreamy-unharmed-a502d02af35a@spud> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230804_095319_023942_45719DA2 X-CRM114-Status: GOOD ( 18.42 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Aug 04, 2023 at 04:19:27PM +0100, Conor Dooley wrote: > On Fri, Aug 04, 2023 at 05:59:51PM +0300, Andy Shevchenko wrote: > > On Fri, Aug 04, 2023 at 02:50:34PM +0530, Sunil V L wrote: > > > On Fri, Aug 04, 2023 at 08:56:29AM +0300, Andy Shevchenko wrote: > > > > On Thu, Aug 03, 2023 at 11:29:04PM +0530, Sunil V L wrote: ... > > > > > +#include > > > > > > > > What do you need this for? > > > > > > > > > #include > > > > > > > When CONFIG_ACPI is disabled, this include is required to get > > > acpi_get_cbo_block_size(). > > > > How is it useful without ACPI being enabled? > > It is not, as evidenced by the `return -EINVAL;`. > > > If it's indeed > > (in which I do not believe), better to make sure you have it > > avaiable independently on CONFIG_ACPI. Otherwise, just put > > #ifdef CONFIG_ACPI around the call. > > Let's not litter the code with ifdeffery please where it can be easily > avoided. Including asm/acpi.h looks to me as a "let's avoid it with a hack that it is uglier than ifdeffery". Sorry, but ifdeffery for ACPI, with all my full agreement with the statement that it's not good, is the correct way to fix this. -- With Best Regards, Andy Shevchenko _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel