From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C8311C001DC for ; Thu, 27 Jul 2023 13:39:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Yf5dj9QEmPVArlO9OqobcJgeH7Gr388RSIdTiUAUOcw=; b=GdZkeI+cmpbSO/ KiVJ3K3Oioq8bYDdzAva1YgDzaJUqiEldsn+6XnV2sbSMak0GckuHStwO+6WX0hB0ULtBzCAuf73i FMxytKIbHWK/VdOXKXZuRY7U8rCwUUu13pBNd+PsRVNmhdqGiwWlVoUeXLjiS8qS143G54bBpvV/2 uIoXrZ6wvxEMpeVJvZ4Jr+Awchh4zJNkp142WLoSnH2uKDgYJgsHZl4lFsyAy7u7VV/BHj2CjHchd wSLW13vynDTRUW3/cjGziB/dv/KJ3J5MNIAU91gGnS4xoDoTmjMHtq4bPM1hoffRZcos7UdRzvjZf GpKN1YGLZrQNJLFuNPzg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qP1DN-00EekF-27; Thu, 27 Jul 2023 13:39:37 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qP1DK-00EehP-2N for linux-arm-kernel@lists.infradead.org; Thu, 27 Jul 2023 13:39:36 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 546DD61E82; Thu, 27 Jul 2023 13:39:33 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2226BC433C7; Thu, 27 Jul 2023 13:39:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1690465172; bh=6hdy3JwNg2XitS/vh4UEJyJy/HRwoPzoH5X3uacaKT0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=mjLFfCqAynxjdNRkS7rjdkXwFZ8VUT65eQGhRxn0YXQPjLqnayngL6pmxJ2l0x2h2 WXUKexGRQXRVqO/yZMZbm1YAFgKc5vFCYFonNcQJHORMt1+aLqDa7k/lq9vH0dIZtQ CZ2ylUXrn2Y+BJQgzIQkHU1RqFjzFDlf21CcmcydTj5lbYidbngPtZe6b2siDxHfpV xqrK+FwJ8KBHOZvsX2/g3w9xB+ksW/5av82FNRv1+QlgHyWWsEEfJu3N/AcawG1MYx 6vbFGotXsBzvn0H3GKVjFGM5naXRy2GMpfffiRPHyA08rAhKAxBnhdH00smO7oAdkm ilIqAb1zMuPsg== Date: Thu, 27 Jul 2023 15:39:27 +0200 From: Lorenzo Pieralisi To: Guanghui Feng Cc: guohanjun@huawei.com, sudeep.holla@arm.com, rafael@kernel.org, linux-acpi@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, baolin.wang@linux.alibaba.com, alikernel-developer@linux.alibaba.com, will@kernel.org, catalin.marinas@arm.com Subject: Re: [PATCH v3] ACPI/IORT: Remove erroneous id_count check in iort_node_get_rmr_info() Message-ID: References: <1689593625-45213-1-git-send-email-guanghuifeng@linux.alibaba.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1689593625-45213-1-git-send-email-guanghuifeng@linux.alibaba.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230727_063934_837466_7C60BD59 X-CRM114-Status: GOOD ( 17.56 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org [+Catalin, Will] On Mon, Jul 17, 2023 at 07:33:45PM +0800, Guanghui Feng wrote: > According to the ARM IORT specifications DEN 0049 issue E, > the "Number of IDs" field in the ID mapping format reports > the number of IDs in the mapping range minus one. > > In iort_node_get_rmr_info(), we erroneously skip ID mappings > whose "Number of IDs" equal to 0, resulting in valid mapping > nodes with a single ID to map being skipped, which is wrong. > > Fix iort_node_get_rmr_info() by removing the bogus id_count > check. > > Fixes: 491cf4a6735a ("ACPI/IORT: Add support to retrieve IORT RMR reserved regions") > Signed-off-by: Guanghui Feng > --- > drivers/acpi/arm64/iort.c | 3 --- > 1 file changed, 3 deletions(-) Acked-by: Lorenzo Pieralisi Catalin/Will, can you pick this up please ? Thanks, Lorenzo > diff --git a/drivers/acpi/arm64/iort.c b/drivers/acpi/arm64/iort.c > index 3631230..56d8873 100644 > --- a/drivers/acpi/arm64/iort.c > +++ b/drivers/acpi/arm64/iort.c > @@ -1007,9 +1007,6 @@ static void iort_node_get_rmr_info(struct acpi_iort_node *node, > for (i = 0; i < node->mapping_count; i++, map++) { > struct acpi_iort_node *parent; > > - if (!map->id_count) > - continue; > - > parent = ACPI_ADD_PTR(struct acpi_iort_node, iort_table, > map->output_reference); > if (parent != iommu) > -- > 1.8.3.1 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel