From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D1988C001E0 for ; Fri, 28 Jul 2023 18:48:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=EkoaJz8ziUYwAmyw2+uZBSUKAl3CEYovSVZLup8K/wI=; b=Vkb3nmbIqBc07q aKVE+6/Nv3DKMA4PnOMg2zOaGaBro2BOebbK7J2tNr4hKubS+4AO65PcfRAfpfnN++YL+TWg7vbTB RFNgsqxqESeHRJmFaSSHxBZHv1gHPVfdp2Vs7AHygLfLcoiE5rlgZY4AWn6xII00sS+F3L8ILw4mk sXX9nIbZEhhJRUVwhAVnfFT+hc2EvFzzAYuY7uw0mGlZolECHJurPxFDVhl1cG4/ZjY4tQaqJc97j +YdsggpSsg+Oliwr2m1YtXbnVYm5FEVGseiHBncjQDj4fSHOaky1Xta4pO8noNpIgZ22/3YhTOnjY 81qlsj1bz8eEfnL+sKLQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qPSVE-004ajV-1w; Fri, 28 Jul 2023 18:47:52 +0000 Received: from out-69.mta0.migadu.com ([91.218.175.69]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qPSVC-004ahd-0w for linux-arm-kernel@lists.infradead.org; Fri, 28 Jul 2023 18:47:52 +0000 Date: Fri, 28 Jul 2023 18:47:40 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1690570066; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=c8yvLUIK06RQnV+ryYtZxv7pPU7Be4Nu1kldUxWjnGs=; b=pSQ6PrxgtzAipZ6/F3I1GCMvO4QAEtJSttNGskJutWkHfocv7PXkdzqBmXO9vHFIix8WHH YAFgERbB4edHX9sU4STeYFJOoQqhymhRwaaY3jagO00wjR6MWTtzuLnMqpqBa5yU7/9Ppx f82YMEUCTg60lJBlVEbroTJwi7B+JTA= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Oliver Upton To: Marc Zyngier Cc: kvmarm@lists.linux.dev, kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Catalin Marinas , Eric Auger , Mark Brown , Mark Rutland , Will Deacon , Alexandru Elisei , Andre Przywara , Chase Conklin , Ganapatrao Kulkarni , Darren Hart , Miguel Luis , James Morse , Suzuki K Poulose , Zenghui Yu Subject: Re: [PATCH v2 19/26] KVM: arm64: nv: Add trap forwarding for HFGxTR_EL2 Message-ID: References: <20230728082952.959212-1-maz@kernel.org> <20230728082952.959212-20-maz@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230728082952.959212-20-maz@kernel.org> X-Migadu-Flow: FLOW_OUT X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230728_114750_760979_9DEB234B X-CRM114-Status: GOOD ( 13.31 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hey Marc, On Fri, Jul 28, 2023 at 09:29:45AM +0100, Marc Zyngier wrote: [...] > @@ -943,6 +1025,27 @@ void __init populate_nv_trap_config(void) > kvm_info("nv: %ld coarse grained trap handlers\n", > ARRAY_SIZE(encoding_to_cgt)); It might make sense to skip insertion of the FGT trap controls if the system doesn't have FGT in the first place. > + for (int i = 0; i < ARRAY_SIZE(encoding_to_fgt); i++) { > + const struct encoding_to_trap_config *fgt = &encoding_to_fgt[i]; > + union trap_config tc; > + > + tc = get_trap_config(fgt->encoding); > + > + WARN(tc.fgt, > + "Duplicate FGT for sys_reg(%d, %d, %d, %d, %d)\n", > + sys_reg_Op0(fgt->encoding), > + sys_reg_Op1(fgt->encoding), > + sys_reg_CRn(fgt->encoding), > + sys_reg_CRm(fgt->encoding), > + sys_reg_Op2(fgt->encoding)); Same comment here, we should just bail. > + tc.val |= fgt->tc.val; > + xa_store(&sr_forward_xa, fgt->encoding, > + xa_mk_value(tc.val), GFP_KERNEL); > + } > + > + kvm_info("nv: %ld fine grained trap handlers\n", > + ARRAY_SIZE(encoding_to_fgt)); > } -- Thanks, Oliver _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel