From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CE3E1C001DF for ; Mon, 31 Jul 2023 12:12:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=ds/IloUJX3adN3CcQXyvdOF9v0/QVl74yYrZhpziYTI=; b=gjC2SSaK1XIA1W 9f8kRNQZUj+cKrXXMwjvl/u4fa0PbOJwMtT14SG/DvdVSWMzsxmVf54YR/npigFtH1nzFVJjpsb4N dhoyxeqGJ7+Ne9z1ij1aeFVdy24Gllglhq/TX3j7c4ItwC/alYOuoph1t1xAKMZqtm5FDlmsFA3Bx rltG0Y4Rf+q3tjUZ5IXMuO3gdDa01NWszcLOwUSksc5eNFPAR7Nqo9xSclJ49xKF35REvGm9Klht9 vprZ2HC60qeHzUqEn4pePli1+kNBNXL5XEJ05B9Zdz8n3twgWw5gA6JblhXrfMVrNYZh7lrTvULaZ 5XCRWkgbZ6sGAmrRaY1w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qQRkq-00FWIW-2E; Mon, 31 Jul 2023 12:12:04 +0000 Received: from mail-ej1-x631.google.com ([2a00:1450:4864:20::631]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qQRko-00FWGg-2g for linux-arm-kernel@lists.infradead.org; Mon, 31 Jul 2023 12:12:04 +0000 Received: by mail-ej1-x631.google.com with SMTP id a640c23a62f3a-98df3dea907so645248866b.3 for ; Mon, 31 Jul 2023 05:12:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=resnulli-us.20221208.gappssmtp.com; s=20221208; t=1690805519; x=1691410319; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=TCRpBBOXRt66nrHvcNiyBDUNvZ5LmzoF9YZ7grd0BQo=; b=EKsGsVeQ4drni87wkK8WbdLTSFlZI5vKda+Fp0sWnA3hz8gEvUviS8orRfSK2kKXlO 3fg82tZgHcc1TuYTwldP1twEMISraccVpYdeod+ZyZaG0RxDs9Ca5BARtoFQRx8OGPyJ 3C/YryosOpC8ctLScPYSswQ+PMbpvIYWMKZ8VD6yN6kk2mrHEJ56HDBtof9n0lF/2d4u KF5BIkzUllM2Kg0UT9YD5Fz5B1QRsoybR1fJxwfpVj/P5/kdnmyG5JVu2RlgqejRavvT 1TMeSuAimYr37f/IwHT2evjlRGfCHtziJcIUKS/cvbu1T2EN57RE6rdyNv4hLtlaXf5I wepA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690805519; x=1691410319; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=TCRpBBOXRt66nrHvcNiyBDUNvZ5LmzoF9YZ7grd0BQo=; b=V/p+7HTH4aBiER1hvJMYrAmHA15fmMi2HkUxwBm2z2T+lDNcpRpgDpyyEjgK+sbBaO 8xZmSMzonMrZL6bBr7pVf96k9zyWE3pc8e9kqYsmjkxTj1wya7pcTvNoB84lEnqeBCfz TltOQz6Bz6LV/FTib2r9tkNKxA69O+rcFgInHx1gzfjuOKBFMmalvz/7lgHDlqOiQjPm fi9CgcUz8AhVkY5YjHCzSrbHcE7Th5Kvoa6NnOPM3gsFUvgJsW++A47+B1VvaJHzYflk waxXEnaXLwAS1/sbLvLgC63MndBmSIDdgHyQ1chEVh/HZhgsLhh/v4/EP6spwDxYaY1Q g9iQ== X-Gm-Message-State: ABy/qLZpCDwxbS/ALzZSDsFDD8tJTE2/wCfHrsQYTW59spKeajEsyP3E Rz4utJmwmnCC3uqzuFTJlkRDtg== X-Google-Smtp-Source: APBJJlHRuhSxixgmaPI/GHZ9fICq6Co32qefCCbwO83NICKAhcGDLv+Uf8kwnvDPgbPs0xqSLHESYA== X-Received: by 2002:a17:907:2bf4:b0:994:569b:61b8 with SMTP id gv52-20020a1709072bf400b00994569b61b8mr6020219ejc.58.1690805518997; Mon, 31 Jul 2023 05:11:58 -0700 (PDT) Received: from localhost ([212.23.236.67]) by smtp.gmail.com with ESMTPSA id z7-20020a170906074700b0099293cdbc98sm6148952ejb.145.2023.07.31.05.11.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 31 Jul 2023 05:11:58 -0700 (PDT) Date: Mon, 31 Jul 2023 14:11:57 +0200 From: Jiri Pirko To: Jakub Kicinski Cc: "Kubalewski, Arkadiusz" , Vadim Fedorenko , Jonathan Lemon , Paolo Abeni , "Olech, Milena" , "Michalik, Michal" , "linux-arm-kernel@lists.infradead.org" , poros , mschmidt , "netdev@vger.kernel.org" , "linux-clk@vger.kernel.org" , Bart Van Assche Subject: Re: [PATCH 09/11] ice: implement dpll interface to control cgu Message-ID: References: <20230720091903.297066-1-vadim.fedorenko@linux.dev> <20230720091903.297066-10-vadim.fedorenko@linux.dev> <20230725154958.46b44456@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230725154958.46b44456@kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230731_051202_871513_C02BA2A7 X-CRM114-Status: GOOD ( 13.52 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Wed, Jul 26, 2023 at 12:49:58AM CEST, kuba@kernel.org wrote: >On Fri, 21 Jul 2023 14:02:08 +0200 Jiri Pirko wrote: >> So it is not a mode! Mode is either "automatic" or "manual". Then we >> have a state to indicate the state of the state machine (unlocked, locked, >> holdover, holdover-acq). So what you seek is a way for the user to >> expliticly set the state to "unlocked" and reset of the state machine. > >+1 for mixing the state machine and config. >Maybe a compromise would be to rename the config mode? >Detached? Standalone? But even with different name, you will still have the same mixture. Why having automatic/manual mode with possibility to connect/disconnect pins with additional uapi extension to submit state reset command is not enough? Clear and simple, easy to document and understand. There are too many uncertanties about "freerun" mode, very confusing, not clear behaviour (as this thread demonstrated). That is extually very good reason to don't have it. Could we please drop it? > >> Please don't mix config and state. I think we untangled this in the past >> :/ >> >> Perhaps you just need an extra cmd like DPLL_CMD_DEVICE_STATE_RESET cmd >> to hit this button. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel