From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 609C7C04A6A for ; Wed, 2 Aug 2023 03:19:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=rafeeG1E9TNfDfgi//f0Aygng/hnf8K6w10XIjwYcYA=; b=PlZe3q+xw44MVw mgWQiIxdahG/ztURieKKYL1FbI8ZgoKhlLctU1z80LLiEfMgqTuELTuI+9aFsBb28qsofRzZpUMax ZXy12wUHiIPrj7lKfz51pmgQPFx61yMUCX5KxurtUB3dWoscYsv8PD8bqnwyKh5/7zQk1tA9RT3fK bYFJHKm00cBrZLwx360EZToakibNMWAMAEbKdbP+pNnFVqXGdJlcBCIZUKtfGNmau4TnG37zB7rXP ZHXiZzfR7AeP8uU8qZbbzs5Sp0jAUdpv8hPqvINqDY/4YM3uxVSmZEqYe3eN2fxyg3nQA+MLCO9LM GqdLnUb9w8u6ryBa+41A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qR2Nq-003qyq-0T; Wed, 02 Aug 2023 03:18:46 +0000 Received: from [192.55.52.151] (helo=mgamail.intel.com) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qR2Nn-003qyP-1K for linux-arm-kernel@lists.infradead.org; Wed, 02 Aug 2023 03:18:44 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1690946323; x=1722482323; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=9NCM2C6plWYZlTWDXnxmxP68QKs4h7xrJfHjoOpKpzc=; b=QgNLwmMk2RbMI0TpOwTViwVoosiu7YAmt/jkftfNszyWSBTFrgrtOhbd VZEFd7FfTqPu7XqmLRCj3QRv9vhySucv5W1xHR4M/c318MlSSCiedt2DC 9NwviT7/T0nELx+ph9bu/pKDwv+gFJTGJ+yfLmbP0OkI4ynZGYvsMIXpe 2xdwFoXzGvCqa3sinzZX7BCh1jxsXhviMb3anlYUvNg+0DjF9sMAaaGpU nCW9JgaWgMq+0gdnZniQtraXB52MXj3aNAn9LG/2UVEqPd845JIaQol9E /5EetJIWNvbuuBTmBo971ekK6lf4aPHi+7sXGJ3QA6H/lG67jiHg1Ym7l A==; X-IronPort-AV: E=McAfee;i="6600,9927,10789"; a="349773133" X-IronPort-AV: E=Sophos;i="6.01,248,1684825200"; d="scan'208";a="349773133" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Aug 2023 20:18:41 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10789"; a="794424914" X-IronPort-AV: E=Sophos;i="6.01,248,1684825200"; d="scan'208";a="794424914" Received: from smile.fi.intel.com ([10.237.72.54]) by fmsmga008.fm.intel.com with ESMTP; 01 Aug 2023 20:18:36 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.96) (envelope-from ) id 1qR2Nd-00ExOt-1i; Wed, 02 Aug 2023 06:18:33 +0300 Date: Wed, 2 Aug 2023 06:18:33 +0300 From: Andy Shevchenko To: Bjorn Helgaas Cc: Shuah Khan , David Gow , Daniel Latypov , "Steven Rostedt (Google)" , Bjorn Helgaas , linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, kunit-dev@googlegroups.com, linux-arm-kernel@lists.infradead.org, linux-pci@vger.kernel.org, linux-trace-kernel@vger.kernel.org, Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Brendan Higgins , Mark Rutland , Lorenzo Pieralisi , Sudeep Holla , Masami Hiramatsu , Andrew Morton Subject: Re: [PATCH v4 1/4] kernel.h: Split out COUNT_ARGS() and CONCATENATE() to args.h Message-ID: References: <20230718211147.18647-2-andriy.shevchenko@linux.intel.com> <20230801211139.GA51676@bhelgaas> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230801211139.GA51676@bhelgaas> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230801_201843_472256_6664DA3B X-CRM114-Status: GOOD ( 20.96 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Aug 01, 2023 at 04:11:39PM -0500, Bjorn Helgaas wrote: > On Wed, Jul 19, 2023 at 12:11:44AM +0300, Andy Shevchenko wrote: > > kernel.h is being used as a dump for all kinds of stuff for a long time. > > The COUNT_ARGS() and CONCATENATE() macros may be used in some places > > without need of the full kernel.h dependency train with it. > > > > Here is the attempt on cleaning it up by splitting out these macros(). > > > > While at it, include new header where it's being used. > > > > Signed-off-by: Andy Shevchenko > > Acked-by: Steven Rostedt (Google) > > Acked-by: Bjorn Helgaas # PCI Thank you! ... > > - > > +#include > > #include > > > > #include > > If there's not a reason otherwise, I'd put this in the main list > instead of the weirdly separated mod_devicetable.h. The idea is to make them alphabetically ordered. currently even main list is a mess. And I have no idea why mod_devicetable.h is so special, a few bus headers (e.g., i2c, spi) consider that just as yet another header while actually ain't using it (in the respective _headers_). That said, I would take the sorting change as a separate one that can be done after this. -- With Best Regards, Andy Shevchenko _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel