From: Heikki Krogerus <heikki.krogerus@linux.intel.com>
To: Zhu Wang <wangzhu9@huawei.com>
Cc: linux@roeck-us.net, gregkh@linuxfoundation.org,
matthias.bgg@gmail.com, angelogioacchino.delregno@collabora.com,
linux-usb@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org
Subject: Re: [PATCH -next] usb: typec: tcpci_mt6370: remove redundant dev_err_probe()
Date: Wed, 2 Aug 2023 13:59:24 +0300 [thread overview]
Message-ID: <ZMo3DNX4yHkuTnpF@kuha.fi.intel.com> (raw)
In-Reply-To: <20230801122834.89168-1-wangzhu9@huawei.com>
On Tue, Aug 01, 2023 at 08:28:34PM +0800, Zhu Wang wrote:
> When platform_get_irq() is called, the error message has been printed,
> so it need not to call dev_err_probe() to present error messages.
>
> Signed-off-by: Zhu Wang <wangzhu9@huawei.com>
Acked-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
> ---
> drivers/usb/typec/tcpm/tcpci_mt6370.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/usb/typec/tcpm/tcpci_mt6370.c b/drivers/usb/typec/tcpm/tcpci_mt6370.c
> index 2a079464b398..9cda1005ef01 100644
> --- a/drivers/usb/typec/tcpm/tcpci_mt6370.c
> +++ b/drivers/usb/typec/tcpm/tcpci_mt6370.c
> @@ -147,7 +147,7 @@ static int mt6370_tcpc_probe(struct platform_device *pdev)
>
> irq = platform_get_irq(pdev, 0);
> if (irq < 0)
> - return dev_err_probe(dev, irq, "Failed to get irq\n");
> + return irq;
>
> /* Assign TCPCI feature and ops */
> priv->tcpci_data.auto_discharge_disconnect = 1;
> --
> 2.17.1
--
heikki
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2023-08-02 11:00 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-01 12:28 [PATCH -next] usb: typec: tcpci_mt6370: remove redundant dev_err_probe() Zhu Wang
2023-08-01 12:38 ` AngeloGioacchino Del Regno
2023-08-01 14:35 ` Guenter Roeck
2023-08-02 10:59 ` Heikki Krogerus [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZMo3DNX4yHkuTnpF@kuha.fi.intel.com \
--to=heikki.krogerus@linux.intel.com \
--cc=angelogioacchino.delregno@collabora.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-usb@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=matthias.bgg@gmail.com \
--cc=wangzhu9@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).