From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6DA1FC001DF for ; Wed, 2 Aug 2023 07:43:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=O6TCt1tLCKOzgXIFvH01hCAscxul/XkNhxaWpcSr7/4=; b=A3SCnWhwB+JKaX 9y7bI3FUITWWk+QpMzX1eEmIkTlSgnP7Bni0WD0tY5XgikzvYG9ilcgDOKY1TUdLpCfQ+ZCPJ/eG/ Xv171caEDrd1GY+AqwL8Ovfj5/bKi+z8RutDhoQSV5uZl6gBagaEmWamVACkHVTi5z57sWpGUTXzD y/uHt9xVjl/XUPUXgQcQedpK/dt1ZRuNRC7V/7KRWBVmv7pMLiZ3UH8uhCu7fhyLIA6Tu0MraaS93 ouZVqc3/7rqqJWh04MuPFLeTEzl+qCBwmBZDhMNxrAJF/gZ5Q/bNWHruh/U6Z7S8QpB8vZq2gKhA/ xZHtaNe+fPw8zsafTigw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qR6VN-004HYn-0p; Wed, 02 Aug 2023 07:42:49 +0000 Received: from mail11.truemail.it ([217.194.8.81]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qR6VK-004HXY-2h for linux-arm-kernel@lists.infradead.org; Wed, 02 Aug 2023 07:42:48 +0000 Received: from francesco-nb.int.toradex.com (93-49-2-63.ip317.fastwebnet.it [93.49.2.63]) by mail11.truemail.it (Postfix) with ESMTPA id C6487213FA; Wed, 2 Aug 2023 09:42:42 +0200 (CEST) Date: Wed, 2 Aug 2023 09:42:39 +0200 From: Francesco Dolcini To: Nishanth Menon Cc: Francesco Dolcini , Vignesh Raghavendra , Tero Kristo , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Hiago De Franco , linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Francesco Dolcini Subject: Re: [PATCH v1 2/2] arm64: dts: ti: k3-am625-verdin: enable CAN_2 Message-ID: References: <20230724133612.37366-1-francesco@dolcini.it> <20230724133612.37366-3-francesco@dolcini.it> <20230802034325.puqhry4xocaceldl@clothes> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230802034325.puqhry4xocaceldl@clothes> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230802_004247_038714_59EA1871 X-CRM114-Status: GOOD ( 11.34 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Aug 01, 2023 at 10:43:25PM -0500, Nishanth Menon wrote: > On 15:36-20230724, Francesco Dolcini wrote: > [...] > > > + /* Verdin CAN_2 */ > > + pinctrl_mcu_mcan0: mcu-mcan0-default-pins { > > + pinctrl-single,pins = < > > + AM62X_MCU_IOPAD(0x0038, PIN_INPUT, 0) /* (B3) MCU_MCAN0_RX */ /* SODIMM 26 */ > > + AM62X_MCU_IOPAD(0x0034, PIN_OUTPUT, 0) /* (D6) MCU_MCAN0_TX */ /* SODIMM 24 */ > > This is minor - I realize we already accepted this, but: > /* (B3) MCU_MCAN0_RX */ /* SODIMM 26 */ > Vs > /* (B3) MCU_MCAN0_RX - SODIMM 26 */ > > I wonder if you'd like the second style. For sure I do not like to have the file with 2 different styles, and to me this is just a taste thingy that would not justify updating the whole file. I'll keep it as it is. Francesco _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel