From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4368FC04E69 for ; Wed, 2 Aug 2023 13:41:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=w9wBkuu2u47zxaCWplNysUAG0brb/MP77kve1d05rq0=; b=KuKyGti3PSsuJn PKZt2RptFUPypyW2LFRSboLVwRvErWuDGEFTnP0ths3/hebPTwHrheRhKIZ+6keT/RgOHbaj2UsTA A5FVONN6U33XFJ1ahW+xg4y6x9eyHAKzvJ91bheU5ExsMWKX97o2wVhVUUsTkbKsRTP7OLkxS/rh5 6CY2ZAedjYsQroP1BtsmDk5SP2+p8bsKfArG5+4v4thHDELadMn7CVNSuyJPsxA29uANjSERWXcqI 4XlBnZrSt9ftSO7ZhwgZOV5ZFKFKvoAcpYm8cWnxLZDVSXMQV83GOEy6Ob33oNvTp11iQnmCWM3pI TYySAL/dvhlxg6xbO5Hg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qRC6D-004zm9-03; Wed, 02 Aug 2023 13:41:13 +0000 Received: from mail11.truemail.it ([2001:4b7e:0:8::81]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qRC6A-004zlI-0a for linux-arm-kernel@lists.infradead.org; Wed, 02 Aug 2023 13:41:11 +0000 Received: from francesco-nb.int.toradex.com (93-49-2-63.ip317.fastwebnet.it [93.49.2.63]) by mail11.truemail.it (Postfix) with ESMTPA id 2B985209F0; Wed, 2 Aug 2023 15:41:07 +0200 (CEST) Date: Wed, 2 Aug 2023 15:41:03 +0200 From: Francesco Dolcini To: Nishanth Menon Cc: Francesco Dolcini , Jai Luthra , Vignesh Raghavendra , Tero Kristo , Rob Herring , Krzysztof Kozlowski , Conor Dooley , linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Francesco Dolcini Subject: Re: [PATCH v1 1/4] arm64: dts: ti: k3-am62x: Enable AUDIO_REFCLKx Message-ID: References: <20230731142135.108477-1-francesco@dolcini.it> <20230731142135.108477-2-francesco@dolcini.it> <23C6E13C-3F10-490B-A18E-C67B91CBAF35@dolcini.it> <20230802133244.b66pg3mztotgqotm@steerable> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230802133244.b66pg3mztotgqotm@steerable> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230802_064110_384091_4FF37908 X-CRM114-Status: GOOD ( 24.98 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Aug 02, 2023 at 08:32:44AM -0500, Nishanth Menon wrote: > On 13:37-20230802, Francesco Dolcini wrote: > > Il 2 agosto 2023 13:23:50 CEST, Jai Luthra ha scritto: > > >On Jul 31, 2023 at 16:21:32 +0200, Francesco Dolcini wrote: > > >> From: Jai Luthra > > >> > > >> On AM62-based SoCs the AUDIO_REFCLKx clocks can be used as an input to > > >> external peripherals when configured through CTRL_MMR, so add the > > >> clock nodes. > > >> > > >> Signed-off-by: Jai Luthra > > >> Signed-off-by: Francesco Dolcini > > >> --- > > >> arch/arm64/boot/dts/ti/k3-am62-main.dtsi | 18 ++++++++++++++++++ > > >> arch/arm64/boot/dts/ti/k3-am62a-main.dtsi | 18 ++++++++++++++++++ > > > > > >Given currently none of the AM62A boards are using the refclks, can you > > >drop those or just mark the nodes as disabled. Whoever is the first user > > >can enable them. > > > > I can drop the 2 clocks from AM62A, however, should we really do it? > > These clocks exist and they are just defined in the DTS, they are > > not going to be enabled if not used, "ti,am62-epwm-tbclk" is also > > not disabled for example. > > Overall, the SoC clock as such has nothing to do with board specific, so > leave it default (enabled) in SoC.dts - just want to make sure that the > clk-parent selection doesn't get in the way of platforms and is a sane > default. When I looked into that, months ago, this looked to me the correct and a sane default. I had the same in our downstream way before the addition from Jai Luthra to the SoC dtsi. Not sure if Jai can add more on that regard. > pll2_hsdiv8 output - which looks like the default mux value anyways.. > I am ok for it being explicit, but wondering if that works for boards > that do not use this default. IFF needed, it would be very easy to just override from the board dts, using the labels that are already there (audio_refclk0, audio_refclk1). > (sidenote): Fransesco - your new mail client has line wrap issues ;) Yep, I had the crazy idea to reply from my mobile phone while having a walk. It's already a success that I did not top post ;-) Francesco _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel