From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 61A0BC001DF for ; Wed, 2 Aug 2023 20:17:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=TK4RcBaG2P3wNZOxTsY4cAJImtYWDmDJVJjeFIoMyac=; b=wfExIBlQQ+aMgf jmqit3HIs09IQGXEgWDtgCNwh1oDBTyHBm6CbdaNxsLYeZVny/0KEjFFKun86HBaeFHhxFkauJ44I fAuI9lPPgUc1i28x98xXIlXkbpUsbFJFEKr3l6Dgd1kvT61Vg1hSCG/S2xSybRwfffMcGtHpqscPZ I416UytH/zmkmEQUCjXDTBywrb+fkr3JVWlXkS836M4HJrFvevNsvBdnwWyQaePbP+VkhBLqITzQe TFc2bwcCGrbKMW/Yy0VSFy4y8Fj5P/uDyBq9ttWrbwuauTTmQW17QBBDhqFF2C0nmSMxLfbGhiVE+ ET4hvwiw9JnAkuWnRagQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qRIHk-005oHf-27; Wed, 02 Aug 2023 20:17:32 +0000 Received: from out-81.mta1.migadu.com ([95.215.58.81]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qRIHh-005oFq-27 for linux-arm-kernel@lists.infradead.org; Wed, 02 Aug 2023 20:17:31 +0000 Date: Wed, 2 Aug 2023 20:17:16 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1691007440; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=1T22WeV8+vYeVNiq20HOce62vnsYflUAaIDMYQ8Q6i4=; b=jdpl5FMvI9YSd8pRMe3NdvNqYEvqs3FKab3q5uuWVSgi0uBV8ZItn0xJHc7clVNGPQgLGu 1vS+is+Tb5AMGSKVp8pJEdzP+zBvCCMyNpraOIzj8qogZiA7JmjJjonScKPJiLo56QD2Qy HXAvZbsqPx6i6zNWC4Eu86TfNQzUS0I= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Oliver Upton To: Jing Zhang Cc: Marc Zyngier , KVM , KVMARM , ARMLinux , Paolo Bonzini , James Morse , Suzuki K Poulose , Zenghui Yu Subject: Re: [PATCH v1] KVM: arm64: selftests: Test pointer authentication support in KVM guest Message-ID: References: <20230726044652.2169513-1-jingzhangos@google.com> <871qgvrwbi.wl-maz@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-Migadu-Flow: FLOW_OUT X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230802_131729_841265_7C50CDB7 X-CRM114-Status: GOOD ( 18.86 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Jing, Nothing serious, but when you're replying on a thread can you add a leading and trailing line of whitespace between the quotation and your reply? Otherwise threads get really dense and hard to read. On Wed, Aug 02, 2023 at 10:19:30AM -0700, Jing Zhang wrote: > > > + case FAIL_KVM: > > > + TEST_FAIL("KVM doesn't support guest PAuth!\n"); > > > > Why is that a hard failure? The vast majority of the HW out there > > doesn't support PAuth... > Since previous TEST_REQUIRES have passed, KVM should be able to > support guest PAuth. The test will be skipped on those HW without > PAuth. So then what is the purpose of this failure mode? The only case where this would happen is if KVM is if KVM screwed up the emulation somehow, took a trap on a PAC instruction or register and reflected that back into the guest as an UNDEF. That's a perfectly valid thing to test for, but the naming and failure messages should indicate what actually happened. > > As I mentioned above, another thing I'd like to see is a set of > > reference results for a given set of keys and architected algorithm > > (QARMA3, QARMA5) so that we can compare between implementations > > (excluding the IMPDEF implementations, of course). > Sure. Will do. I was initially hesitant towards testing PAC like this since it is entirely a hardware issue besides KVM context switching, but you could spin this off as a way to test if vCPU save/restore works correctly by priming the vCPU from userspace. Marc, is there something else here you're interested in exercising I may've missed? -- Thanks, Oliver _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel