From: Wei Liu <wei.liu@kernel.org>
To: Nuno Das Neves <nunodasneves@linux.microsoft.com>
Cc: linux-hyperv@vger.kernel.org, linux-kernel@vger.kernel.org,
x86@kernel.org, linux-arm-kernel@lists.infradead.org,
linux-arch@vger.kernel.org, mikelley@microsoft.com,
kys@microsoft.com, wei.liu@kernel.org, haiyangz@microsoft.com,
decui@microsoft.com, ssengar@linux.microsoft.com,
mukeshrathor@microsoft.com, stanislav.kinsburskiy@gmail.com,
jinankjain@linux.microsoft.com, apais@linux.microsoft.com,
Tianyu.Lan@microsoft.com, vkuznets@redhat.com,
tglx@linutronix.de, mingo@redhat.com, bp@alien8.de,
dave.hansen@linux.intel.com, hpa@zytor.com, will@kernel.org,
catalin.marinas@arm.com
Subject: Re: [PATCH 09/15] Drivers: hv: Introduce hv_output_arg_exists in hv_common
Date: Thu, 3 Aug 2023 00:16:38 +0000 [thread overview]
Message-ID: <ZMrx5m2Tg7bfX9Ce@liuwe-devbox-debian-v2> (raw)
In-Reply-To: <1690487690-2428-10-git-send-email-nunodasneves@linux.microsoft.com>
On Thu, Jul 27, 2023 at 12:54:44PM -0700, Nuno Das Neves wrote:
> This is a more flexible approach for determining whether to allocate the
> output page.
> This will be used in both mshv_vtl and root partition.
>
> Signed-off-by: Nuno Das Neves <nunodasneves@linux.microsoft.com>
> ---
> drivers/hv/hv_common.c | 30 +++++++++++++++++++++++++-----
> 1 file changed, 25 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/hv/hv_common.c b/drivers/hv/hv_common.c
> index 99d9b262b8a7..16f069beda78 100644
> --- a/drivers/hv/hv_common.c
> +++ b/drivers/hv/hv_common.c
> @@ -57,6 +57,18 @@ EXPORT_SYMBOL_GPL(hyperv_pcpu_input_arg);
> void * __percpu *hyperv_pcpu_output_arg;
> EXPORT_SYMBOL_GPL(hyperv_pcpu_output_arg);
>
> +/*
> + * Determine whether output arg is in use, for allocation/deallocation
> + */
> +static bool hv_output_arg_exists(void)
> +{
> + bool ret = hv_root_partition ? true : false;
> +#ifdef CONFIG_MSHV_VTL
> + ret = true;
> +#endif
This should not be here. As far as I can tell, CONFIG_MSHV_VTL is
introduced in a later patch.
The rest looks okay.
Thanks,
Wei.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-08-03 0:17 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-27 19:54 [PATCH 00/15] Introduce /dev/mshv drivers Nuno Das Neves
2023-07-27 19:54 ` [PATCH 01/15] hyperv-tlfs: Change shared HV_REGISTER_* defines to HV_MSR_* Nuno Das Neves
2023-08-03 1:25 ` Wei Liu
2023-07-27 19:54 ` [PATCH 02/15] mshyperv: Introduce hv_get_hypervisor_version Nuno Das Neves
2023-08-02 23:39 ` Wei Liu
2023-08-15 21:57 ` Nuno Das Neves
2023-07-27 19:54 ` [PATCH 03/15] mshyperv: Introduce numa_node_to_proximity_domain_info Nuno Das Neves
2023-08-02 23:47 ` Wei Liu
2023-07-27 19:54 ` [PATCH 04/15] asm-generic/mshyperv: Introduce hv_recommend_using_aeoi() Nuno Das Neves
2023-08-02 23:48 ` Wei Liu
2023-07-27 19:54 ` [PATCH 05/15] hyperv: Move hv_connection_id to hyperv-tlfs Nuno Das Neves
2023-08-02 23:55 ` Wei Liu
2023-08-15 22:04 ` Nuno Das Neves
2023-07-27 19:54 ` [PATCH 06/15] hyperv-tlfs: Introduce hv_status_to_string and hv_status_to_errno Nuno Das Neves
2023-07-27 19:54 ` [PATCH 07/15] Drivers: hv: Move hv_call_deposit_pages and hv_call_create_vp to common code Nuno Das Neves
2023-08-03 0:02 ` Wei Liu
2023-07-27 19:54 ` [PATCH 08/15] Drivers: hv: Introduce per-cpu event ring tail Nuno Das Neves
2023-08-03 0:10 ` Wei Liu
2023-08-16 21:40 ` Nuno Das Neves
2023-07-27 19:54 ` [PATCH 09/15] Drivers: hv: Introduce hv_output_arg_exists in hv_common Nuno Das Neves
2023-08-03 0:16 ` Wei Liu [this message]
2023-08-16 21:56 ` Nuno Das Neves
2023-07-27 19:54 ` [PATCH 10/15] x86: hyperv: Add mshv_handler irq handler and setup function Nuno Das Neves
2023-08-03 0:17 ` Wei Liu
2023-07-27 19:54 ` [PATCH 11/15] Drivers: hv: export vmbus_isr, hv_context and hv_post_message Nuno Das Neves
2023-08-03 0:17 ` Wei Liu
2023-07-27 19:54 ` [PATCH 12/15] Documentation: Reserve ioctl number for mshv driver Nuno Das Neves
2023-08-03 0:23 ` Wei Liu
2023-08-03 13:23 ` Jonathan Corbet
2023-08-03 21:05 ` Wei Liu
2023-07-27 19:54 ` [PATCH 13/15] uapi: hyperv: Add mshv driver headers hvhdk.h, hvhdk_mini.h, hvgdk.h, hvgdk_mini.h Nuno Das Neves
2023-08-03 0:27 ` Wei Liu
2023-07-27 19:54 ` [PATCH 14/15] asm-generic: hyperv: Use mshv headers conditionally. Add asm-generic/hyperv-defs.h Nuno Das Neves
2023-08-03 0:48 ` Wei Liu
2023-08-17 16:41 ` Nuno Das Neves
2023-07-27 21:05 ` [PATCH 00/15] Introduce /dev/mshv drivers Nuno Das Neves
[not found] ` <1690487690-2428-16-git-send-email-nunodasneves@linux.microsoft.com>
2023-08-03 1:23 ` [PATCH 15/15] Drivers: hv: Add modules to expose /dev/mshv to VMMs running on Hyper-V Wei Liu
2023-08-17 17:57 ` Nuno Das Neves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZMrx5m2Tg7bfX9Ce@liuwe-devbox-debian-v2 \
--to=wei.liu@kernel.org \
--cc=Tianyu.Lan@microsoft.com \
--cc=apais@linux.microsoft.com \
--cc=bp@alien8.de \
--cc=catalin.marinas@arm.com \
--cc=dave.hansen@linux.intel.com \
--cc=decui@microsoft.com \
--cc=haiyangz@microsoft.com \
--cc=hpa@zytor.com \
--cc=jinankjain@linux.microsoft.com \
--cc=kys@microsoft.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-hyperv@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mikelley@microsoft.com \
--cc=mingo@redhat.com \
--cc=mukeshrathor@microsoft.com \
--cc=nunodasneves@linux.microsoft.com \
--cc=ssengar@linux.microsoft.com \
--cc=stanislav.kinsburskiy@gmail.com \
--cc=tglx@linutronix.de \
--cc=vkuznets@redhat.com \
--cc=will@kernel.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).