Re: [RFC PATCH v1 05/21] arm64: PCI: Migrate ACPI related functions to pci-acpi.c

Sunil V L
2023-08-04T08:24:05Z

On Fri, Aug 04, 2023 at 08:53:14AM +0300, Andy Shevchenko wrote:
> On Thu, Aug 03, 2023 at 11:29:00PM +0530, Sunil V L wrote:
> > The functions defined in arm64 for ACPI support are required
> > for RISC-V also. To avoid duplication, copy these functions
> > to common location.
>
> ...
>
> > }
> > +
>
> Stray change.
>
Let me remove this in next version.

> > arch_initcall(acpi_pci_init);
> > +
> > +#if defined(CONFIG_ARM64)
>
> ...
>
> > + cfg = pci_ecam_create(dev, &cfgres, bus_res, ecam_ops);
> > + if (IS_ERR(cfg)) {
> > + dev_err(dev, "%04x:%pR error %ld mapping ECAM\n", seg, bus_res,
> > + PTR_ERR(cfg));
> > + return NULL;
> > + }
> > +
> > + return cfg;
>
> Can be
>
> cfg = pci_ecam_create(dev, &cfgres, bus_res, ecam_ops);
> ret = PTR_ERR_OR_ZERO(cfg);
> if (ret) {
> dev_err(dev, "%04x:%pR error %d mapping ECAM\n", seg, bus_res, ret);
>
> but as far as I understand this is in the original code like this, so consider
> as a suggestion for further cleanups.
>

Good suggestion!. Sure, we can cleanup as a follow on patch.

Thanks,
Sunil