From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 33F49EB64DD for ; Thu, 17 Aug 2023 10:08:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=82vxqcxUEe/2OP8gHiLRcSVo1BGFuA3t9nLjoFdBAVI=; b=rJMOcJNk8afD+A pMVoKGAaKfO8FuE3UqPXzR9i38LhB30UAQ4ejKe1o2DkE3M0NyqX36Us3MCi7BD6UzWqQZN6yM0KY z07MBZzPf1lqJ+lrqUpXuP2i+lJOEoOHVTGYdxsGXCstvY6wPNxK0ECYouzM17tcjTYqwnj+2O7a5 wlce7r6pj6GxJftE+P9g0ZVgsdNCwvZ+bNrzJb5RvubXAJaMC/MewTmh+I3JUG4d65nzdM7+Hq6Nc z4R5gN3iEmWnrDBj10X+vazX6OnXh7W7lBRW1/QQ74pb3oUpcAZbvv6ILIvUrwSy570j7WusO6t4v dus96ddf8uMk9zwGCBhg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qWZuv-0060IP-0Y; Thu, 17 Aug 2023 10:07:49 +0000 Received: from [2001:4d48:ad52:32c8:5054:ff:fe00:142] (helo=pandora.armlinux.org.uk) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qWZur-0060Hk-19 for linux-arm-kernel@lists.infradead.org; Thu, 17 Aug 2023 10:07:47 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=P5M5Z06zfN4qTYiE3IHnPFu/3qnQFk9Eq4f88wCaOJY=; b=0uTNtezhZEBnSrGa8TleMZPN8Y iJRvYwA/qtKt4gtC9togK7nqLiyvIq4RIDtcI6PnGds61P5I2adxo6bia8fIjsps2QzDi3FIw2w1E CrcA/qRO5NWrkE91ce9el6Md//MvM+sCFDVDR1qdorXvPB9FK5Z2gsYIYMnqomKZfGb7mQVxZ2OA9 ZU+MoxuN2jCESw+Sc5Hi3vnR1I+DQBsJV2ljj3xBwuztHa6EIC1IZOvfjV/yaOSWnNZnfC/t3RT8N z2wCZgotHMGrqLkoHJQJCl7NqACQhykmt91MHDVSKoZye7muVWazbbpqhSxQyZBmiYr9SCWQli6oo 5YyTHMug==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:48774) by pandora.armlinux.org.uk with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1qWZuO-0003zG-0u; Thu, 17 Aug 2023 11:07:16 +0100 Received: from linux by shell.armlinux.org.uk with local (Exim 4.94.2) (envelope-from ) id 1qWZuI-0000VX-Ok; Thu, 17 Aug 2023 11:07:10 +0100 Date: Thu, 17 Aug 2023 11:07:10 +0100 From: "Russell King (Oracle)" To: Ruan Jinjie Cc: davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, lars.povlsen@microchip.com, Steen.Hegelund@microchip.com, daniel.machon@microchip.com, alexandre.torgue@foss.st.com, joabreu@synopsys.com, mcoquelin.stm32@gmail.com, horatiu.vultur@microchip.com, simon.horman@corigine.com, netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-stm32@st-md-mailman.stormreply.com Subject: Re: [PATCH net-next 2/2] net: stmmac: Use helper function IS_ERR_OR_NULL() Message-ID: References: <20230817071941.346590-1-ruanjinjie@huawei.com> <20230817071941.346590-3-ruanjinjie@huawei.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230817071941.346590-3-ruanjinjie@huawei.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230817_030745_687582_20020894 X-CRM114-Status: GOOD ( 17.74 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Aug 17, 2023 at 03:19:41PM +0800, Ruan Jinjie wrote: > Use IS_ERR_OR_NULL() instead of open-coding it > to simplify the code. > > Signed-off-by: Ruan Jinjie > --- > drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c > index 733b5e900817..fe2452a70d23 100644 > --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c > +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c > @@ -1165,7 +1165,7 @@ static int stmmac_init_phy(struct net_device *dev) > /* Some DT bindings do not set-up the PHY handle. Let's try to > * manually parse it > */ > - if (!phy_fwnode || IS_ERR(phy_fwnode)) { > + if (IS_ERR_OR_NULL(phy_fwnode)) { > int addr = priv->plat->phy_addr; > struct phy_device *phydev; Up to the stmmac maintainers, but I have never been a fan of "IS_ERR_OR_NULL" because it leads to programming errors such as those I pointed out in your changes to I2C drivers. I would much rather see IS_ERR_OR_NULL removed from the kernel entirely. That is my personal opinion. In this case, it doesn't matter because we're not returning the phy_fwnode error, we're detecting it and taking some alternative action - but given my inherent dislike of IS_ERR_OR_NULL, I prefer the original. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last! _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel