From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9D00DC3DA4E for ; Thu, 17 Aug 2023 16:22:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:CC:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=nnBaQyaR4XzuXc3sFLLSnfHsI2hhYbJrPpmGm4eKzvg=; b=MXRFpV2dk1gpel Q2CPCVMffr04U0Ugcvn/GkJk1Xrrxr0WEELfjBGHC0p/0zq7S3HJ3CN9C9GcLiso1jZX9EUtEINlc /yWNPWQCoF+XBnl35/yybt4RDf799emRdlXeju38l5HhxVHj84O6I8XaZtVsyIKbm2Xxs43WpNc76 ocUIcT+eksw1KzeNiZAW9LHzS1pGs+2IGiTI7FfvggN8PHmsGtCSkKAjSrWfDZW0LLuGSvicQU4x/ SsDn3iVRQ7/B74GgRq8vqT8V1voZdv53/Bf3OX4++9VaOiCb0PrdXfCe6Y0K9rZZZ7jCSFRzpFP0Z Kdw0bf1xnbGcm3dTrfdw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qWfkZ-006mBG-1P; Thu, 17 Aug 2023 16:21:31 +0000 Received: from mail-co1nam11on20627.outbound.protection.outlook.com ([2a01:111:f400:7eab::627] helo=NAM11-CO1-obe.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qWfkW-006mAR-1v for linux-arm-kernel@lists.infradead.org; Thu, 17 Aug 2023 16:21:29 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=DZ5jKqMl0kYwkrxYy72LW6gB0OjYqDUbbVw0J2qBpduyGYSimvXIEGrTIuPorp5SMuWlRvPy7pOA0jVpWM9n/1brHmJfug7Yar6BBXZQCC7lK0bnPTposYFdT2Gqa7Y4Uk/9ytoooA6QR20EeiiYmhQptove6/wmTeE+DR+58uiu55K7TeqPmRdK8A+etnec9wwIRFj780w0OBPmd+wdaC9tpcjdenQS8tpJ9EZX1qe5zotGQ6ZIbkD017VkZCE6nZNc6Ce6c95TPSJ2Wi3K5zeEaJjjGJKK/HCELmP8G+ap8HjrITadizb+3TF7vj/XfBGXba6LB4oU3x1QHlQnzA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=CmQqgyWurG+SrUt5LwoJlQQ5Cq4MlBa3kzl+yj/bhHs=; b=YprK80OdK7VfoMP1Z6Hs+/JaK2AzGxcTvJtzgoD/XihDNTCKU5N1ZFHHLPR0vUxoV33uXlLBBvfpFjR00+2Fs4lrgOSnlePccZDm7a6MX3AZwLG9wmLxGo1gpOshwvajve8CKPH+IaKTJrRQJU5vfWgY+uZ4UIybTERFazb8OWlaV+Z6C63uALD4lchYYHnff7gCZ5zNyNiJ6LE4vKQ3GkEcz4jwY/AndzG0UWV+21UqkbT1OyW0X2solNfFwPzI4k4To7mNDEbWDi+S39fGea7ID3gV5By8DISyy1QICQfRNjCBJESToVAnSwDKGPKz79ZT7F9BJaNKB8LS7qcC8A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.161) smtp.rcpttodomain=google.com smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=CmQqgyWurG+SrUt5LwoJlQQ5Cq4MlBa3kzl+yj/bhHs=; b=RZAFWRF7zDgVXLUIseA4B/lMCVX5Wse3qfVC5bmq8g34bqxnE4OAuXhw/bHpPzajuMjZ3x8Bf9Bm/WsppGexCCWDs+Me3AgeSIkbpNUw28AQcXdH3+IaFS9Nz69+cXP8MGnlbHU+h4UXW51ytEvBneVRBpOsFtvxHLY4zhGSKuWduVI98EXRIfNhDtwBz2xikIJSTsPi7so3giJqJ/cHdKd9VZT1YV1dS4zvblHmncimwCFy+/MA5WojVzTUcGa8nd2ECbljujnQU3KvGMYbTwNXP6kFMO0SV1Je2PWU6X1fhjteqboKkJ/bkGBrli6w50SUSlNnwwEG+ckpZGtx7Q== Received: from DS7PR05CA0104.namprd05.prod.outlook.com (2603:10b6:8:56::16) by PH7PR12MB8154.namprd12.prod.outlook.com (2603:10b6:510:2b9::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6678.26; Thu, 17 Aug 2023 16:21:20 +0000 Received: from CY4PEPF0000EDD4.namprd03.prod.outlook.com (2603:10b6:8:56:cafe::bf) by DS7PR05CA0104.outlook.office365.com (2603:10b6:8:56::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6723.6 via Frontend Transport; Thu, 17 Aug 2023 16:21:20 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.161) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.161 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.161; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.161) by CY4PEPF0000EDD4.mail.protection.outlook.com (10.167.241.208) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6699.14 via Frontend Transport; Thu, 17 Aug 2023 16:21:20 +0000 Received: from rnnvmail204.nvidia.com (10.129.68.6) by mail.nvidia.com (10.129.200.67) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.5; Thu, 17 Aug 2023 09:21:09 -0700 Received: from rnnvmail202.nvidia.com (10.129.68.7) by rnnvmail204.nvidia.com (10.129.68.6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.37; Thu, 17 Aug 2023 09:21:09 -0700 Received: from Asurada-Nvidia (10.127.8.10) by mail.nvidia.com (10.129.68.7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.37 via Frontend Transport; Thu, 17 Aug 2023 09:21:08 -0700 Date: Thu, 17 Aug 2023 09:21:07 -0700 From: Nicolin Chen To: Michael Shavit CC: , Jason Gunthorpe , "Jean-Philippe Brucker" , Joerg Roedel , Lu Baolu , Robin Murphy , Tomas Krcka , Will Deacon , Yicong Yang , , Subject: Re: [PATCH] iommu/arm-smmu-v3: Simplify stage selection logic Message-ID: References: <20230818000321.1.Ibca43cc8d1bcad3ac3deef5726b9745128aea634@changeid> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230818000321.1.Ibca43cc8d1bcad3ac3deef5726b9745128aea634@changeid> X-NV-OnPremToCloud: ExternallySecured X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CY4PEPF0000EDD4:EE_|PH7PR12MB8154:EE_ X-MS-Office365-Filtering-Correlation-Id: 1f8210e2-6945-49fd-371d-08db9f3dfdc1 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: A7LOV9Er1a5zJnTDJB8XQhtycDTDEXQpLcxK5iG9gi2lJt9bUZ+KN3ILF6w1AinnShUBgG1eEqxs7EOomGJwhmisxg90I4zeNhPU/A9SsBqa2ETvMkI692mwiRKQryEvu6HD1vvjGpXHaQCZDKatL6wnXGldn9ecyaCkPl9+dldH4sEnJCKyxyRTIVTr6y0cNqPkElRAq4Cu5fyH/+g1dLpuFSfme1PvhgrjEQgFQP1B1/5CqY08Go3ndeYVPTD86Wl7ulkdwVYV9fT+r6Y2iAm+ejCGRR3PbzD0W2zEFVbwNJRsOs/3VJxX1OMNQR/Xqbrls+eI3EUXUM2xPhKCHsrN1SnanBKqxufLHiMmp22+KE0XHJwEZRTolkDO1IEbpOMKNGSiKgYRmoshQ4c5I34w7n2IE1wGHmr3+AECQ/pajNPnAMeMGMjT/vWx/w8yT/kNPeP1JwVJCKxxa6+Qbu0Rem7HjYpMJq7Hyfr2nQto/a/3culprG+3whOXZVyneiQNyNhQXlokUxS0lbW+39wMrFBNpnP1rw2wYWKOIaQWaoakq1MY7uhJ8Z+RokK5t2nf0yaw1BggLdTvV6UlFhb2Ai8UZk5nZb6xA6Ga2nhuTjqTVE2M5CYIpzQaejJcd0YDHJY4sye77u91rwtdnbYNHr10EzYgiBAbIqvpQJiwZPvGEuCVvD0PyrRcQeLlr3wntKiNRMkR0NaDoyasG861Uuc4scwMdjX8qdVNzPbf3X+Hp+1f0NNPKp+kz7uV X-Forefront-Antispam-Report: CIP:216.228.117.161;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:mail.nvidia.com;PTR:dc6edge2.nvidia.com;CAT:NONE;SFS:(13230031)(4636009)(136003)(376002)(39860400002)(396003)(346002)(186009)(451199024)(1800799009)(82310400011)(46966006)(40470700004)(36840700001)(2906002)(40460700003)(4744005)(26005)(86362001)(7416002)(40480700001)(336012)(478600001)(426003)(9686003)(55016003)(5660300002)(36860700001)(41300700001)(82740400003)(356005)(7636003)(54906003)(316002)(70586007)(70206006)(6916009)(4326008)(8676002)(8936002)(33716001)(47076005);DIR:OUT;SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Aug 2023 16:21:20.0614 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 1f8210e2-6945-49fd-371d-08db9f3dfdc1 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a;Ip=[216.228.117.161];Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: CY4PEPF0000EDD4.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR12MB8154 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230817_092128_709022_196B4D35 X-CRM114-Status: UNSURE ( 9.57 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Aug 18, 2023 at 12:03:30AM +0800, Michael Shavit wrote: > It is invalid for an arm-smmu-v3 to have neither FEAT_TRANS_S1 nor > FEAT_TRANS_S2 bits set, and this is even checked in the probe. > > Only set ARM_SMMU_DOMAIN_S2 if FEAT_TRANS_S1 isn't supported, otherwise set > ARM_SMMU_DOMAIN_S1. This is clearer as the existing code implies that > something more sophisticated is going on with the stage selection logic. > > Signed-off-by: Michael Shavit Reviewed-by: Nicolin Chen _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel