From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 08FE8C001DE for ; Fri, 18 Aug 2023 07:24:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=WIFImMnLtFJ1QJfsYAeQcRRfccKa3nNI1FU1for7wCQ=; b=anp9iRHzQAx1/9 mo0EcVyADb3swKlt5fIc8HJgxpbR1umebLP+oCQGzwrxls+9J1VHqgs6mdpZu2g+2PwfH9Wy2Jqx1 1hqrjg1P2QFen3Nz25MtjLol4LzGL9I9dXM46FEK7roAuoVL9iYhUzYEV+hW1H0v/xUXQMdnzSno+ Sp5Sx/qcUZRUqxBvpkFKJUCQyk2g6j1mHGLzrrK+GzkOP/eMEBGe1Rox6ULBJh1nZQZ9y9oLpoWee zRuWH4DBPnni1ry8jhCWwr5bY0GcS8hkjthf4xP6UFXFgGiAdNKC80y9HA3HTsmO1iLcJaEtp/CbC HOVlqbjNsZowgB3g95Rg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qWtpd-007sAn-1x; Fri, 18 Aug 2023 07:23:41 +0000 Received: from mail-lf1-x132.google.com ([2a00:1450:4864:20::132]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qWtpW-007s9y-2k for linux-arm-kernel@lists.infradead.org; Fri, 18 Aug 2023 07:23:39 +0000 Received: by mail-lf1-x132.google.com with SMTP id 2adb3069b0e04-4fe4762173bso814833e87.3 for ; Fri, 18 Aug 2023 00:23:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=resnulli-us.20221208.gappssmtp.com; s=20221208; t=1692343412; x=1692948212; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=+nrlvGLSZrLTAidXKYdnf+IMABQtnX9eIwf7feDIRl4=; b=gUkgEFdIUbCRiIovcKuPSXsz2jIBb04GMmR/D3yc0PsZNNvQX94puOhOfFRBicMod9 FV75KNTBfswt/NUNYIl1BqJy7KRs3S3YAIGngmEcU5TovnqTTcy9aXhsxqPZdIWRXmEM KtbCL3yxYGA+YCAMtZmuqJ1ngjumWyHgt292mGY+f43e/fzIwMte2JtKjLmYORwpgGTC wE0h78ODD3iiAW0fW7CN/SEAWHZdFAWD/BJ3VsOsurCbmh0IhX82V89Gvry5s6dfXWsY UkRy3/h5kT2IwVboIXZHHLuCH3lq20jEzrdr86vQfSmiM5PqstmAICwpAS/ow0JHRMf4 0k8Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1692343412; x=1692948212; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=+nrlvGLSZrLTAidXKYdnf+IMABQtnX9eIwf7feDIRl4=; b=F9mA2uo9P/rLZ7FyVnDofCw/dBJCWag19xRtZzl4ZHHLAh/OQUtKH6masKZ5c7YW7Y tPGn4hmqrPjbASAEU5RqU7TrHGsqZIPF+Sx3sWPTPKu4jhWIX8X6eYP1jE/M67huQf1M hNtPxXO8NjDz5XaRuMqFgzL0ccIAI7GgoOT+IzR5M/ZVmLgIInCuMqq/V0zsacTsrNRO XQFRgOMYkLPLl38LzEGadR0pWJ6UHxIm1No59/HJSK+f9d3+x9oFeG2vSTD+WTpwqkCL XMirD/aAbVIuEPFMn155EX6HrfkF8RFnLtAMTPv8Tp23RVevjoa9AbLNCAyqmzZq4+Dm gS8Q== X-Gm-Message-State: AOJu0YzL/h7k+Kh1Hv9oIBpIL79Xko6CHGBo9A3ZR4HlxGDZCvmgwkqv j9xKvi27ByMk+qFPJI7ygAzMew== X-Google-Smtp-Source: AGHT+IEOeJMn8/EoRozhoQagPj2QryyIspkPS5PyFAvnzRmg9yRI8DoPXKyuJg63xi4Xks3gO4wgAQ== X-Received: by 2002:a05:6512:2356:b0:4ff:6fa3:63ce with SMTP id p22-20020a056512235600b004ff6fa363cemr1126718lfu.10.1692343412057; Fri, 18 Aug 2023 00:23:32 -0700 (PDT) Received: from localhost ([212.23.236.67]) by smtp.gmail.com with ESMTPSA id 16-20020a05600c231000b003fc00212c1esm1882608wmo.28.2023.08.18.00.23.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 18 Aug 2023 00:23:31 -0700 (PDT) Date: Fri, 18 Aug 2023 09:23:30 +0200 From: Jiri Pirko To: Jakub Kicinski Cc: "Kubalewski, Arkadiusz" , Vadim Fedorenko , Jonathan Lemon , Paolo Abeni , "Olech, Milena" , "Michalik, Michal" , "linux-arm-kernel@lists.infradead.org" , poros , mschmidt , "netdev@vger.kernel.org" , "linux-clk@vger.kernel.org" , Bart Van Assche , "intel-wired-lan@lists.osuosl.org" , Jiri Pirko Subject: Re: [PATCH net-next v4 2/9] dpll: spec: Add Netlink spec in YAML Message-ID: References: <20230811200340.577359-1-vadim.fedorenko@linux.dev> <20230811200340.577359-3-vadim.fedorenko@linux.dev> <20230814194336.55642f34@kernel.org> <20230817163640.2ad33a4b@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230817163640.2ad33a4b@kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230818_002335_176531_09C61754 X-CRM114-Status: GOOD ( 14.92 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Fri, Aug 18, 2023 at 01:36:40AM CEST, kuba@kernel.org wrote: >On Thu, 17 Aug 2023 18:40:00 +0000 Kubalewski, Arkadiusz wrote: >> >Why are all attributes in a single attr space? :( >> >More than half of them are prefixed with a pin- does it really >> >not scream to you that they belong to a different space? >> >> I agree, but there is an issue with this, currently: >> >> name: pin-parent-device >> subset-of: dpll >> attributes: >> - >> name: id >> type: u32 >> - >> name: pin-direction >> type: u32 >> - >> name: pin-prio >> type: u32 >> - >> name: pin-state >> type: u32 >> >> Where "id" is a part of device space, rest attrs would be a pin space.. >> Shall we have another argument for device id in a pin space? > >Why would pin and device not have separate spaces? > >When referring to a pin from a "device mostly" command you can >usually wrap the pin attributes in a nest, and vice versa. >But it may not be needed at all here? Let's look at the commands: > >+ - >+ name: device-id-get >+ request: >+ attributes: >+ - module-name >+ - clock-id >+ - type >+ reply: >+ attributes: >+ - id > >All attributes are in "device" space, no mixing. > >+ name: device-get >+ request: >+ attributes: >+ - id >+ reply: &dev-attrs >+ attributes: >+ - id >+ - module-name >+ - mode >+ - mode-supported >+ - lock-status >+ - temp >+ - clock-id >+ - type > >Again, no pin attributes, so pin can be separate? > >+ - >+ name: device-set >+ request: >+ attributes: >+ - id > >Herm, this one looks like it's missing attrs :S > >+ - >+ name: pin-id-get >+ request: >+ attributes: >+ - module-name >+ - clock-id >+ - pin-board-label >+ - pin-panel-label >+ - pin-package-label >+ - pin-type >+ reply: >+ attributes: >+ - pin-id > >Mostly pin stuff. I guess the module-name and clock-id attrs can be >copy/pasted between device and pin, or put them in a separate set >and add that set as an attr here. Copy paste is likely much simpler. Agreed for the copy. Honestly, I wound thing that shared ATTR space is fine for DPLL, the split is an overkill here. But up to you Jakub :) > >+ - >+ name: pin-get >+ request: >+ attributes: >+ - pin-id >+ reply: &pin-attrs >+ attributes: >+ - pin-id >+ - pin-board-label >+ - pin-panel-label >+ - pin-package-label >+ - pin-type >+ - pin-frequency >+ - pin-frequency-supported >+ - pin-dpll-caps >+ - pin-parent-device The ID of device is inside this nest. >+ - pin-parent-pin > >All pin. > >+ - >+ name: pin-set >+ request: >+ attributes: >+ - pin-id >+ - pin-frequency >+ - pin-direction >+ - pin-prio >+ - pin-state >+ - pin-parent-device Same here. >+ - pin-parent-pin > >And all pin. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel