From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1A1BCC04A6A for ; Mon, 7 Aug 2023 10:30:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=jaB0CrG7yNX4Y62l24sWLdyDm1pBVmNnqSHXsHxF7CU=; b=Jy63dp/afuDBSR JfUJDXv4w+8Ie+CzzqC7MwK6830C8PAThm5nHqxZ04AXYahN2rxXneCXMugz4wetXW1bnwiSKfmkX yG/cjSJmBFooEc/8ZN98zTVCYUZXrnQ1GHryBTzbPgM6RIn6Hr/Im33G5S0BK0OGIFx5PlDYe25mM O5eC0WyzTGMWZTMkrNKAyavGQ+zvfGVVocNO/LzXb3OZyFoibMIsdtXAmUUg034ilXNGwcM6Ca3vi aElV5L5JmoA9CVBSx/bIUAvgxFf8pIf7D3Bj0sInVHIw55IcnPxBd/YfyCKA3qxcm7+qVufR4j0Ex Q/MXUzKTI/dOTsP815Xg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qSxV0-00Gpqu-2S; Mon, 07 Aug 2023 10:30:06 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qSxUx-00GpnU-18 for linux-arm-kernel@lists.infradead.org; Mon, 07 Aug 2023 10:30:04 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 996E91FB; Mon, 7 Aug 2023 03:30:44 -0700 (PDT) Received: from FVFF77S0Q05N.cambridge.arm.com (FVFF77S0Q05N.cambridge.arm.com [10.1.32.139]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id CD54B3F59C; Mon, 7 Aug 2023 03:29:58 -0700 (PDT) Date: Mon, 7 Aug 2023 11:29:56 +0100 From: Mark Rutland To: Douglas Anderson Cc: Catalin Marinas , Will Deacon , Sumit Garg , Daniel Thompson , Marc Zyngier , linux-perf-users@vger.kernel.org, ito-yuichi@fujitsu.com, Chen-Yu Tsai , Ard Biesheuvel , Stephen Boyd , Peter Zijlstra , Thomas Gleixner , linux-arm-kernel@lists.infradead.org, kgdb-bugreport@lists.sourceforge.net, Masayoshi Mizuma , "Rafael J . Wysocki" , Lecopzer Chen , Jason Wessel , linux-kernel@vger.kernel.org Subject: Re: [PATCH v9 6/7] kgdb: Provide a stub kgdb_nmicallback() if !CONFIG_KGDB Message-ID: References: <20230601213440.2488667-1-dianders@chromium.org> <20230601143109.v9.6.Ia3aeac89bb6751b682237e76e5ba594318e4b1aa@changeid> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230807_033003_443197_FC4831CE X-CRM114-Status: GOOD ( 11.69 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Aug 07, 2023 at 11:27:00AM +0100, Mark Rutland wrote: > On Thu, Jun 01, 2023 at 02:31:50PM -0700, Douglas Anderson wrote: > > +static inline int kgdb_nmicallback(int cpu, void *regs) { return 1; } > > Is '1' an error? > > Can we return an actual error code if so? It makes it *much* clearer to anyone > looking at the code. Never mind; I see this was already queued. Sorry for the noise. Thanks, Mark. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel