Re: [PATCH 00/16] mmc: sdhci-pltfm: Minor clean up

From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Adrian Hunter <adrian.hunter@intel.com>
Cc: "Ulf Hansson" <ulf.hansson@linaro.org>,
	"Kunihiko Hayashi" <hayashi.kunihiko@socionext.com>,
	"Al Cooper" <alcooperx@gmail.com>,
	"Li Zetao" <lizetao1@huawei.com>,
	"Alexandre Belloni" <alexandre.belloni@bootlin.com>,
	"Brad Larson" <blarson@amd.com>,
	"Swati Agarwal" <swati.agarwal@amd.com>,
	linux-kernel@vger.kernel.org,
	"Sai Krishna Potthuri" <sai.krishna.potthuri@amd.com>,
	"Jiapeng Chong" <jiapeng.chong@linux.alibaba.com>,
	"Florian Fainelli" <florian.fainelli@broadcom.com>,
	"Steen Hegelund" <Steen.Hegelund@microchip.com>,
	"Brian Norris" <briannorris@chromium.org>,
	"Broadcom internal kernel review list"
	<bcm-kernel-feedback-list@broadcom.com>,
	linux-arm-kernel@lists.infradead.org,
	"Ye Xingchen" <ye.xingchen@zte.com.cn>,
	"Patrice Chotard" <patrice.chotard@foss.st.com>,
	"Kamal Dasu" <kamal.dasu@broadcom.com>,
	"Doug Brown" <doug@schmorgal.com>,
	"Daniel Machon" <daniel.machon@microchip.com>,
	"Yangtao Li" <frank.li@vivo.com>, "Ray Jui" <rjui@broadcom.com>,
	"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
	"Eugen Hristev" <eugen.hristev@collabora.com>,
	"Jassi Brar" <jaswinder.singh@linaro.org>,
	"Christophe JAILLET" <christophe.jaillet@wanadoo.fr>,
	"Georgii Kruglov" <georgy.kruglov@yandex.ru>,
	"Michal Simek" <michal.simek@amd.com>,
	"Lars Povlsen" <lars.povlsen@microchip.com>,
	"Andy Tang" <andy.tang@nxp.com>,
	"Scott Branden" <sbranden@broadcom.com>,
	linux-mmc@vger.kernel.org, UNGLinuxDriver@microchip.com,
	"Claudiu Beznea" <claudiu.beznea@microchip.com>
Subject: Re: [PATCH 00/16] mmc: sdhci-pltfm: Minor clean up
Date: Fri, 11 Aug 2023 16:42:34 +0300	[thread overview]
Message-ID: <ZNY6yuLTjW/cHioP@smile.fi.intel.com> (raw)
In-Reply-To: <20230811130351.7038-1-adrian.hunter@intel.com>

On Fri, Aug 11, 2023 at 04:03:35PM +0300, Adrian Hunter wrote:
> Hi
> 
> sdhci_pltfm_unregister() does:
> 
> 	clk_disable_unprepare(pltfm_host->clk)
> 
> which prevents drivers from using devm_clk_get_enabled() or similar.
> 
> Move it out, and where drivers are doing devm_clk_get*() immediately
> followed by clk_prepare_enable(), combine them into devm_clk_get_*enabled().
> 
> sdhci_pltfm_register() and sdhci_pltfm_unregister() are not paired functions.
> That are just helpers and effectively get renamed:
> 
> 	sdhci_pltfm_register() -> sdhci_pltfm_init_and_add_host()
> 	sdhci_pltfm_unregister() -> sdhci_pltfm_remove()
> 
> Please note, the patches are based on top of some 
> "Convert to platform remove callback returning void"
> patches by Yangtao Li, which were posted here:
> 
> 	https://lore.kernel.org/linux-mmc/20230727070051.17778-1-frank.li@vivo.com/
> 
> Patches can also be found here:
> 
> 	https://github.com/ahunter6/linux/commits/sdhci-pltfm-cleanup-1

All look good to me, thanks!
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>

> Adrian Hunter (16):
>       mmc: sdhci-pltfm: Add sdhci_pltfm_remove()
>       mmc: sdhci-bcm-kona: Use sdhci_pltfm_remove()
>       mmc: sdhci-brcmstb: Use sdhci_pltfm_remove()
>       mmc: sdhci-cadence: Use sdhci_pltfm_remove()
>       mmc: sdhci-dove: Use sdhci_pltfm_remove()
>       mmc: sdhci_f_sdh30: Use sdhci_pltfm_remove()
>       mmc: sdhci-iproc: Use sdhci_pltfm_remove()
>       mmc: sdhci-of-arasan: Use sdhci_pltfm_remove()
>       mmc: sdhci-of-at91: Use sdhci_pltfm_remove()
>       mmc: sdhci-of-esdhc: Use sdhci_pltfm_remove()
>       mmc: sdhci-of-hlwd: Use sdhci_pltfm_remove()
>       mmc: sdhci-of-sparx5: Use sdhci_pltfm_remove()
>       mmc: sdhci-pxav2: Use sdhci_pltfm_remove()
>       mmc: sdhci-st: Use sdhci_pltfm_remove()
>       mmc: sdhci-pltfm: Remove sdhci_pltfm_unregister()
>       mmc: sdhci-pltfm: Rename sdhci_pltfm_register()
> 
>  drivers/mmc/host/sdhci-bcm-kona.c  | 12 +++++++++++-
>  drivers/mmc/host/sdhci-brcmstb.c   | 18 +++++-------------
>  drivers/mmc/host/sdhci-cadence.c   | 17 ++++-------------
>  drivers/mmc/host/sdhci-dove.c      |  8 ++------
>  drivers/mmc/host/sdhci-iproc.c     | 14 +++-----------
>  drivers/mmc/host/sdhci-of-arasan.c |  4 +++-
>  drivers/mmc/host/sdhci-of-at91.c   |  2 +-
>  drivers/mmc/host/sdhci-of-esdhc.c  |  2 +-
>  drivers/mmc/host/sdhci-of-hlwd.c   |  4 ++--
>  drivers/mmc/host/sdhci-of-sparx5.c | 17 ++++++-----------
>  drivers/mmc/host/sdhci-pltfm.c     | 14 ++++++--------
>  drivers/mmc/host/sdhci-pltfm.h     |  8 ++++----
>  drivers/mmc/host/sdhci-pxav2.c     | 19 ++++++-------------
>  drivers/mmc/host/sdhci-st.c        |  4 +++-
>  drivers/mmc/host/sdhci_f_sdh30.c   |  2 +-
>  15 files changed, 58 insertions(+), 87 deletions(-)
> 
> 
> Regards
> Adrian

-- 
With Best Regards,
Andy Shevchenko

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel