From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 59080C0015E for ; Sat, 12 Aug 2023 06:20:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=VFaRmZNIhs8l1M8tHedI2oIMu5DARUVYZiUec62NN/c=; b=UyfcrBLqTLB/61 7SI2GcV4fm/9Yduw1f9VaKJdBGWvOpMXRX9WtTJUebqt9NJPZgQIlbDy6QS1hVGJ3hqXpcEnNXfF+ t62te1M+HYoqBmWtNmcUYjZBO0GwtqfGaouk4DiOHcyrvXtv5It6/etpWhafWuVlSprSyyvnwO3+O LfmslpSJWLG26KAd+rEWTlS5kwpgikV2Txi3M8zF8PU6BOAJWF6TDsVdE2OAYhIH/7tIO/XenJDOc rQlOhxp8wcdqfP4Dur+LgKUdofRWMrK07rx0l49p76cqSn6jivZBzfvOc/UqU/blNCRqIjG/WfDcf +LZm3VbO6jg2Kgxkr2tQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qUhyb-00Cm3r-2O; Sat, 12 Aug 2023 06:19:53 +0000 Received: from mail-ej1-x633.google.com ([2a00:1450:4864:20::633]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qUhyY-00Cm35-00 for linux-arm-kernel@lists.infradead.org; Sat, 12 Aug 2023 06:19:52 +0000 Received: by mail-ej1-x633.google.com with SMTP id a640c23a62f3a-99c1d03e124so339591866b.2 for ; Fri, 11 Aug 2023 23:19:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=resnulli-us.20221208.gappssmtp.com; s=20221208; t=1691821187; x=1692425987; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=TjmLF1rO5TorvHBy4pxrBOw1UIR+s/EKu3iHtx+Nh50=; b=P+eORdmHrfUq0eOC5J81tYaBqXZES0VMhvt28KeKlsdwVdQpvsQD5ws3OtjN61fsgW LVoGtSoX3FefyuQTIaB8zYNKuSxbNG7Kj9xVwmjUNjHhDFvIEpmCafNB8KvndOfaHzFh 6HOAOEQ/SJPuUqYcxHwe08SPbR8UNlIIZAEqiZj9YHsM1LzV6oYVfpwyJcb7x6BH49np jP1vDVspTKKs8a75LKKcYQbm7izz/USlZJCDuZi0tdgAVHZlT8TGB4+gRbN9bw7qmYMW u29Een9xQ3Xiq2P5NnCv95RmRDSHakE1P9iAWWH2Zb9z7WLal0BcUGtiHHfqqri66zI5 uQ5w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691821187; x=1692425987; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=TjmLF1rO5TorvHBy4pxrBOw1UIR+s/EKu3iHtx+Nh50=; b=koRUH6y6mIJCb5qHI1THVxoZAdzEFPU/Qtz0Iqgr94pq55VawFz/jv9faLHzZje7Rn HmmCZlz1Dpv7BRqaYcGHe07Wm7oWpj7HwLQqBxrHLwxuReFEQ/nUVOtRvyon9rjaEMDU HpVVpNldc7wznokhab8RamgJkNPX86KqBfU7AH+LSuobhygq3cgFgqhNs1WVEZnyZUKY /IsPXnuXuAs75ZB7POlAcZHFoLyWIlOxwA4va2pwOG35nKdmVcLCDbtnYyJE3/s1T/A7 S+DnsKpQppI8sK1mtuG8SPAwbhNU8mHe+6yy70xjPFymjU/WCPvmn3SUlLGda8FswG8w h2ug== X-Gm-Message-State: AOJu0Yy+hcmWc4tuDyoGk7Ywf2KWYqqnGRzcK/YjsmiV0cURBa4S2gdY ++ws9/hPArUOQmRRMy6QUvg/gQ== X-Google-Smtp-Source: AGHT+IEPlIXz5uM26zKwi4mc++wqqZbRXc7W1xYTx2DsLMBRS7DeeCnK6XHSPYqBnlnaUBHaDTo/VQ== X-Received: by 2002:a17:907:7859:b0:994:4e9c:30c6 with SMTP id lb25-20020a170907785900b009944e9c30c6mr3096190ejc.57.1691821186721; Fri, 11 Aug 2023 23:19:46 -0700 (PDT) Received: from localhost ([212.23.236.67]) by smtp.gmail.com with ESMTPSA id g18-20020a1709067c5200b0099316c56db9sm3059967ejp.127.2023.08.11.23.19.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 11 Aug 2023 23:19:46 -0700 (PDT) Date: Sat, 12 Aug 2023 08:19:45 +0200 From: Jiri Pirko To: Vadim Fedorenko Cc: Jakub Kicinski , Arkadiusz Kubalewski , Jonathan Lemon , Paolo Abeni , Milena Olech , Michal Michalik , linux-arm-kernel@lists.infradead.org, poros@redhat.com, mschmidt@redhat.com, netdev@vger.kernel.org, linux-clk@vger.kernel.org, Bart Van Assche , intel-wired-lan@lists.osuosl.org, Jiri Pirko Subject: Re: [PATCH net-next v4 7/9] ice: implement dpll interface to control cgu Message-ID: References: <20230811200340.577359-1-vadim.fedorenko@linux.dev> <20230811200340.577359-8-vadim.fedorenko@linux.dev> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230811200340.577359-8-vadim.fedorenko@linux.dev> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230811_231950_252584_F87569F4 X-CRM114-Status: UNSURE ( 8.88 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Fri, Aug 11, 2023 at 10:03:38PM CEST, vadim.fedorenko@linux.dev wrote: [...] >@@ -4690,6 +4694,8 @@ static void ice_deinit_features(struct ice_pf *pf) > ice_gnss_exit(pf); > if (test_bit(ICE_FLAG_PTP_SUPPORTED, pf->flags)) > ice_ptp_release(pf); >+ if (test_bit(ICE_FLAG_DPLL, pf->flags)) This is a duplicate test as you test it as a first thing in ice_dpll_deinit(). But nevermind this nit, let's have v4 merged if possible. >+ ice_dpll_deinit(pf); > } > > static void ice_init_wakeup(struct ice_pf *pf) >-- >2.27.0 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel