From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9799EC001DB for ; Sun, 13 Aug 2023 04:24:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=CQeQI0roUD5pxqJQc95DbfG8PmIG5KJg2ghRiLkxA4M=; b=YU3r95S0HytfSL dF4aIwBiVm01IZPcOOE66YEdE8uj5tKD85NIqJMyYFcYsiejweMzKzZ//+m280YNwvih0C59yfLYt fLfuhkwPdlvRLfDrXvNb49TvQbcWmlc4S1R+Jw1CF+Zqf+8ucX9jkn6B4/S1RmlabwrHweT5y7mlB NKtRg0R3HZAE1XzBbjtrKy45FTiiR60re1M4Fko8QhGFTowVzlwS/Lo37Wo9AcNct3hDeLlsz6Lge deBhM8tynrvwB4tiiViLBm+j0N9/Or38jlSQmxpwwKVU97yhxOqMg2EnlhplalHjtrWV9UmpgBcEy 9fBiGbHu5/fmNJl+2UDQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qV2e6-00ERkT-0W; Sun, 13 Aug 2023 04:24:06 +0000 Received: from out-117.mta1.migadu.com ([95.215.58.117]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qV2e3-00ERi0-0q for linux-arm-kernel@lists.infradead.org; Sun, 13 Aug 2023 04:24:04 +0000 Date: Sun, 13 Aug 2023 14:23:23 +1000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=jookia.org; s=key1; t=1691900622; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=a6J4O4LcgB0OvYhD9lsAZN0hjV+jYfip4h50cDdtwXM=; b=rVBhQaLLGPc/hJvDQWXmWex9rEukDK7PwJImulIVytTKqLck/I3R6y9nlyEyvADT9RWl6X +VxaxBClb+sTt5ZPIP0lKXHybhiZaZrez04tQyrqu8zeSSayPCxU82o80rG7MfikOgLW8k BuvyNjZYuR/TNHeBx6ER2XBiQb7rgab5aU2wz35zbz7b9ALUJW9fqf6I51foFfFBkjAXcX CiIONMTYk7ZycnK+dmm/Ex0GC4VnP1MyUbdtu38lnvuY+/lpQV7acfjg1THU3Z2jstbUYg SYXdL44Fym4wk1gzUBET2HWn4pGvLnkhIoh7c6RzFLlQ/Oj7ozQHOgrWAEiKqw== X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: John Watts To: Chen-Yu Tsai Cc: linux-sunxi@lists.linux.dev, Rob Herring , Krzysztof Kozlowski , Conor Dooley , Paul Walmsley , Palmer Dabbelt , Albert Ou , Jernej Skrabec , Samuel Holland , Maksim Kiselev , Marc Kleine-Budde , Cristian Ciocaltea , devicetree@vger.kernel.org, linux-riscv@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3] riscv: dts: allwinner: d1: Add CAN controller nodes Message-ID: References: <20230807191952.2019208-1-contact@jookia.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-Migadu-Flow: FLOW_OUT X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230812_212403_475068_F532C52E X-CRM114-Status: GOOD ( 20.19 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sun, Aug 13, 2023 at 12:17:27PM +0800, Chen-Yu Tsai wrote: > > Signed-off-by: John Watts > > --- > > Changes in v3: > > - Set default pinctrl for can controller > > - Moved can nodes to proper location > > - Moved can pins to proper location > > > > .../boot/dts/allwinner/sunxi-d1s-t113.dtsi | 34 +++++++++++++++++++ > > 1 file changed, 34 insertions(+) > > > > diff --git a/arch/riscv/boot/dts/allwinner/sunxi-d1s-t113.dtsi b/arch/riscv/boot/dts/allwinner/sunxi-d1s-t113.dtsi > > index d59b4acf183a..24f2e70d5886 100644 > > --- a/arch/riscv/boot/dts/allwinner/sunxi-d1s-t113.dtsi > > +++ b/arch/riscv/boot/dts/allwinner/sunxi-d1s-t113.dtsi > > @@ -52,6 +52,18 @@ pio: pinctrl@2000000 { > > #gpio-cells = <3>; > > #interrupt-cells = <3>; > > > > + /omit-if-no-ref/ > > Just FYI this likely ends up doing nothing if you also have them > referenced through a default pinctrl setting. They end up always > referenced and always included. For the D1 series it looks like no > peripheral has default pinctrl setting given. > > We can still keep it though. It would help when future chip variants > specify different pinmuxes. Oops, thanks for pointing that out. I'll try to avoid that mistake in future. > The compatible string should be the first property. In other sunxi SoC dtsi > files, we put the pinctrl just before the "status" property if it's present > to specify a default pin muxing. Oh that makes sense. > > I can fix it up while applying. Please do! > ChenYu Thanks, John. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel