From: Daniel Golle <daniel@makrotopia.org>
To: Andrew Lunn <andrew@lunn.ch>
Cc: Qingfang Deng <dqfext@gmail.com>,
SkyLake Huang <SkyLake.Huang@mediatek.com>,
Heiner Kallweit <hkallweit1@gmail.com>,
Russell King <linux@armlinux.org.uk>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Matthias Brugger <matthias.bgg@gmail.com>,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org
Subject: Re: [PATCH net-next v2] net: phy: mediatek-ge-soc: support PHY LEDs
Date: Sun, 13 Aug 2023 18:17:11 +0100 [thread overview]
Message-ID: <ZNkQFwvm_sNiVDRO@makrotopia.org> (raw)
In-Reply-To: <9bae16cd-501e-4fe5-9736-d32d958aec7c@lunn.ch>
Hi Andrew,
thank you for reviewing my patch!
On Sun, Aug 13, 2023 at 07:03:21PM +0200, Andrew Lunn wrote:
> Hi Daniel
>
> > This requires syscon phandle 'mediatek,pio' present in parenting MDIO bus
> > which should point to the syscon holding the boottrap register.
>
> If i'm reading the code correct, if this property is missing, the PHY
> will fail to probe? Since this was never a mandatory property, it
> looks like this will break old DT blobs?
As the for-upstream-Linux dtsi for the MediaTek MT7988 SoC is still in
the making there aren't any existing DT blobs we'd want to be compatible
with at this point.
>
> If there are LED properties, then it should be mandatory, otherwise it
> should be optional. That way you keep backwards compatibility with old
> blobs.
Do you still want me to check for the presence of any led properties
before looking for the syscon phandle?
As in: would you like to have it that way anyway even if compatibility
is not an issue?
Cheers
Daniel
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-08-13 17:18 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-13 16:24 [PATCH net-next v2] net: phy: mediatek-ge-soc: support PHY LEDs Daniel Golle
2023-08-13 17:03 ` Andrew Lunn
2023-08-13 17:17 ` Daniel Golle [this message]
2023-08-13 18:51 ` Andrew Lunn
2023-08-13 18:57 ` Andrew Lunn
2023-08-13 19:04 ` Daniel Golle
2023-08-13 19:22 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZNkQFwvm_sNiVDRO@makrotopia.org \
--to=daniel@makrotopia.org \
--cc=SkyLake.Huang@mediatek.com \
--cc=andrew@lunn.ch \
--cc=angelogioacchino.delregno@collabora.com \
--cc=davem@davemloft.net \
--cc=dqfext@gmail.com \
--cc=edumazet@google.com \
--cc=hkallweit1@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux@armlinux.org.uk \
--cc=matthias.bgg@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox