From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 01103C001DE for ; Sun, 13 Aug 2023 17:18:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=m1ZikU+tlByhDQ1v31NsGz5NjYnndP59IwNC7RWcVO4=; b=4ba1aZN/oYqZk4 N33GqTY9NfffgYtUdJVqVzAHXNzldovty/esoOrnViaYJNGi6gVtJWQ3C0g9sZscLg8puxF6IDDux VM5mpc5wdGLeqUKsgFFMoD+yRja+6vO82wDtBKoyhZaiQkCBv7pX60IfAHZt7Ubm3n7NzeeSJjc0b /nliYIQopeUvuLnlDStQ9jd2As7kGKBi7E+aZWISrRZ5OIksQY80zHIuqoGcXWfcAwjoQWGA5zSS8 dqRm1CNVQOwNSB5Q8ipvpJiSRZTJPx2PlrDzrSrXkZ7CxP05mNk8OcErBU/1Joar/LXlrk6bYPz7f +oSYF3wpu8Cd+6s/rXjA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qVEj2-00FVDA-00; Sun, 13 Aug 2023 17:18:00 +0000 Received: from pidgin.makrotopia.org ([185.142.180.65]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qVEiz-00FVCl-13; Sun, 13 Aug 2023 17:17:58 +0000 Received: from local by pidgin.makrotopia.org with esmtpsa (TLS1.3:TLS_AES_256_GCM_SHA384:256) (Exim 4.96) (envelope-from ) id 1qVEim-00009H-1y; Sun, 13 Aug 2023 17:17:44 +0000 Date: Sun, 13 Aug 2023 18:17:11 +0100 From: Daniel Golle To: Andrew Lunn Cc: Qingfang Deng , SkyLake Huang , Heiner Kallweit , Russell King , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Matthias Brugger , AngeloGioacchino Del Regno , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org Subject: Re: [PATCH net-next v2] net: phy: mediatek-ge-soc: support PHY LEDs Message-ID: References: <32e534441225c62e3bf9384b797d9beda7475053.1691943605.git.daniel@makrotopia.org> <9bae16cd-501e-4fe5-9736-d32d958aec7c@lunn.ch> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <9bae16cd-501e-4fe5-9736-d32d958aec7c@lunn.ch> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230813_101757_368639_AE618831 X-CRM114-Status: GOOD ( 16.29 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Andrew, thank you for reviewing my patch! On Sun, Aug 13, 2023 at 07:03:21PM +0200, Andrew Lunn wrote: > Hi Daniel > > > This requires syscon phandle 'mediatek,pio' present in parenting MDIO bus > > which should point to the syscon holding the boottrap register. > > If i'm reading the code correct, if this property is missing, the PHY > will fail to probe? Since this was never a mandatory property, it > looks like this will break old DT blobs? As the for-upstream-Linux dtsi for the MediaTek MT7988 SoC is still in the making there aren't any existing DT blobs we'd want to be compatible with at this point. > > If there are LED properties, then it should be mandatory, otherwise it > should be optional. That way you keep backwards compatibility with old > blobs. Do you still want me to check for the presence of any led properties before looking for the syscon phandle? As in: would you like to have it that way anyway even if compatibility is not an issue? Cheers Daniel _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel