From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DD511C001E0 for ; Mon, 14 Aug 2023 07:55:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=B2zl1ri6ctFf8735EthSWJjrEJk1BelhX3UygoTLD6A=; b=g5eLdhWW2OQnnw kdCTYAWPKKyX/SHM/YyAmOsR/XBwdXkNVZvX4yaxZO/Vgx11jG1yiN7f/DWa/aZFOibz+nY9MFneR NkiclPidhRWeplePvFx1my5+kJFNbzxuysI2k3tK2KLzHpz0w3WbYi15qgzPyhu4ANzW4dPtVQTUC WTdl42V7tz8oMEXZ0cH9F6D2Uxl4s0PTmMwPnuKFUAFepFAl6VvwYFZ2Y9Dlp1H/f2Dvh5z1d9Up6 XMcjolEX/5GB29HIbMUYP0YXUz5uWQ0rnpRTpFVR04N8iXKZGJpRWis+USX5mIx4od3Oe65C0huf0 iK0sBqWleVp0g58cWCCA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qVSPS-00GPw7-1Q; Mon, 14 Aug 2023 07:54:42 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qVSPO-00GPvV-3A for linux-arm-kernel@lists.infradead.org; Mon, 14 Aug 2023 07:54:40 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id AC2072F4; Mon, 14 Aug 2023 00:55:17 -0700 (PDT) Received: from pluto (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 12ABC3F6C4; Mon, 14 Aug 2023 00:54:33 -0700 (PDT) Date: Mon, 14 Aug 2023 08:54:23 +0100 From: Cristian Marussi To: Sibi Sankar Cc: sudeep.holla@arm.com, lukasz.luba@arm.com, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, quic_rjendra@quicinc.com, srinivas.kandagatla@linaro.org, Chandra Sekhar Lingutla Subject: Re: [PATCH] firmware: arm_scmi: Fixup perf microwatt support Message-ID: References: <20230811204818.30928-1-quic_sibis@quicinc.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230811204818.30928-1-quic_sibis@quicinc.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230814_005439_091043_FB6FDEFA X-CRM114-Status: GOOD ( 14.36 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sat, Aug 12, 2023 at 02:18:18AM +0530, Sibi Sankar wrote: > The perf power scale value would currently be reported as bogowatts if the > platform firmware supports microwatt power scale and meets the perf major > version requirements. Fix this by populating version information in the > driver private data before the call to protocol attributes is made. > > CC: Chandra Sekhar Lingutla > Fixes: 3630cd8130ce ("firmware: arm_scmi: Add SCMI v3.1 perf power-cost in microwatts") > Signed-off-by: Sibi Sankar > --- > drivers/firmware/arm_scmi/perf.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > Hi, LGTM. Reviewed-by: Cristian Marussi Thanks, Cristian > diff --git a/drivers/firmware/arm_scmi/perf.c b/drivers/firmware/arm_scmi/perf.c > index c0cd556fbaae..30dedd6ebfde 100644 > --- a/drivers/firmware/arm_scmi/perf.c > +++ b/drivers/firmware/arm_scmi/perf.c > @@ -1080,6 +1080,8 @@ static int scmi_perf_protocol_init(const struct scmi_protocol_handle *ph) > if (!pinfo) > return -ENOMEM; > > + pinfo->version = version; > + > ret = scmi_perf_attributes_get(ph, pinfo); > if (ret) > return ret; > @@ -1104,8 +1106,6 @@ static int scmi_perf_protocol_init(const struct scmi_protocol_handle *ph) > if (ret) > return ret; > > - pinfo->version = version; > - > return ph->set_priv(ph, pinfo); > } > > -- > 2.17.1 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel