From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5E9F6EB64DD for ; Mon, 14 Aug 2023 18:12:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:From:Subject:Message-ID: References:Mime-Version:In-Reply-To:Date:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=ts1sDo/8njpEBeZaaK/v1CKV5SsFGiy9x1XgUIoBAEU=; b=hxCnZszNK8OgShv1yOtn8osutQ Xi1dHteLfSOB2yDBhBF2D0SNbUMZFC2MsJTJwrliE3aVhfBs6armdix8hCTMXYlP5nMgZimqUp9yb 10yo2tpsZIEWRiaTXmvjI6fm+NLHijN3LPmw6A9mAgU7gYHCJ662VYN2MVoOCVb0hZ0iOlnbRpLRa r99OfXRzeK634Kt4P7spGym3W14aF+m67+QfOBmUZhsxCY68pgV7SC3Iz8wffPUCa+YbAIgJcRgK/ GoCzXPVhH3HtwV6YwILj8NWUrm/otZZJ6jqpSAPHRP2evZjE9pLwS4rIA+yac6DeqPpLmGExekqZF TGo2uhrg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qVc2v-0006OO-2G; Mon, 14 Aug 2023 18:12:05 +0000 Received: from mail-pj1-x1049.google.com ([2607:f8b0:4864:20::1049]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qVc2t-0006O1-1j for linux-arm-kernel@lists.infradead.org; Mon, 14 Aug 2023 18:12:04 +0000 Received: by mail-pj1-x1049.google.com with SMTP id 98e67ed59e1d1-26b0c222bbeso4743763a91.2 for ; Mon, 14 Aug 2023 11:12:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20221208; t=1692036721; x=1692641521; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=suQBuyBTpa1Y/bBNer/FTc8YPXcItgJUPYhrGzVVyIE=; b=u+Z2TwuU1JO2bdbYXp/6NZzqfPYs21JT70UjAp5kQjMKOUQuhnsHzmxCOGgsDomWmB sms6CllzH/6L9uNX5b2Qt2qQOkuftV7JcUn+u8Um66WzW9uOECxffazWywUPWpCrrMsz GMTXXvcVtnBM8Lz1yoRWxFk5kG3tFTStf9Z+S7txPrh7A4LWhhMOi0HMiO0wbbX8omEF v4ckzMwerdyD4SYaps1cxR+tCe48l2IIqi3BWRMhbw9sr5++aREFWvM8l1FgL9jGbdOo khys8hyaH7PPIK1BQha1q/qLcOq0IptWxfXgR8q1vLhAKhSNqmw+T8VBuoyi8E5WySIW 9kxQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1692036721; x=1692641521; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=suQBuyBTpa1Y/bBNer/FTc8YPXcItgJUPYhrGzVVyIE=; b=cQ+gfIovpX4yJx+hvkzAw6S4JazMHekuhpQwJhlTHmD1m3Q9dfaShYVkf9z7qQwDN0 bCaTmTi94uyMmmXXNR+0JJhm/ILTjQ57wbSfj2cBfD2D1yD1cCSlkmoJAkPZvGQpgP8h AaTerTDi1vqBYAEpTXXFaViQeZ7ymvFjCNC/3ePgoBZ4K0G1FQg/xWiOAmz2rBL/xKG2 rd7cDlb+mTEivDI2fcoEWlFAVinFRQ0eIWDcTjkzQKQoDVn+4u3O9ODO9JUmNYgf5RWS 0oMSe15NLeCCoAiPF/mhFwcXq0kAwLLAf3/4DPOKdxUqoTWiuVsIYXtJ2A2niW2Y6p2Z Q0rQ== X-Gm-Message-State: AOJu0YyIS6QaKqDRjioNUu0Lo2cZtGigpZoFIKoyk2/Zt+QncsOFwynE R7wMQaXoDENAbFwKxhfaV6jexgw79dU= X-Google-Smtp-Source: AGHT+IG18JOXEV2V0Dd+iEfdRE8/UEWygRGwVjf9lOB8DwoMuDyihgfL+6WHR/4OKZTaFCGMbE/TjH40WZ4= X-Received: from zagreus.c.googlers.com ([fda3:e722:ac3:cc00:7f:e700:c0a8:5c37]) (user=seanjc job=sendgmr) by 2002:a17:90b:8c1:b0:268:553f:1933 with SMTP id ds1-20020a17090b08c100b00268553f1933mr2302283pjb.6.1692036720744; Mon, 14 Aug 2023 11:12:00 -0700 (PDT) Date: Mon, 14 Aug 2023 11:11:59 -0700 In-Reply-To: Mime-Version: 1.0 References: <20230804004226.1984505-1-seanjc@google.com> <20230804004226.1984505-3-seanjc@google.com> Message-ID: Subject: Re: [PATCH 2/4] KVM: selftests: Add helper macros for ioctl()s that return file descriptors From: Sean Christopherson To: Oliver Upton Cc: Marc Zyngier , linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, linux-kernel@vger.kernel.org, Michal Luczaj X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230814_111203_595881_D856E333 X-CRM114-Status: GOOD ( 17.98 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Aug 04, 2023, Sean Christopherson wrote: > On Fri, Aug 04, 2023, Oliver Upton wrote: > > Hi Sean, > > > > On Thu, Aug 03, 2023 at 05:42:24PM -0700, Sean Christopherson wrote: > > > Add KVM, VM, and vCPU scoped helpers for ioctl()s that return file > > > descriptors, i.e. deduplicate code for asserting success on ioctls() for > > > which a positive return value, not just zero, is considered success. > > > > > > Signed-off-by: Sean Christopherson > > > > I appreciate the desire to eliminate duplicate code, but I think the > > naming just muddies the waters. TBH, when I first read the diff w/o the > > changelog, I thought you were describing the input fd (i.e. 'kvm_fd', > > 'vm_fd', 'vcpu_fd'). I don't think explicitly spelling out the condition > > each time (i.e. ret >= 0) is all that difficult. > > Yeah, but it's not just a desire to dedup code, I also am trying to funnel as > many "ioctl() succeeded" asserts as possible into common code so that they naturally > benefit from things like patch 4 (detecting dead/bugged VMs). > > I agree the naming sucks. The best naming scheme I can come up with is to be super literal: kvm_ioctl_non_negative vm_ioctl_non_negative vcpu_ioctl_non_negative If that's still too kludgy and no one has a better idea, I'll just scrap this patch. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel