Re: [PATCH 4/6] dt-bindings: perf: marvell: Add YAML schemas for Marvell Odyssey LLC-TAD pmu

Krzysztof Kozlowski
2023-07-02T09:27:02Z

On 30/06/2023 14:03, Gowthami Thiagarajan wrote:
> Add device tree bindings for Marvell Odyssey LLC-TAD performance
> monitor unit
>
> Signed-off-by: Gowthami Thiagarajan <gthiagarajan@marvell.com>

Please use scripts/get_maintainers.pl to get a list of necessary people
and lists to CC. It might happen, that command when run on an older
kernel, gives you outdated entries. Therefore please be sure you base
your patches on recent Linux kernel.

You missed at least DT list (maybe more), so this won't be tested by our
tools. Performing review on untested code might be a waste of time, thus
I will skip this patch entirely till you follow the process allowing the
patch to be tested.

Please kindly resend and include all necessary To/Cc entries.

> ---
> .../bindings/perf/marvell-odyssey-tad.yaml | 63 +++++++++++++++++++
> 1 file changed, 63 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/perf/marvell-odyssey-tad.yaml
>
> diff --git a/Documentation/devicetree/bindings/perf/marvell-odyssey-tad.yaml b/Documentation/devicetree/bindings/perf/marvell-odyssey-tad.yaml
> new file mode 100644
> index 000000000000..139567166f77
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/perf/marvell-odyssey-tad.yaml

Filename does not match compatible.

> +examples:
> + - |
> +
> + tad {
> + #address-cells = <2>;
> + #size-cells = <2>;
> +
> + tad_pmu@80000000 {

Node names should be generic. See also explanation and list of examples
in DT specification:
https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation

> + compatible = "marvell,odyssey-tad-pmu";
> + reg = <0x87E2 0x2B030000 0x0 0x1000>;

lowercase hex

Best regards,
Krzysztof