From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 42AD3C04A6A for ; Tue, 15 Aug 2023 18:01:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=KQP/RJSoHrf6/CnNTAHIfz1IWUisD225OqihwghJ34Y=; b=VacIVbCBj0kT7O DzYpnTRIk+RPr9dLPzozcSIwgrOdQrD+XVpQeqy9xpdQMtklwAzCePu0TRRuAM7YRiczURKY4CMMN ujk5VJNmeJHwgkezH+WhmlRikqGlherL5b9UqFNryBYQmI5jcNUblDTNZt6mx5uvQLubVXI+gR0aZ Vvlfqlhq3wzfl7LxaooJnvTY9JfS/jaH+/SYYxgdV1vb3RnFYDeiMlOOOFKymhZ+Lp+BCSMCqTt0P QNMsWNwBf7OTd2WFe1Op0OUKIvpdVNmwSCwRyO6cRq6dQXlXO9psaDxlRQ4WDhoS85EQss/jA5zJ+ AXm44xZ5zJ1eaxi0lzaQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qVyLD-0027IH-16; Tue, 15 Aug 2023 18:00:27 +0000 Received: from mail-ed1-x52a.google.com ([2a00:1450:4864:20::52a]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qVyL9-0027Hp-2S for linux-arm-kernel@lists.infradead.org; Tue, 15 Aug 2023 18:00:25 +0000 Received: by mail-ed1-x52a.google.com with SMTP id 4fb4d7f45d1cf-525656acf4bso3163088a12.0 for ; Tue, 15 Aug 2023 11:00:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1692122420; x=1692727220; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:feedback-id:from:to:cc:subject:date :message-id:reply-to; bh=GJHoZ8X1h4xQ7tm8+zzTZx4Mu33LU7nB2/qAWxhLsrU=; b=DvNY5E7BXWahcqxJMVztS4K3eYUTrBJEE84kuaVw/OPWAPesxw2sXnROHQVfuWMqd2 Me1LmCRSLPjppo2fKyjsf/So+ub41pam9MQEhJAgVxkThAfI5zjHxGIys8u2O+zbhkLr SXxbyezvZy9gsU7nZHjZdbi4aoKc+jSE7rRDLN39AIRwo2q35Cl0lwXqFKPMnHqMXIYy 6WF4ocCllgYm6OyhW7iRi6JxT7Ifxys/uu1pYVwK84iTJIKpbpZa/ZM2Ri6qb9BCtcHR ArINKVMlSHKCcOPp1xRQirgO9i4DR9vA9Ynj+UYzJ4QGrJmaXdiO9dSOD4Oho6hzEDgL ymDA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1692122420; x=1692727220; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:feedback-id:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=GJHoZ8X1h4xQ7tm8+zzTZx4Mu33LU7nB2/qAWxhLsrU=; b=BPY3lNYUZCq1X0Qr0OKETpNYMAbQmTpRuH9dps88WYtAiKLahN35FukF+Q0qJhWVtR VOWdyCBPSEA0CRx9+/SswHZeWoyn24nQn7vJ0AOWqgHrUINCYIjdzL/dFUCBN1f2Ld/G 4Jp8oh/jL5h+vmMI9tGyazQSdyXeUkchaLPseNzsY3EfrT9QGbqTyQjGdq7rcxNcDCKQ qiR8/PmSIOaM0bIIp+0kJoRxslZ9/aRXWqy1cZphUKxc4PemmRAOQLYwV1FpNYhOKaoa n25MHp/4DBBKHsZxgVEzexk8tbynnTWpxlH3NdbQm0qh1mShzoOvW9r9a5SFdbA1M3xy awtA== X-Gm-Message-State: AOJu0YzoAglYgMp7RA5Yn90ALANOMPc0ZiDnv7AzWmTRQnS68U9qRIxz h10VEdkBRF5noN0GIEnownA= X-Google-Smtp-Source: AGHT+IHZzOIaP6b1JU7Kcdr9eMRGF33o608qyiE4X2mzVGN+HH+e0rUfhCMANfTYOR0Zf/ncr0vovw== X-Received: by 2002:a05:6402:326:b0:522:2af1:1ffe with SMTP id q6-20020a056402032600b005222af11ffemr10000623edw.9.1692122419926; Tue, 15 Aug 2023 11:00:19 -0700 (PDT) Received: from auth1-smtp.messagingengine.com (auth1-smtp.messagingengine.com. [66.111.4.227]) by smtp.gmail.com with ESMTPSA id l15-20020a056402124f00b005227ead61d0sm7132357edw.83.2023.08.15.11.00.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 15 Aug 2023 11:00:19 -0700 (PDT) Received: from compute6.internal (compute6.nyi.internal [10.202.2.47]) by mailauth.nyi.internal (Postfix) with ESMTP id 5A99927C0054; Tue, 15 Aug 2023 14:00:16 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute6.internal (MEProxy); Tue, 15 Aug 2023 14:00:17 -0400 X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedviedruddtjedguddulecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpeffhffvvefukfhfgggtuggjsehttdertddttddvnecuhfhrohhmpeeuohhq uhhnucfhvghnghcuoegsohhquhhnrdhfvghnghesghhmrghilhdrtghomheqnecuggftrf grthhtvghrnhepveekffduvddtieegveegheelkeetudelieeuvdekledvtefgleeuhefg gfffgedvnecuffhomhgrihhnpehgihhthhhusgdrtghomhdpkhgvrhhnvghlrdhorhhgpd hgihhthhhusghushgvrhgtohhnthgvnhhtrdgtohhmpdgrrghrtghhieeguhhnkhhnohif nhhnohhnvgdrrhhsnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilh hfrhhomhepsghoqhhunhdomhgvshhmthhprghuthhhphgvrhhsohhnrghlihhthidqieel vdeghedtieegqddujeejkeehheehvddqsghoqhhunhdrfhgvnhhgpeepghhmrghilhdrtg homhesfhhigihmvgdrnhgrmhgv X-ME-Proxy: Feedback-ID: iad51458e:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 15 Aug 2023 14:00:15 -0400 (EDT) Date: Tue, 15 Aug 2023 11:00:06 -0700 From: Boqun Feng To: Jamie Cunliffe Cc: catalin.marinas@arm.com, lina@asahilina.net, linux-arm-kernel@lists.infradead.org, ojeda@kernel.org, rust-for-linux@vger.kernel.org, steve.capper@arm.com, will@kernel.org Subject: Re: [PATCH v2 1/3] arm64: rust: Enable Rust support for AArch64 Message-ID: References: <20230612152639.1446766-1-Jamie.Cunliffe@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230815_110023_804179_4B4E4F27 X-CRM114-Status: GOOD ( 25.34 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Jun 29, 2023 at 12:46:13PM -0700, Boqun Feng wrote: > On Mon, Jun 12, 2023 at 04:26:39PM +0100, Jamie Cunliffe wrote: > > > I don't think you need "-fp-armv8" here, because "aarch64-unknown-none" > > > target doesn't have the target-feature "fp-arm64": > > > > > > rustc +1.68.2 --print cfg --target aarch64-unknown-none | grep target_feature > > > > > > target_feature="neon" > > > > > > , and having the "-fp-armv8" gave me a warning at compile time: > > > > > > RUSTC L rust/core.o warning: unknown feature specified for `-Ctarget-feature`: `fp-armv8` > > > | > > > = note: it is still passed through to the codegen backend > > > = help: consider filing a feature request > > > > Rust removed the fp feature for arm64 and tied it with Neon. However > > this initially had a bug that meant it couldn't be disabled. This has > > now been fixed in https://github.com/rust-lang/rust/pull/107294 so > > once we can update rustc we can fix that warning by removing the > > `-fp-armv8`. Until we do that we still need the `-fp-armv8` otherwise > > we will get some floating point usage. This can be seen by doing an > > objdump of core.o if you build after removing the `-fp-armv8`. > > > > Thanks for the information (and the fix)! That's good to know. Looks > like the fix will be in 1.71, then agree, we should keep `-fp-armv8` > until we update to 1.71 or later. > Just FYI, rustc has been bumped to 1.71: https://lore.kernel.org/rust-for-linux/CANiq72mrzALO3J2VvDntscXwt7Z9KzT4+S8sc_HGc8u8izjyLw@mail.gmail.com/ BTW, recently I learned that ARCH is set as "x86" by default even on x86_64 host, so things like: +ifeq ($(ARCH),x86_64) +$(obj)/core.o: scripts/target.json +endif "ifeq .." will return false if compiled with "make LLVM=1" even on a x86_64 host. Maybe use ifdef CONFIG_X86_64 ? Regards, Boqun > Regards, > Boqun > > > > > You can also see that fp-armv8 is enabled in the aarch64-unknown-none target > > here: https://raw.githubusercontent.com/rust-lang/rust/master/compiler/rustc_target/src/spec/aarch64_unknown_none.rs > > > > > > Thanks, > > Jamie. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel