From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 82A79C001E0 for ; Wed, 16 Aug 2023 16:15:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=BDPYIvQ6nNY/J+QWGnZ7lsM/PmFEFbdIsEmL3cXp88k=; b=RTBEVwhW40/YsS 9VZ3NCPu9+DJE6R+kyuLqbpUelN/6MjFzndlfbyICqvy0Ceu1EA/hHCHpb9dUy7Nqo/Znjz33hQpu uRZejn1SS4fxNjI6A1eK4gdCpGMAiu2sWTWI10WoXsAVernIUBmEZpflV139vt0E5Mr6f9wPTc2zn 61jR+Rk+vkxp79GUVzTzSKqq7doqSDeuVedGmihVBto0eacfP0pVXaBfhzPZKtfpMpiJEXsTxj24a SOhuRmfunldKzdcUem4Qd/tcrrhWLHGj3n8b5cwfPH2QkPS6Fpbb7zERijFrWIhB/IIctTvU9f7N7 f1rdm517DxiNKcwZA5HQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qWJBD-004aVV-36; Wed, 16 Aug 2023 16:15:31 +0000 Received: from desiato.infradead.org ([2001:8b0:10b:1:d65d:64ff:fe57:4e05]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qWJBD-004aVM-00 for linux-arm-kernel@bombadil.infradead.org; Wed, 16 Aug 2023 16:15:31 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=srZ4nrIVhTgrqwsQYmvS+/1eqCNjPxvTS7CneGwjXL0=; b=lQ5gMyPyg1/qz64le5W/F4jA0+ 4Z3dUw+rlKe4aUmkmSXpdvG4yosrEvBIromp0Vy7jDKv1vRQpCfI2s57LFc7vKO4kDbX24DL8oyLi O+iErIVXdLj2wMIzLtJS6KBqljL3sCALHUXRY9BGpYyWbHxIhPZs3cE1w7npni/xSRW96RtO8jGqQ RsCPzrJtUDuofV3kUNrTgts4TE7usndLPEkn6xnKNXjVeIjU4exF0Df35TKftJxPtcc4GShW8xUxg gEuwkNrfBRVt1k2aXTuiB5GNIo7c463nwoV4D9dzGU8xmd87Ot6c06DwYciG+6aiGxhn2MSfkNMtp lvBsVkQg==; Received: from [187.19.173.165] (helo=quaco.ghostprotocols.net) by desiato.infradead.org with esmtpsa (Exim 4.96 #2 (Red Hat Linux)) id 1qWJBB-00D76y-16; Wed, 16 Aug 2023 16:15:29 +0000 Received: by quaco.ghostprotocols.net (Postfix, from userid 1000) id EAB1E404DF; Wed, 16 Aug 2023 13:15:24 -0300 (-03) Date: Wed, 16 Aug 2023 13:15:24 -0300 From: Arnaldo Carvalho de Melo To: James Clark Cc: linux-perf-users@vger.kernel.org, irogers@google.com, john.g.garry@oracle.com, renyu.zj@linux.alibaba.com, Will Deacon , Mike Leach , Leo Yan , Peter Zijlstra , Ingo Molnar , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , Adrian Hunter , Kajol Jain , Kan Liang , Haixin Yu , Nick Forrington , Eduard Zingerman , Sohom Datta , Rob Herring , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v6 3/6] perf vendor events arm64: Update scale units and descriptions of common topdown metrics Message-ID: References: <20230816114841.1679234-1-james.clark@arm.com> <20230816114841.1679234-4-james.clark@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230816114841.1679234-4-james.clark@arm.com> X-Url: http://acmel.wordpress.com X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Em Wed, Aug 16, 2023 at 12:47:45PM +0100, James Clark escreveu: > Metrics will be published here [1] going forwards, but they have > slightly different scale units. To allow autogenerated metrics to be > added more easily, update the scale units to match. > > The more detailed descriptions have also been taken and added to the > common file. > > [1]: https://gitlab.arm.com/telemetry-solution/telemetry-solution/-/tree/main/data/pmu/cpu/ This one I had cherry-picked and is already in perf-tools-next, I applied the others locally, will wait till later to see if people ack/object. - Arnaldo > Acked-by: Ian Rogers > Reviewed-by: John Garry > Signed-off-by: James Clark > --- > tools/perf/pmu-events/arch/arm64/sbsa.json | 24 +++++++++++----------- > 1 file changed, 12 insertions(+), 12 deletions(-) > > diff --git a/tools/perf/pmu-events/arch/arm64/sbsa.json b/tools/perf/pmu-events/arch/arm64/sbsa.json > index f90b338261ac..4eed79a28f6e 100644 > --- a/tools/perf/pmu-events/arch/arm64/sbsa.json > +++ b/tools/perf/pmu-events/arch/arm64/sbsa.json > @@ -1,34 +1,34 @@ > [ > { > - "MetricExpr": "stall_slot_frontend / (#slots * cpu_cycles)", > - "BriefDescription": "Frontend bound L1 topdown metric", > + "MetricExpr": "100 * (stall_slot_frontend / (#slots * cpu_cycles))", > + "BriefDescription": "This metric is the percentage of total slots that were stalled due to resource constraints in the frontend of the processor.", > "DefaultMetricgroupName": "TopdownL1", > "MetricGroup": "Default;TopdownL1", > "MetricName": "frontend_bound", > - "ScaleUnit": "100%" > + "ScaleUnit": "1percent of slots" > }, > { > - "MetricExpr": "(1 - op_retired / op_spec) * (1 - stall_slot / (#slots * cpu_cycles))", > - "BriefDescription": "Bad speculation L1 topdown metric", > + "MetricExpr": "100 * ((1 - op_retired / op_spec) * (1 - stall_slot / (#slots * cpu_cycles)))", > + "BriefDescription": "This metric is the percentage of total slots that executed operations and didn't retire due to a pipeline flush.\nThis indicates cycles that were utilized but inefficiently.", > "DefaultMetricgroupName": "TopdownL1", > "MetricGroup": "Default;TopdownL1", > "MetricName": "bad_speculation", > - "ScaleUnit": "100%" > + "ScaleUnit": "1percent of slots" > }, > { > - "MetricExpr": "(op_retired / op_spec) * (1 - stall_slot / (#slots * cpu_cycles))", > - "BriefDescription": "Retiring L1 topdown metric", > + "MetricExpr": "100 * ((op_retired / op_spec) * (1 - stall_slot / (#slots * cpu_cycles)))", > + "BriefDescription": "This metric is the percentage of total slots that retired operations, which indicates cycles that were utilized efficiently.", > "DefaultMetricgroupName": "TopdownL1", > "MetricGroup": "Default;TopdownL1", > "MetricName": "retiring", > - "ScaleUnit": "100%" > + "ScaleUnit": "1percent of slots" > }, > { > - "MetricExpr": "stall_slot_backend / (#slots * cpu_cycles)", > - "BriefDescription": "Backend Bound L1 topdown metric", > + "MetricExpr": "100 * (stall_slot_backend / (#slots * cpu_cycles))", > + "BriefDescription": "This metric is the percentage of total slots that were stalled due to resource constraints in the backend of the processor.", > "DefaultMetricgroupName": "TopdownL1", > "MetricGroup": "Default;TopdownL1", > "MetricName": "backend_bound", > - "ScaleUnit": "100%" > + "ScaleUnit": "1percent of slots" > } > ] > -- > 2.34.1 > -- - Arnaldo _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel