From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 43AD6C001E0 for ; Wed, 16 Aug 2023 15:52:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=TBy2whe4s9+P1WOOlS3lusE8bunoPSvbW45JzlYE7ck=; b=KZzBVLjRFhGvJr o6TgFfMKmxjEWbjRi6tjIxyzmKtwYuAy60rDiXJXihi8q/qkkN+CaziiZaJMNFaBltk4bCFSDipd2 stu1CjhtXC5UObVvNJdA06uk9E5l7WZavTCdVDx9tnvJrHAbq/R41Okj/QV4f+Ds3WS+SjWj6f2RO 8VtlWu7J+LD+/ky0G6rKK/bg85v0J6xvDw1oFvDubbVP9G1ghDyHFT0c9benUsCgv2vBllokw4POh 13DlWUmXGntlDdW9GMRh4ON1+ufthSAsKszg96CllGjmLlKm4oSStrDaOmN/9kpqBkeJABJcGIqxa ENOeVprz+cGDDyXcFyGw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qWIoh-004Xcs-1E; Wed, 16 Aug 2023 15:52:15 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qWIoe-004XcS-39 for linux-arm-kernel@lists.infradead.org; Wed, 16 Aug 2023 15:52:14 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 4FAD061057; Wed, 16 Aug 2023 15:52:12 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 891AEC433C8; Wed, 16 Aug 2023 15:52:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1692201131; bh=TIjmNB9p3Z/mYIestCCsQETqQqkBVHq59rkmx1l98tA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=NmQqVHOpb7712AfKgM+B5SW3Twh3u+wfuMdaMR2kdraPNtxc51ZTVcveQS/KsnlI7 z5d8o/ARnKgq2cHsoOamkNT7PcIXW/dfBNvMYNyE17sOZpCv6JH9zLXj+iR1RzH6sN +10ByFqwsvqIalj7HygKCrPScZ1NhSqy9RBtaYuTNq4Ne4eaw7lf3qy2TR+8Xwdh7q oVzdbYk5sIhqrwe7MxDX8MuALkWgLbeVCqO/RWvXIJpuvPF6YHTuq2MJQE22mCN4LB j7y0XTEuhaZd+4mqnlR5YrS3t/2aTcEC+Wfu0Q2OvoL/FuzYabSBlIEIH4Jsbc0/qn EverZ1UpwQCnw== Date: Wed, 16 Aug 2023 23:40:25 +0800 From: Jisheng Zhang To: "G Thomas, Rohan" Cc: "alexandre.torgue@foss.st.com" , "conor+dt@kernel.org" , "davem@davemloft.net" , "devicetree@vger.kernel.org" , "edumazet@google.com" , "joabreu@synopsys.com" , "krzysztof.kozlowski+dt@linaro.org" , "kuba@kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , "linux-stm32@st-md-mailman.stormreply.com" , "netdev@vger.kernel.org" , "pabeni@redhat.com" , "peppe.cavallaro@st.com" , "robh+dt@kernel.org" Subject: Re: [PATCH net-next v3 03/10] net: stmmac: mdio: enlarge the max XGMAC C22 ADDR to 31 Message-ID: References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230816_085213_076838_40EFF1F6 X-CRM114-Status: GOOD ( 18.24 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sun, Aug 13, 2023 at 02:18:27PM +0000, G Thomas, Rohan wrote: > > On 8/9/23 18:50, Jisheng Zhang wrote: > > The IP can support up to 31 xgmac c22 addresses now. > > > > Signed-off-by: Jisheng Zhang > > --- > > drivers/net/ethernet/stmicro/stmmac/stmmac_mdio.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_mdio.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_mdio.c > > index 3db1cb0fd160..e6d8e34fafef 100644 > > --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_mdio.c > > +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_mdio.c > > @@ -40,7 +40,7 @@ > > #define MII_XGMAC_WRITE (1 << MII_XGMAC_CMD_SHIFT) > > #define MII_XGMAC_READ (3 << MII_XGMAC_CMD_SHIFT) > > #define MII_XGMAC_BUSY BIT(22) > > -#define MII_XGMAC_MAX_C22ADDR 3 > > +#define MII_XGMAC_MAX_C22ADDR 31 > > #define MII_XGMAC_C22P_MASK GENMASK(MII_XGMAC_MAX_C22ADDR, 0) > > #define MII_XGMAC_PA_SHIFT 16 > > #define MII_XGMAC_DA_SHIFT 21 > > Recent commit 10857e677905 ("net: stmmac: XGMAC support for mdio C22 > addr > 3") already addressed this in a different way. As per Synopsis > IP team until version 2.2, XGMAC supports only MDIO devices 0 - 3. An I didn't find your patch in mailist when I submit the v1 on 23 July, in fact my series was earlier than yours. > XGMAC IP version check is newly added for the same reason. I think this > covers your commit also. Please have a look and if so you can drop this > commit. Dropped in new version. > > BR, > Rohan > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel