* Re: [PATCH net-next v3 03/10] net: stmmac: mdio: enlarge the max XGMAC C22 ADDR to 31
[not found] <DM3PR11MB871491A357B9A12BF1B0CC82DE16A@DM3PR11MB8714.namprd11.prod.outlook.com>
@ 2023-08-16 15:40 ` Jisheng Zhang
0 siblings, 0 replies; 3+ messages in thread
From: Jisheng Zhang @ 2023-08-16 15:40 UTC (permalink / raw)
To: G Thomas, Rohan
Cc: alexandre.torgue@foss.st.com, conor+dt@kernel.org,
davem@davemloft.net, devicetree@vger.kernel.org,
edumazet@google.com, joabreu@synopsys.com,
krzysztof.kozlowski+dt@linaro.org, kuba@kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org,
linux-stm32@st-md-mailman.stormreply.com, netdev@vger.kernel.org,
pabeni@redhat.com, peppe.cavallaro@st.com, robh+dt@kernel.org
On Sun, Aug 13, 2023 at 02:18:27PM +0000, G Thomas, Rohan wrote:
>
> On 8/9/23 18:50, Jisheng Zhang wrote:
> > The IP can support up to 31 xgmac c22 addresses now.
> >
> > Signed-off-by: Jisheng Zhang <jszhang@kernel.org>
> > ---
> > drivers/net/ethernet/stmicro/stmmac/stmmac_mdio.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_mdio.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_mdio.c
> > index 3db1cb0fd160..e6d8e34fafef 100644
> > --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_mdio.c
> > +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_mdio.c
> > @@ -40,7 +40,7 @@
> > #define MII_XGMAC_WRITE (1 << MII_XGMAC_CMD_SHIFT)
> > #define MII_XGMAC_READ (3 << MII_XGMAC_CMD_SHIFT)
> > #define MII_XGMAC_BUSY BIT(22)
> > -#define MII_XGMAC_MAX_C22ADDR 3
> > +#define MII_XGMAC_MAX_C22ADDR 31
> > #define MII_XGMAC_C22P_MASK GENMASK(MII_XGMAC_MAX_C22ADDR, 0)
> > #define MII_XGMAC_PA_SHIFT 16
> > #define MII_XGMAC_DA_SHIFT 21
>
> Recent commit 10857e677905 ("net: stmmac: XGMAC support for mdio C22
> addr > 3") already addressed this in a different way. As per Synopsis
> IP team until version 2.2, XGMAC supports only MDIO devices 0 - 3. An
I didn't find your patch in mailist when I submit the v1 on 23 July, in
fact my series was earlier than yours.
> XGMAC IP version check is newly added for the same reason. I think this
> covers your commit also. Please have a look and if so you can drop this
> commit.
Dropped in new version.
>
> BR,
> Rohan
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH net-next v3 00/10] net: stmmac: add new features to xgmac
@ 2023-08-09 16:49 Jisheng Zhang
2023-08-09 16:50 ` [PATCH net-next v3 03/10] net: stmmac: mdio: enlarge the max XGMAC C22 ADDR to 31 Jisheng Zhang
0 siblings, 1 reply; 3+ messages in thread
From: Jisheng Zhang @ 2023-08-09 16:49 UTC (permalink / raw)
To: David S . Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni,
Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Giuseppe Cavallaro, Alexandre Torgue, Jose Abreu
Cc: netdev, linux-kernel, devicetree, linux-stm32, linux-arm-kernel
This series add below new features to xgmac:
correct RX COE parsing
add more feature parsing from hw cap
enlarge C22 ADDR and rx/tx channels
support parse safety ce/ue irq from DT
support per channel irq
Since v2:
- check per channel irq by (res->rx_irq[0] > 0 && res->tx_irq[0] > 0)
rather than (res->rx_irq[0] && res->tx_irq[0])
- bypass if (irq <= 0) when request rx/tx irq
Since v1:
- remove "_irq" suffix from safety irqs dt binding
- remove "snps,per-channel-interrupt" dt binding, check the channel irq
instead.
- more renaming about "msi" to reflect per channel irq isn't MSI
specific
Jisheng Zhang (10):
net: stmmac: correct RX COE parsing for xgmac
net: stmmac: xgmac: add more feature parsing from hw cap
net: stmmac: mdio: enlarge the max XGMAC C22 ADDR to 31
net: stmmac: enlarge max rx/tx queues and channels to 16
net: stmmac: reflect multi irqs for tx/rx channels and mac and safety
net: stmmac: xgmac: support per-channel irq
dt-bindings: net: snps,dwmac: add safety irq support
net: stmmac: platform: support parsing safety irqs from DT
dt-bindings: net: snps,dwmac: add per channel irq support
net: stmmac: platform: support parsing per channel irq from DT
.../devicetree/bindings/net/snps,dwmac.yaml | 37 ++++++++++++
.../net/ethernet/stmicro/stmmac/dwmac-intel.c | 4 +-
.../net/ethernet/stmicro/stmmac/dwmac4_dma.c | 2 +-
.../net/ethernet/stmicro/stmmac/dwxgmac2.h | 5 ++
.../ethernet/stmicro/stmmac/dwxgmac2_core.c | 5 +-
.../ethernet/stmicro/stmmac/dwxgmac2_dma.c | 37 +++++++-----
.../net/ethernet/stmicro/stmmac/stmmac_main.c | 58 ++++++++++---------
.../net/ethernet/stmicro/stmmac/stmmac_mdio.c | 2 +-
.../ethernet/stmicro/stmmac/stmmac_platform.c | 35 +++++++++++
include/linux/stmmac.h | 10 ++--
10 files changed, 142 insertions(+), 53 deletions(-)
--
2.40.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH net-next v3 03/10] net: stmmac: mdio: enlarge the max XGMAC C22 ADDR to 31
2023-08-09 16:49 [PATCH net-next v3 00/10] net: stmmac: add new features to xgmac Jisheng Zhang
@ 2023-08-09 16:50 ` Jisheng Zhang
2023-08-10 13:46 ` Alexandre TORGUE
0 siblings, 1 reply; 3+ messages in thread
From: Jisheng Zhang @ 2023-08-09 16:50 UTC (permalink / raw)
To: David S . Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni,
Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Giuseppe Cavallaro, Alexandre Torgue, Jose Abreu
Cc: netdev, linux-kernel, devicetree, linux-stm32, linux-arm-kernel
The IP can support up to 31 xgmac c22 addresses now.
Signed-off-by: Jisheng Zhang <jszhang@kernel.org>
---
drivers/net/ethernet/stmicro/stmmac/stmmac_mdio.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_mdio.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_mdio.c
index 3db1cb0fd160..e6d8e34fafef 100644
--- a/drivers/net/ethernet/stmicro/stmmac/stmmac_mdio.c
+++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_mdio.c
@@ -40,7 +40,7 @@
#define MII_XGMAC_WRITE (1 << MII_XGMAC_CMD_SHIFT)
#define MII_XGMAC_READ (3 << MII_XGMAC_CMD_SHIFT)
#define MII_XGMAC_BUSY BIT(22)
-#define MII_XGMAC_MAX_C22ADDR 3
+#define MII_XGMAC_MAX_C22ADDR 31
#define MII_XGMAC_C22P_MASK GENMASK(MII_XGMAC_MAX_C22ADDR, 0)
#define MII_XGMAC_PA_SHIFT 16
#define MII_XGMAC_DA_SHIFT 21
--
2.40.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH net-next v3 03/10] net: stmmac: mdio: enlarge the max XGMAC C22 ADDR to 31
2023-08-09 16:50 ` [PATCH net-next v3 03/10] net: stmmac: mdio: enlarge the max XGMAC C22 ADDR to 31 Jisheng Zhang
@ 2023-08-10 13:46 ` Alexandre TORGUE
0 siblings, 0 replies; 3+ messages in thread
From: Alexandre TORGUE @ 2023-08-10 13:46 UTC (permalink / raw)
To: Jisheng Zhang, David S . Miller, Eric Dumazet, Jakub Kicinski,
Paolo Abeni, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Giuseppe Cavallaro, Jose Abreu
Cc: netdev, linux-kernel, devicetree, linux-stm32, linux-arm-kernel
On 8/9/23 18:50, Jisheng Zhang wrote:
> The IP can support up to 31 xgmac c22 addresses now.
>
> Signed-off-by: Jisheng Zhang <jszhang@kernel.org>
> ---
> drivers/net/ethernet/stmicro/stmmac/stmmac_mdio.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_mdio.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_mdio.c
> index 3db1cb0fd160..e6d8e34fafef 100644
> --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_mdio.c
> +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_mdio.c
> @@ -40,7 +40,7 @@
> #define MII_XGMAC_WRITE (1 << MII_XGMAC_CMD_SHIFT)
> #define MII_XGMAC_READ (3 << MII_XGMAC_CMD_SHIFT)
> #define MII_XGMAC_BUSY BIT(22)
> -#define MII_XGMAC_MAX_C22ADDR 3
> +#define MII_XGMAC_MAX_C22ADDR 31
> #define MII_XGMAC_C22P_MASK GENMASK(MII_XGMAC_MAX_C22ADDR, 0)
> #define MII_XGMAC_PA_SHIFT 16
> #define MII_XGMAC_DA_SHIFT 21
Acked-by: Alexandre TORGUE <alexandre.torgue@foss.st.com>
Regards
Alex
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-08-16 15:52 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <DM3PR11MB871491A357B9A12BF1B0CC82DE16A@DM3PR11MB8714.namprd11.prod.outlook.com>
2023-08-16 15:40 ` [PATCH net-next v3 03/10] net: stmmac: mdio: enlarge the max XGMAC C22 ADDR to 31 Jisheng Zhang
2023-08-09 16:49 [PATCH net-next v3 00/10] net: stmmac: add new features to xgmac Jisheng Zhang
2023-08-09 16:50 ` [PATCH net-next v3 03/10] net: stmmac: mdio: enlarge the max XGMAC C22 ADDR to 31 Jisheng Zhang
2023-08-10 13:46 ` Alexandre TORGUE
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).