From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 292C2C83F14 for ; Tue, 29 Aug 2023 08:03:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=+kL+6v7syy0/cxIUarx9IBqTe/pmgZe+3NJa5Yrm7Es=; b=cqaQGf0WG8x3u1 wxRg8/+X3B/r07OoR2ZUVWLuS+iB/uLdQU4laJl6rzOoeov/8UdKaA2JSENMZBwZZiIl6YJkhVTeb KGPo3XTmT1cGE1c/9q/8HfSvCrjZeQWHRC10p1YvOuFQ2HAzn6XCLT18fE+TR8NmY9gHLLVTdlx7W /HsaKkQ/bzH03hCAWlmcZqIqQ1nuB1hJ0Bn4bpxIz+pYLWPv0cLHS8RX7ENmlGII56KW8ZAgOembJ yG0vP9F0tlAXLrfeg7JsHpKM4/fDdh3NLCo3dRpezsdjdudZt0C7CJ8IrnTT1Jph8EqfxZRaL78/t Q7B/G+EXG5v0dVJ727zA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qath7-00Azxw-0y; Tue, 29 Aug 2023 08:03:25 +0000 Received: from mail-wr1-x42d.google.com ([2a00:1450:4864:20::42d]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qath3-00Azuz-2Y for linux-arm-kernel@lists.infradead.org; Tue, 29 Aug 2023 08:03:23 +0000 Received: by mail-wr1-x42d.google.com with SMTP id ffacd0b85a97d-31c93d2a24fso1911273f8f.2 for ; Tue, 29 Aug 2023 01:03:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20221208; t=1693296192; x=1693900992; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=4gXf3eI1QYqFSBc9LYV5znKy6QYEcZ1Llv8J9Br/30g=; b=R4nfeAQe8389sakj85amigGqLjaTc5JmMj9kA/xecvE2GXDEaoUHkRK0WyXB3oI7pG N2Y3YUgKsb48TcEPLCZ9o2myLSza9uD5H7rEhmA8xr1ZDbiwGBiwDlqztMO84VEimyck 0lM3IQiAYPWmW0gii9vGagavXCxeBVCYRx/jLcwbJRG6c8pMvabk5XOr8qWhlz/YF6tG 3DY8AZUF9Gr0/dCw/TOgKsY32OYI9Bu9Jq1AqI/6TUUIv7fP37wD1kZRWIlVjow6EG5m nRV/+5QkP+eTrpPmQngb/iQ333LZWTcLuU1R+56qteSoUnZTu9scy5xqs4m6OOx0tvyU CNmA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1693296192; x=1693900992; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=4gXf3eI1QYqFSBc9LYV5znKy6QYEcZ1Llv8J9Br/30g=; b=dD5gYdHfVNBmlEpGZApA17amrVNh+/jUJ581dDxkihOaSL/WnyHYGvB77Ug/olRSLp iwbxLueg45uLZHQEh9de7ZT4n8T5u5Y9z5Tmnmkmh+gy7lkBofE3RZsgc/j/D5NLs9+0 doPLNpH+XOOnYbahMz3MfPOrh+73fMF7UXRUdgHRrxTJgiXGgzlLeZwefVZhILxnZnjj uvHIF1ixv6TbG2WwkfglSSZlU+ERiiM1J/TYUaFgK2U/ZBIhqw5xWCUR56PCiRx/sVan PmrQZm71npEEaEiGwQFPb06gzcEnJ7aLxUvh2IN/jvJKvgPlnxlRXDeIrVoSYrb8ZXP4 y/Eg== X-Gm-Message-State: AOJu0YyLL7UHoREpkOnP+hVbUh4aEV72v5RecCHGkhwNtAVh/voMtx7o +S2tkRmgVURjYlULFBuS5ZCHvg== X-Google-Smtp-Source: AGHT+IGxucRA+7L1hdHwgNAnEmkSoW5Bvkr6fFVHqCl2UnKHxiBF8oS42kFwTnL8bpzXsEtHLeDh5Q== X-Received: by 2002:a05:6000:229:b0:31c:8c93:61e3 with SMTP id l9-20020a056000022900b0031c8c9361e3mr4756583wrz.60.1693296191819; Tue, 29 Aug 2023 01:03:11 -0700 (PDT) Received: from google.com (65.0.187.35.bc.googleusercontent.com. [35.187.0.65]) by smtp.gmail.com with ESMTPSA id a17-20020adfe5d1000000b00317f70240afsm12819304wrn.27.2023.08.29.01.03.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 29 Aug 2023 01:03:11 -0700 (PDT) Date: Tue, 29 Aug 2023 09:03:05 +0100 From: Vincent Donnefort To: Marc Zyngier Cc: kvmarm@lists.linux.dev, kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, James Morse , Suzuki K Poulose , Oliver Upton , Zenghui Yu , Marek Szyprowski Subject: Re: [PATCH] KVM: arm64: Properly return allocated EL2 VA from hyp_alloc_private_va_range() Message-ID: References: <20230828153121.4179627-1-maz@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230828153121.4179627-1-maz@kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230829_010321_842705_88154A05 X-CRM114-Status: GOOD ( 21.54 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Aug 28, 2023 at 04:31:21PM +0100, Marc Zyngier wrote: > Marek reports that his RPi4 spits out a warning at boot time, > right at the point where the GICv2 virtual CPU interface gets > mapped. > > Upon investigation, it seems that we never return the allocated > VA and use whatever was on the stack at this point. Yes, this > is good stuff, and Marek was pretty lucky that he ended-up with > a VA that intersected with something that was already mapped. > > On my setup, this random value is plausible enough for the mapping > to take place. Who knows what happens... > > Cc: Vincent Donnefort > Fixes: f156a7d13fc3 ("KVM: arm64: Remove size-order align in the nVHE hyp private VA range") > Reported-by: Marek Szyprowski > Tested-by: Marek Szyprowski > Signed-off-by: Marc Zyngier > Link: https://lore.kernel.org/r/79b0ad6e-0c2a-f777-d504-e40e8123d81d@samsung.com Having a hard time reproducing the issue, but clearly that set is missing from the original patch! Sorry about that extra work. > --- > arch/arm64/kvm/mmu.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/arch/arm64/kvm/mmu.c b/arch/arm64/kvm/mmu.c > index 11c1d786c506..50be51cc40cc 100644 > --- a/arch/arm64/kvm/mmu.c > +++ b/arch/arm64/kvm/mmu.c > @@ -652,6 +652,9 @@ int hyp_alloc_private_va_range(size_t size, unsigned long *haddr) > > mutex_unlock(&kvm_hyp_pgd_mutex); > > + if (!ret) > + *haddr = base; > + > return ret; > } > > -- > 2.34.1 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel