From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id EE013C83F14 for ; Tue, 29 Aug 2023 09:01:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=jkVNhkdk75fgJ7Cxo+LcwNpryyFneNvvrpM9qTPXnSs=; b=ad64QzRa/rPpJG gRKBG4ojlDl9de+hWjZ5mSW7ybFQ3n3CEfHfrle9I0uM4mqYfW/L+1f+NHoSVq+PMEnPuRC7oCnA6 qHV5o4t4BQEzWUWgtb7NYJxDHiE0MMDQ09ciwIJrkneeI3zkUNgyd/qfK2QqBPEP4MNdZKJMs2YNF RRctdo7inppSaCAYWwbB725PjsgNYvvmkyWVzXSQcFvWYuNE+j8QSVumIN/ZjCQnWeS4zx8JGEn0w gwqPcEe0X6BY0NzxdkQmlxFqNZMAhYEyJYT6240EUjh8Be8bJMU2svhyIqCp4SfcsbGsrCD2vwwRj JXCa9PlOqXTTQRl30eCg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qauai-00B5BK-1y; Tue, 29 Aug 2023 09:00:52 +0000 Received: from mail-wr1-x434.google.com ([2a00:1450:4864:20::434]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qauaf-00B5Am-0X for linux-arm-kernel@lists.infradead.org; Tue, 29 Aug 2023 09:00:50 +0000 Received: by mail-wr1-x434.google.com with SMTP id ffacd0b85a97d-31c63cd4ec2so3435248f8f.0 for ; Tue, 29 Aug 2023 02:00:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20221208; t=1693299645; x=1693904445; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=bHTLgnpFFXBTfxGfgdL+O85r9b9TDOpfmvwoDKUJVxM=; b=oe8F/g5G1FboEK+FTF4IaG7O0bvi+XeMcUw0IQJ32dDscxNEQw5DQITzn7VYozPDgD qgTfy2+lbiZTHAbiTuJQNR8oWdQJxdEoSMT9nKrbDxe4YGLd0rOGnVKcMMJ4Ds6ERZwC uqSy743PdciabyVUvxq95A1EwjCrGSyEX5RVjfjtDfKGwuX/iLnZBVK2Vsv8Xu7olwmZ qFLtEMtvM8MWQtwAprv/UJC9IsXprMJ+cyr50ylDzHrCx57Xs19vk43C2dUHIpQajN5D 32mtUEY2zeIHuwcXLcttFRxcXiSEPmbl6MiIxDN+7Hm2QNCAsjK0S/nk2Pw2yFCLok68 aC/Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1693299645; x=1693904445; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=bHTLgnpFFXBTfxGfgdL+O85r9b9TDOpfmvwoDKUJVxM=; b=DAFHLpFfbb5G8Y6ZjqB1DaxyKdyHpz5iNpjQYPLrPrZgQFZGtYvpgApiJj7GylWTZX cFUY5U+Ok8udNAuSsBn8RmACkA2r8TgAxvOe9bhiZE9e9yU5kLdUTcJgYbshWA7Q74Hf J5C1DiqlzJTkhRpqmLu+SiLXURlQDZHVjWJauFqO7hVMvBtYxB42P5df5TAr8HIW+uqb vHyMStnrDfeS2N9CkVurKqP9Egaszk+eRJEILyGh6Z5KEnSehg3oTaUrr+ftwtslbt4W m0FYmy/vGIy++gZZw/WORRZojzTjCW5ephBkgZGxUHAULEVJfXnLsl7K/Nry2HS/T0B0 dbdQ== X-Gm-Message-State: AOJu0YwA8RCFXtfpKQducyFKTdosjKxc5hXGSszTMHkYDbIYcjJVHyCg mEtWDMXrD9VOeR+SMfUf1oHozg== X-Google-Smtp-Source: AGHT+IGN+EhT5kZpnXUg/V1iMKklDj4SQ+Z6bHXsO2fecs6GWuss4AMe2t7VQU16A4d6hDd3nf1zXw== X-Received: by 2002:a5d:40cd:0:b0:317:5168:c21f with SMTP id b13-20020a5d40cd000000b003175168c21fmr20457804wrq.31.1693299645067; Tue, 29 Aug 2023 02:00:45 -0700 (PDT) Received: from google.com (65.0.187.35.bc.googleusercontent.com. [35.187.0.65]) by smtp.gmail.com with ESMTPSA id d11-20020a056000114b00b0031c6dc684f8sm13112683wrx.20.2023.08.29.02.00.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 29 Aug 2023 02:00:44 -0700 (PDT) Date: Tue, 29 Aug 2023 10:00:40 +0100 From: Vincent Donnefort To: Marc Zyngier Cc: kvmarm@lists.linux.dev, kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, James Morse , Suzuki K Poulose , Oliver Upton , Zenghui Yu , Marek Szyprowski Subject: Re: [PATCH] KVM: arm64: Properly return allocated EL2 VA from hyp_alloc_private_va_range() Message-ID: References: <20230828153121.4179627-1-maz@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230829_020049_210654_79C3123D X-CRM114-Status: GOOD ( 23.88 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Aug 29, 2023 at 09:03:05AM +0100, Vincent Donnefort wrote: > On Mon, Aug 28, 2023 at 04:31:21PM +0100, Marc Zyngier wrote: > > Marek reports that his RPi4 spits out a warning at boot time, > > right at the point where the GICv2 virtual CPU interface gets > > mapped. > > > > Upon investigation, it seems that we never return the allocated > > VA and use whatever was on the stack at this point. Yes, this > > is good stuff, and Marek was pretty lucky that he ended-up with > > a VA that intersected with something that was already mapped. > > > > On my setup, this random value is plausible enough for the mapping > > to take place. Who knows what happens... > > > > Cc: Vincent Donnefort > > Fixes: f156a7d13fc3 ("KVM: arm64: Remove size-order align in the nVHE hyp private VA range") > > Reported-by: Marek Szyprowski > > Tested-by: Marek Szyprowski > > Signed-off-by: Marc Zyngier > > Link: https://lore.kernel.org/r/79b0ad6e-0c2a-f777-d504-e40e8123d81d@samsung.com > > Having a hard time reproducing the issue, but clearly that set is missing from > the original patch! > > Sorry about that extra work. Reviewed-by: Vincent Donnefort > > > --- > > arch/arm64/kvm/mmu.c | 3 +++ > > 1 file changed, 3 insertions(+) > > > > diff --git a/arch/arm64/kvm/mmu.c b/arch/arm64/kvm/mmu.c > > index 11c1d786c506..50be51cc40cc 100644 > > --- a/arch/arm64/kvm/mmu.c > > +++ b/arch/arm64/kvm/mmu.c > > @@ -652,6 +652,9 @@ int hyp_alloc_private_va_range(size_t size, unsigned long *haddr) > > > > mutex_unlock(&kvm_hyp_pgd_mutex); > > > > + if (!ret) > > + *haddr = base; > > + > > return ret; > > } > > > > -- > > 2.34.1 > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel