From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C3A06C83F12 for ; Tue, 29 Aug 2023 11:42:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=LVYyeLOn/V9NkJQPVV4EtVu25I0jnwQ0oOw0bMEoL7w=; b=UIZlEO4DSnaLpN 4DebYCnnxH0KTCQef0H769ppIFohWLbgoSvVaK7AZy7A8b2QdkhDqmB/jRwgw/aim4XAkLbUMK9td uq7B6Pqjud+pQRaRNfJnPcOWsdxTdCqThratgxqELl7eD//HdMtBks1j1xg0SUDPP5hzY5+WQw+oN mafL/zax7VOKnzkXzJoC6wS486ZyAlRNLiVZYyLhm3DqQ+IKgzioCtOxOpk7kk//K7JwTr58zNQEy b6ubydtncw27lqBzBFNuXDseT1XfSkQBM9wqs8/CRr0EMazPr4/2GaUA9qsiyT/pXID6DgHzAdOqP weC2Za6JCnSPWmstZ6tg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qax6W-00BQtV-13; Tue, 29 Aug 2023 11:41:52 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qax6S-00BQsp-2B for linux-arm-kernel@lists.infradead.org; Tue, 29 Aug 2023 11:41:50 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 30E0F6147D; Tue, 29 Aug 2023 11:41:48 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 625D8C433C8; Tue, 29 Aug 2023 11:41:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1693309307; bh=ymfDnb1wNojQ0jGjJUgnVBim6gA/rLm0coxCCDMJGWI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=QhbD38kB5M9zVuy7OYjG0Q92tnvjC1HsMMr4zWzHR20mIk43cpLQPVNCiEx+Dji0Z lnk14D7A/Fnrxy3UGN9ZDQr7KGesf5cAhrjbwc52kxErnmrtslx2XIDoZzvX3lqkRL fcdD1UB35h4syD44cYE5LWl4hHf+RH0HPd0Km043uN6R4f1iZimUyC6sneECVGll4b e2O2k/izNe2/d4aispw15Y8mwBX45y3P7OneCy/p75qJo3E50Cs7rAUP5pMmvUrQLH QoY6/X7DgEpVX6jP8aGzNPHSchPj2DnCfFE4S3bs8KLmH6LDsxmKke+lrS1hx54VKb hjrdGbW4mKftg== Date: Tue, 29 Aug 2023 19:29:52 +0800 From: Jisheng Zhang To: "Russell King (Oracle)" Cc: Giuseppe Cavallaro , Alexandre Torgue , Jose Abreu , "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Maxime Coquelin , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Vladimir Zapolskiy , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , Emil Renner Berthing , Samin Guo , Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Thierry Reding , Jonathan Hunter , Nobuhiro Iwamatsu , Matthias Brugger , AngeloGioacchino Del Regno , Bartosz Golaszewski , netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net-next 00/22] convert to devm_stmmac_probe_config_dt Message-ID: References: <20230829104033.955-1-jszhang@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230829_044148_774591_EEDC8CB3 X-CRM114-Status: GOOD ( 18.74 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Aug 29, 2023 at 12:21:29PM +0100, Russell King (Oracle) wrote: > On Tue, Aug 29, 2023 at 06:40:11PM +0800, Jisheng Zhang wrote: > > Russell pointed out there's a new devm_stmmac_probe_config_dt() > > helper now when reviewing my starfive gmac error handling patch[1]. > > After greping the code, this nice helper was introduced by Bartosz in > > [2], I think it's time to convert all dwmac users to this helper and > > finally complete the TODO in [2] "but once all users of the old > > stmmac_pltfr_remove() are converted to the devres helper, it will be > > renamed back to stmmac_pltfr_remove() and the no_dt function removed." > > I think a useful final patch may be to make stmmac_probe_config_dt() > static so there aren't any new uses of stmmac_probe_config_dt(). Good idea! > > Also note that net-next is now closed, so please wait until after -rc1 > for net-next to re-open, or post as RFC. Thanks. oops, I didn't notice this cycle of window is closed, I will wait for next development window. Thank you > > -- > RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ > FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last! _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel