From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1DE58C71153 for ; Tue, 29 Aug 2023 14:52:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=cR7sNtDj5SHbbhTenikElkPcz/yUPdGW+WMoJPp5xGk=; b=Q/VO1B8EGYwzch H5gvYVugxZS1RB/6KcG7LEACVApQGcEvNkVS+CQ/YFKKTLU87IHuaXu6rGa7B8+5lkmBzCKiT7nDQ PGKcN1McSmL7RCT33mFfh+l12tBvdY/eXUiZlIXFuDPtdUP2oQTDi8CtASBE59FsvN4jnHiXi8ui2 jl7caSTaxFZYpT0GsTawvVb5hpEx2JCxIqe3FVEmM4WMmXMdVd28J4Izv2u38D3O0ca+no2LCJ9iK ht71T6aK6c2MmELFoksmDzJZHG4N/u6iYz1216oxTUgOXvGn+xP1uEo9fVyFsWeMKf3z+4uKPjqyE 6ewUiU4le9S5ncnpDmOA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qb042-00BjMT-1F; Tue, 29 Aug 2023 14:51:30 +0000 Received: from [2001:4d48:ad52:32c8:5054:ff:fe00:142] (helo=pandora.armlinux.org.uk) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qb03z-00BjLs-1I for linux-arm-kernel@lists.infradead.org; Tue, 29 Aug 2023 14:51:29 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=zucveyWpJ8nh/whOJskv5u4rNtkAFo2YaIGg2aE8F/U=; b=Kqnb4BQFfO0OsxgTlaYOQmv61q BA2O78Gnus/v9Srs9hKh7CEsc17CnatOWi++HAqvxYRGbahQQbcMtwkRrzadnFZabQr5j546KzTJi V7bzhnxKiCLPU5LfBMF/+IXZgsQgto6iCN9q7a/pVpBde/tF4KoLNa+HgfSikcPYxiQpNZ+TgRkv4 GAKADTpU1WWdiUJKUzRDZpEpmmQdnz70FP4cQAm9z5NBUK7/JeY9aJl2ImKX0vSAggm4leNEa2G8r 6ib7/67QSYaMKJbmA57ryBR4ldDMNp2G8xJDm2YKGh+UzVTBPBIYdaV3zV1KdhH3RdpwZ66RJIyDZ mVKIt9qw==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:58232) by pandora.armlinux.org.uk with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1qb02f-0000cz-1o; Tue, 29 Aug 2023 15:50:05 +0100 Received: from linux by shell.armlinux.org.uk with local (Exim 4.94.2) (envelope-from ) id 1qb02K-0004jk-Oo; Tue, 29 Aug 2023 15:49:44 +0100 Date: Tue, 29 Aug 2023 15:49:44 +0100 From: "Russell King (Oracle)" To: Peter Zijlstra Cc: Mihai Carabas , Joao Martins , Catalin Marinas , Will Deacon , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Paolo Bonzini , Wanpeng Li , Vitaly Kuznetsov , "Rafael J. Wysocki" , Daniel Lezcano , Andrew Morton , Kees Cook , Petr Mladek , Ard Biesheuvel , Sami Tolvanen , Nicholas Piggin , Juerg Haefliger , =?iso-8859-1?Q?Micka=EBl_Sala=FCn?= , Arnd Bergmann , Ankur Arora , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kvm@vger.kernel.org, linux-pm@vger.kernel.org Subject: Re: [PATCH 5/7] arm64: Select ARCH_HAS_CPU_RELAX Message-ID: References: <1691581193-8416-1-git-send-email-mihai.carabas@oracle.com> <1691581193-8416-6-git-send-email-mihai.carabas@oracle.com> <20230809134941.GN212435@hirez.programming.kicks-ass.net> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230809134941.GN212435@hirez.programming.kicks-ass.net> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230829_075127_441128_4D83F16E X-CRM114-Status: GOOD ( 20.06 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Aug 09, 2023 at 03:49:41PM +0200, Peter Zijlstra wrote: > On Wed, Aug 09, 2023 at 02:39:39PM +0300, Mihai Carabas wrote: > > From: Joao Martins > > > > cpu_relax() is necessary to allow cpuidle poll-state to be used, > > so select it from ARM64 kconfig. > > > > Signed-off-by: Joao Martins > > Signed-off-by: Mihai Carabas > > --- > > arch/arm64/Kconfig | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/arch/arm64/Kconfig b/arch/arm64/Kconfig > > index 87ade6549790..7c47617b5722 100644 > > --- a/arch/arm64/Kconfig > > +++ b/arch/arm64/Kconfig > > @@ -105,6 +105,7 @@ config ARM64 > > select ARCH_WANT_LD_ORPHAN_WARN > > select ARCH_WANTS_NO_INSTR > > select ARCH_WANTS_THP_SWAP if ARM64_4K_PAGES > > + select ARCH_HAS_CPU_RELAX > > select ARCH_HAS_UBSAN_SANITIZE_ALL > > select ARM_AMBA > > select ARM_ARCH_TIMER > > Uh what ?! cpu_relax() is assumed present on all archs, no? I think you have x86 to blame for that! That symbol is used in drivers/acpi/processor_idle.c to setup stuff for the cpuidle polling, and also by cpuidle's Makefile to build poll_state.o It isn't to do with the presence of cpu_relax() or not. It probably ought to be renamed to CPUIDLE_CPU_RELAX which would better describe its modern purpose. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last! _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel