From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 51C5AEE4981 for ; Sat, 19 Aug 2023 07:03:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=8ieYdVqcdW9hTFxIhagHhA/enYBpKbdBOy+pHsj3uVo=; b=n1ywP+kjZ5+Dit v4d3sH8wGA+6RPuQ8oR3RRhrxTXcWqCZ83D8ug8XdceYB4znQvz4KIATXDoBhKgA00oT4rQSqk+41 KPKnGZRz+L268orgbBVT6rCGwY7Ub1tRY9CvChLhjSUM+/u4w2cf+9U2z094sH/Ce/1/gB1eZ11KW dR5weJQKWvcsf2MePwLCjFpyYd9aMRnyGCmcdBTPVlsQdXirNW5+VVVchdZu+WL/RDdhvUP2m1FkU OdT072yyvBtck5x9N4lGANoPu744zZims4djAYuEXEwv0FMi5AmTyYe5467P0xWg2GZ3grR5BPOxV esLjq+IgjicBJRrotJyA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qXFzr-00AW87-0j; Sat, 19 Aug 2023 07:03:43 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qXFzo-00AW7m-2B for linux-arm-kernel@lists.infradead.org; Sat, 19 Aug 2023 07:03:41 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id EE8446157A; Sat, 19 Aug 2023 07:03:39 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2B0C7C433C8; Sat, 19 Aug 2023 07:03:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1692428619; bh=zaCiXBQ9Im6UJf9wKSq8d9Iu/HdAEmZZBSgF+FKSMHk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=F1yuBtk7hz9AuosnOhN1SU2tUPCMI6xCApiWPhXop5LlN9ktTnXskwRjUf2YczQ84 v+rGAXf9rAvjIzxKQDPvDgaWz0R9pLsoNCoNI5s8yfCf7sAcEkQ2SlSMZZG7ckFhL5 gL5/2LAhOqDlABRsR1gN+nmGOGnBrD/e/LbGw2vsqGezyzWb3nwX5XYMOXYhv353/m JZ6vFGGWHpUcChCmfJ61RkAQeBJVTQmeBh+dLHxEsLgOKAopctQXKwoVqW/KckLVpn dCs0Szg5suXVXqXTmLkM7rImOopJ+7TzvbRWHLL97yI3ow/S6b/ffuODEF5KEc9bK/ 2k/bEpyqWTEuQ== Date: Sat, 19 Aug 2023 09:03:34 +0200 From: Simon Horman To: Ruan Jinjie Cc: horatiu.vultur@microchip.com, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, lars.povlsen@microchip.com, Steen.Hegelund@microchip.com, daniel.machon@microchip.com, richardcochran@gmail.com, netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH net-next v2 0/3] net: Update and fix return value check for vcap_get_rule() Message-ID: References: <20230818050505.3634668-1-ruanjinjie@huawei.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230818050505.3634668-1-ruanjinjie@huawei.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230819_000340_760627_C1110970 X-CRM114-Status: GOOD ( 13.92 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Aug 18, 2023 at 01:05:02PM +0800, Ruan Jinjie wrote: > As Simon Horman suggests, update vcap_get_rule() to always > return an ERR_PTR() and update the error detection conditions to > use IS_ERR(), which would be more cleaner. > > So se IS_ERR() to update the return value and fix the issue > in lan966x_ptp_add_trap(). > > Changes in v2: > - Update vcap_get_rule() to always return an ERR_PTR(). > - Update the return value fix in lan966x_ptp_add_trap(). > - Update the return value check in sparx5_tc_free_rule_resources(). > > Ruan Jinjie (3): > net: microchip: vcap api: Always return ERR_PTR for vcap_get_rule() > net: lan966x: Fix return value check for vcap_get_rule() > net: microchip: sparx5: Update return value check for vcap_get_rule() Thanks. For the series, Reviewed-by: Simon Horman _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel