From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CD9C2EE4996 for ; Mon, 21 Aug 2023 08:35:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=t9E4ZahvMvIsIyOleyHT/CNHOjqeTH358IdhjRD2OBQ=; b=0dg1ByfniC5l0D xVDw+g4EiEyqfNgGCE8xzX23gSl5JEIqkhTf88vJQkLniKy6aQZPYB96BiUEMT1GY/Z00Z6tZDlwy kn2sLCl8d7Aki98UoWqc4cByytlbYm7XHpWjgj4QoNyYkytVLrFzBdR3kIdYLT3fjaKGHkPLAoA1h MFR0LZXZFZySw2tENzVvg7uJxXfqjIUlFAJeHypUJ0PIMAMJow+zdN27MzviflS8Azq8vSDEYjO+Z 4KkXKYvKnBN4EFj6MxYe/68zeqboYVTndqLkDjd4Cz7ma+P3H6+IYmPy8JyRmZONkuHuDzNDdnYbm L6Uut51dJdW1xpZ/dYKQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qY0NL-00DUbN-23; Mon, 21 Aug 2023 08:35:03 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qY0NI-00DUZx-1o; Mon, 21 Aug 2023 08:35:02 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id AF67962D37; Mon, 21 Aug 2023 08:34:59 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id BCE5BC433C7; Mon, 21 Aug 2023 08:34:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1692606898; bh=oEQbal5/vxqRGZ3YLafZj8Knbvn9kAOi/AFZtF9uDxU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=KTDJqY5Yjj4O2DGZawjCbvMfpNiue4Yewjl6wur35PIheVqyPapwog1sJB5n89Ajm jvZ0Y0a9XpQ39CzToNwGXA0cCcfRVNsNzZB80eFLy2SnIkCi0eYp2mOLyajO52bIeF Gysae0y+8BV1c4+/IJtvMD1LB+TZa0gtQzc0+AXQegNjbA7xXv3eHDi7ojoOdnBCXV /ICtDfJN3agBpY0kkaQcJjRgoh9r8optOCWGCUYjQ0omVc1F/WxYvUsApbnxHzSX4Y rGbTeDp46sriFOPRhAC8FddeSDgr35+GEvy8jVUmyDFDtIaxE+/APWux6jEeRDxpGR Ygd+84jMdrElg== Date: Mon, 21 Aug 2023 10:34:51 +0200 From: Lorenzo Pieralisi To: Jim Quinlan Cc: linux-pci@vger.kernel.org, Nicolas Saenz Julienne , Bjorn Helgaas , Lorenzo Pieralisi , Cyril Brulebois , Phil Elwell , bcm-kernel-feedback-list@broadcom.com, Conor Dooley , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Florian Fainelli , Jim Quinlan , Krzysztof Kozlowski , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , "moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE" , open list , "moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE" , Rob Herring Subject: Re: [PATCH v6 0/5] PCI: brcmstb: Configure appropriate HW CLKREQ# mode Message-ID: References: <20230623144100.34196-1-james.quinlan@broadcom.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230623144100.34196-1-james.quinlan@broadcom.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230821_013500_684215_E470BCF5 X-CRM114-Status: GOOD ( 26.48 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Jun 23, 2023 at 10:40:53AM -0400, Jim Quinlan wrote: > v6 -- No code has been changed. > -- Changed commit subject and comment in "#PERST" commit (Bjorn, Cyril) > -- Changed sign-off and author email address for all commits. > This was due to a change in Broadcom's upstreaming policy. > > v5 -- Remove DT property "brcm,completion-timeout-us" from > "DT bindings" commit. Although this error may be reported > as a completion timeout, its cause was traced to an > internal bus timeout which may occur even when there is > no PCIe access being processed. We set a timeout of four > seconds only if we are operating in "L1SS CLKREQ#" mode. > -- Correct CEM 2.0 reference provided by HW engineer, > s/3.2.5.2.5/3.2.5.2.2/ (Bjorn) > -- Add newline to dev_info() string (Stefan) > -- Change variable rval to unsigned (Stefan) > -- s/implementaion/implementation/ (Bjorn) > -- s/superpowersave/powersupersave/ (Bjorn) > -- Slightly modify message on "PERST#" commit. > -- Rebase to torvalds master > > v4 -- New commit that asserts PERST# for 2711/RPi SOCs at PCIe RC > driver probe() time. This is done in Raspian Linux and its > absence may be the cause of a failing test case. > -- New commit that removes stale comment. > > v3 -- Rewrote commit msgs and comments refering panics if L1SS > is enabled/disabled; the code snippet that unadvertises L1SS > eliminates the panic scenario. (Bjorn) > -- Add reference for "400ns of CLKREQ# assertion" blurb (Bjorn) > -- Put binding names in DT commit Subject (Bjorn) > -- Add a verb to a commit's subject line (Bjorn) > -- s/accomodat(\w+)/accommodat$1/g (Bjorn) > -- Rewrote commit msgs and comments refering panics if L1SS > is enabled/disabled; the code snippet that unadvertises L1SS > eliminates the panic scenario. (Bjorn) > > v2 -- Changed binding property 'brcm,completion-timeout-msec' to > 'brcm,completion-timeout-us'. (StefanW for standard suffix). > -- Warn when clamping timeout value, and include clamped > region in message. Also add min and max in YAML. (StefanW) > -- Qualify description of "brcm,completion-timeout-us" so that > it refers to PCIe transactions. (StefanW) > -- Remvove mention of Linux specifics in binding description. (StefanW) > -- s/clkreq#/CLKREQ#/g (Bjorn) > -- Refactor completion-timeout-us code to compare max and min to > value given by the property (as opposed to the computed value). > > v1 -- The current driver assumes the downstream devices can > provide CLKREQ# for ASPM. These commits accomodate devices > w/ or w/o clkreq# and also handle L1SS-capable devices. > > -- The Raspian Linux folks have already been using a PCIe RC > property "brcm,enable-l1ss". These commits use the same > property, in a backward-compatible manner, and the implementaion > adds more detail and also automatically identifies devices w/o > a clkreq# signal, i.e. most devices plugged into an RPi CM4 > IO board. > > > Jim Quinlan (5): > dt-bindings: PCI: brcmstb: Add brcm,enable-l1ss property > PCI: brcmstb: Configure HW CLKREQ# mode appropriate for downstream > device I am not merging the first two patches since the discussion thread is still open and I'd like to understand better what can/should be done, sorry. > PCI: brcmstb: Set higher value for internal bus timeout > PCI: brcmstb: Assert PERST# on BCM2711 > PCI: brcmstb: Remove stale comment Is it OK to apply these three on their own ? Overall it would be great to avoid mixing patches with different end goals in a single series. Thanks, Lorenzo > .../bindings/pci/brcm,stb-pcie.yaml | 9 ++ > drivers/pci/controller/pcie-brcmstb.c | 91 ++++++++++++++++--- > 2 files changed, 89 insertions(+), 11 deletions(-) > > > base-commit: 8a28a0b6f1a1dcbf5a834600a9acfbe2ba51e5eb > -- > 2.17.1 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel