From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4715AC6FA8F for ; Thu, 24 Aug 2023 18:32:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=1OFZLObXI7s5tf0aLdNzxwKSR4feJroFECHu8M55mRM=; b=YPDoquHeCUToC1 cloKRxX/rW75osfbXDcnGQIXWtT+F9EghqbGwfdjNoM6P5yIlLn0BEMutTA7hrla1l0+cye7YlKhU +YR5U4QIscCXNtbth5/6QsaLZnKZjhHyGzx/goFLDEOyM93gTUFLk30K9rcnsoiYHa8Z3IA3j4DpR G/cTnWwm6Ena6jVACi6esFx1andSmTSdH/slVnTdpv1n8MlpJdelyl9tMGQtx1TrEnQm+1oVBRa+g rlmBrwYHEFfPo9KWmS6sAY+mqKftxxS6jyxIg9Nok/uDBLVhUTL+bLxuFi+OdnqvlBVpoQDRl/yPl QPFjVPcihSifqYIwO04A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qZF7z-003asj-0C; Thu, 24 Aug 2023 18:32:19 +0000 Received: from mail-ej1-x62b.google.com ([2a00:1450:4864:20::62b]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qZF7v-003asD-2T for linux-arm-kernel@lists.infradead.org; Thu, 24 Aug 2023 18:32:17 +0000 Received: by mail-ej1-x62b.google.com with SMTP id a640c23a62f3a-99df431d4bfso8411566b.1 for ; Thu, 24 Aug 2023 11:32:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1692901934; x=1693506734; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:feedback-id:from:to:cc:subject:date :message-id:reply-to; bh=jPlwIuXS4UKNdwnv7dloCDkuc6cLmXeTG3uvRrx0mcc=; b=AMrfHRJyOccu2U1+VViw/W5kSSakls1k6XEM2l+XA2ikpvbNc5CjPHOKd+S8cAgmxB ifln8PRBXTTy667HLc2M0J9OBpMGT4SY7YR3yGWE4RPiVbS8xgwg+iyIw9DnjOY0Bu12 seKj6LhzYfkqiihsE+M9TuazFlSD8dWijS9Or1ipmamiKhW6c6v+1ExtJmeNqrxHAcri +Xnt+j+8YxZLjpw4n1RONcQ4m0bs/79N7fv6iAjV8YS8moWOB0wQttJ0FcjvkQtf+KEN IVtT0tGbaPM21Z8O7s7qYGj9kcaTar4Aja2e6R/11LDP0jpZr9mM04PIxpYCqod8ELkB xXuA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1692901934; x=1693506734; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:feedback-id:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=jPlwIuXS4UKNdwnv7dloCDkuc6cLmXeTG3uvRrx0mcc=; b=kTd3rSCPViJQqnod/VipXLcBCj8Q8MI5zr1Xh2uHzAwM7qlHy4BBgPeXUV9rj6zqtD 0vpaAUPh41RSG6UCENLzoDCMaRPB7g1zi0XS1PUGLrX7u+Y6kRdZ2x+abG67mF3ztCS/ ITQzHR8+jP1yJ7CBBUDn3kaF0fuyuIRMh61P65qGKt6OFKn057WtdAeuaLxRwyp2YPMW 3hWuR8ynd2AEaYWtpI3IYJTLZy4PRClhSNFb9BmF+lMQbeZlNZpdTs+o6kghC+09GX/Y HsQgzJqo5dEOoXRPpxYvP7MwQ6U5BRLWHsMUl/3bcXt5kK8dWVv6KHbzSH+AtREogUVv Wl8Q== X-Gm-Message-State: AOJu0YzkCBLYRmmXTqE815A++5dFi+84CEVdnfvdT8NqfQn9fiQpGFGQ G7YgovSPn6NZUlSH/urUZZPdAFSegQ0= X-Google-Smtp-Source: AGHT+IHbCZyG5/7et0uig8UAuRPjyBzz20Gw3VrhhgrsbCSWXKLDR7YVo8khW5+Ne6maGO7ViU80UA== X-Received: by 2002:a17:906:5385:b0:99c:55c0:ad15 with SMTP id g5-20020a170906538500b0099c55c0ad15mr12900344ejo.38.1692901933771; Thu, 24 Aug 2023 11:32:13 -0700 (PDT) Received: from auth2-smtp.messagingengine.com (auth2-smtp.messagingengine.com. [66.111.4.228]) by smtp.gmail.com with ESMTPSA id fy3-20020a170906b7c300b009894b476310sm11087708ejb.163.2023.08.24.11.32.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 24 Aug 2023 11:32:13 -0700 (PDT) Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailauth.nyi.internal (Postfix) with ESMTP id 737EF27C0054; Thu, 24 Aug 2023 14:32:01 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Thu, 24 Aug 2023 14:32:01 -0400 X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedviedruddviedguddvgecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpeffhffvvefukfhfgggtuggjsehttdertddttddvnecuhfhrohhmpeeuohhq uhhnucfhvghnghcuoegsohhquhhnrdhfvghnghesghhmrghilhdrtghomheqnecuggftrf grthhtvghrnhephedugfduffffteeutddvheeuveelvdfhleelieevtdeguefhgeeuveei udffiedvnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomh epsghoqhhunhdomhgvshhmthhprghuthhhphgvrhhsohhnrghlihhthidqieelvdeghedt ieegqddujeejkeehheehvddqsghoqhhunhdrfhgvnhhgpeepghhmrghilhdrtghomhesfh higihmvgdrnhgrmhgv X-ME-Proxy: Feedback-ID: iad51458e:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 24 Aug 2023 14:31:59 -0400 (EDT) Date: Thu, 24 Aug 2023 11:31:23 -0700 From: Boqun Feng To: Nuno Das Neves Cc: linux-hyperv@vger.kernel.org, linux-kernel@vger.kernel.org, x86@kernel.org, linux-arm-kernel@lists.infradead.org, linux-arch@vger.kernel.org, patches@lists.linux.dev, mikelley@microsoft.com, kys@microsoft.com, wei.liu@kernel.org, haiyangz@microsoft.com, decui@microsoft.com, apais@linux.microsoft.com, Tianyu.Lan@microsoft.com, ssengar@linux.microsoft.com, mukeshrathor@microsoft.com, stanislav.kinsburskiy@gmail.com, jinankjain@linux.microsoft.com, vkuznets@redhat.com, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com, hpa@zytor.com, will@kernel.org, catalin.marinas@arm.com Subject: Re: [PATCH v2 15/15] Drivers: hv: Add modules to expose /dev/mshv to VMMs running on Hyper-V Message-ID: References: <1692309711-5573-1-git-send-email-nunodasneves@linux.microsoft.com> <1692309711-5573-16-git-send-email-nunodasneves@linux.microsoft.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1692309711-5573-16-git-send-email-nunodasneves@linux.microsoft.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230824_113215_806123_7629751D X-CRM114-Status: GOOD ( 11.26 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Aug 17, 2023 at 03:01:51PM -0700, Nuno Das Neves wrote: [...] > +static long > +mshv_dev_ioctl(struct file *filp, unsigned int ioctl, unsigned long arg) > +{ > + switch (ioctl) { > + case MSHV_CHECK_EXTENSION: > + return mshv_ioctl_check_extension((void __user *)arg); > + case MSHV_CREATE_PARTITION: > + return mshv.create_partition((void __user *)arg); > + case MSHV_CREATE_VTL: > + return mshv.create_vtl((void __user *)arg); > + } > + Shouldn't we also have a MSHV_GET_API_VERSION ioctl similar as KVM? So that in the future when we change these ioctl interfaces or semantics, we can bump up the API version to avoid breaking userspace? Regards, Boqun _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel